[PATCH v2 01/11] dt-bindings: ASoC: admaif: Add missing properties

Sheetal . posted 11 patches 9 months, 2 weeks ago
There is a newer version of this series
[PATCH v2 01/11] dt-bindings: ASoC: admaif: Add missing properties
Posted by Sheetal . 9 months, 2 weeks ago
From: Sheetal <sheetal@nvidia.com>

Add interconnect and iommus properties in admaif yaml.

This fixes dtbs_check error:
 'interconnect-names', 'interconnects', 'iommus' do not match
 any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Sheetal <sheetal@nvidia.com>
---
 .../bindings/sound/nvidia,tegra210-admaif.yaml      | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
index 15ab40aeab1e..3008ab4c96ad 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
@@ -39,6 +39,19 @@ properties:
 
   dma-names: true
 
+  interconnects:
+    items:
+      - description: APE read memory client
+      - description: APE write memory client
+
+  interconnect-names:
+    items:
+      - const: dma-mem # read
+      - const: write
+
+  iommus:
+    maxItems: 1
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
     description: |
-- 
2.17.1
Re: [PATCH v2 01/11] dt-bindings: ASoC: admaif: Add missing properties
Posted by Krzysztof Kozlowski 9 months, 2 weeks ago
On Tue, Apr 29, 2025 at 05:59:31AM GMT, Sheetal . wrote:
> From: Sheetal <sheetal@nvidia.com>
> 
> Add interconnect and iommus properties in admaif yaml.
> 
> This fixes dtbs_check error:
>  'interconnect-names', 'interconnects', 'iommus' do not match
>  any of the regexes: 'pinctrl-[0-9]+'

Don't wrap error message, unless it is very long.

Would be nice to say whether these are valid for hardware or at least
with boards/SoCs have them.

Otherwise, considering that I cannot reproduce above issue (and the
firsr random DTS I looked at does not have these properties), I have
doubts this is a correct approach.

Best regards,
Krzysztof