Extern is the default specifier for a function, no need to define it.

Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
 include/linux/pinctrl/machine.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/pinctrl/machine.h b/include/linux/pinctrl/machine.h
index 673e96df453b..0940fabb154d 100644
--- a/include/linux/pinctrl/machine.h
+++ b/include/linux/pinctrl/machine.h
@@ -153,10 +153,10 @@ struct pinctrl_map;
 
 #ifdef CONFIG_PINCTRL
 
-extern int pinctrl_register_mappings(const struct pinctrl_map *map,
-				     unsigned int num_maps);
-extern void pinctrl_unregister_mappings(const struct pinctrl_map *map);
-extern void pinctrl_provide_dummies(void);
+int pinctrl_register_mappings(const struct pinctrl_map *map,
+			      unsigned int num_maps);
+void pinctrl_unregister_mappings(const struct pinctrl_map *map);
+void pinctrl_provide_dummies(void);
 #else
 
 static inline int pinctrl_register_mappings(const struct pinctrl_map *map,

-- 
2.39.5

On Tue, Apr 29, 2025 at 5:08 PM Thomas Richard
<thomas.richard@bootlin.com> wrote:
>
> Extern is the default specifier for a function, no need to define it.

Suggested-by ?

...

> +int pinctrl_register_mappings(const struct pinctrl_map *map,
> +                             unsigned int num_maps);

Now it can be on one line.

...

With the above being addressed,
Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko

On 4/29/25 21:49, Andy Shevchenko wrote:
> On Tue, Apr 29, 2025 at 5:08 PM Thomas Richard
> <thomas.richard@bootlin.com> wrote:
>>
>> Extern is the default specifier for a function, no need to define it.
> 
> Suggested-by ?
Oh yes, sorry about that. And also for patch 11/12.

Regards,

Thomas