1. Patchew
  2. linux
  3. View series

[PATCH] drm/panel: simple: Update timings for AUO G101EVN010

Kevin Baker posted 1 patch 7 months, 3 weeks ago
There is a newer version of this series
drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
[PATCH] drm/panel: simple: Update timings for AUO G101EVN010
Posted by Kevin Baker 7 months, 3 weeks ago 
Switch to panel timings based on datasheet for the AUO G101EVN01.0
LVDS panel. Default timings were tested on the panel.

Previous mode-based timings resulted in horizontal display shift.

Signed-off-by: Kevin Baker <kevinb@ventureresearch.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index fb8a57afe687..1a3d7ccb328a 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -979,27 +979,28 @@ static const struct panel_desc auo_g070vvn01 = {
 	},
 };
 
-static const struct drm_display_mode auo_g101evn010_mode = {
-	.clock = 68930,
-	.hdisplay = 1280,
-	.hsync_start = 1280 + 82,
-	.hsync_end = 1280 + 82 + 2,
-	.htotal = 1280 + 82 + 2 + 84,
-	.vdisplay = 800,
-	.vsync_start = 800 + 8,
-	.vsync_end = 800 + 8 + 2,
-	.vtotal = 800 + 8 + 2 + 6,
+static const struct display_timing auo_g101evn010_timing = {
+	.pixelclock = { 64000000, 68930000, 85000000 },
+	.hactive = { 1280, 1280, 1280 },
+	.hfront_porch = { 8, 64, 256 },
+	.hback_porch = { 8, 64, 256 },
+	.hsync_len = { 40, 168, 767 },
+	.vactive = { 800, 800, 800 },
+	.vfront_porch = { 4, 8, 100 },
+	.vback_porch = { 4, 8, 100 },
+	.vsync_len = { 8, 16, 223 },
 };
 
 static const struct panel_desc auo_g101evn010 = {
-	.modes = &auo_g101evn010_mode,
-	.num_modes = 1,
+	.timings = &auo_g101evn010_timing,
+	.num_timings = 1,
 	.bpc = 6,
 	.size = {
 		.width = 216,
 		.height = 135,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
-- 
2.39.5
Re: [PATCH] drm/panel: simple: Update timings for AUO G101EVN010
Posted by Neil Armstrong 7 months, 2 weeks ago 
On 28/04/2025 23:07, Kevin Baker wrote:
> Switch to panel timings based on datasheet for the AUO G101EVN01.0
> LVDS panel. Default timings were tested on the panel.
> 
> Previous mode-based timings resulted in horizontal display shift.

Can you add a Fixes tag ?

Thanks,
Neil

> 
> Signed-off-by: Kevin Baker <kevinb@ventureresearch.com>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++------------
>   1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index fb8a57afe687..1a3d7ccb328a 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -979,27 +979,28 @@ static const struct panel_desc auo_g070vvn01 = {
>   	},
>   };
>   
> -static const struct drm_display_mode auo_g101evn010_mode = {
> -	.clock = 68930,
> -	.hdisplay = 1280,
> -	.hsync_start = 1280 + 82,
> -	.hsync_end = 1280 + 82 + 2,
> -	.htotal = 1280 + 82 + 2 + 84,
> -	.vdisplay = 800,
> -	.vsync_start = 800 + 8,
> -	.vsync_end = 800 + 8 + 2,
> -	.vtotal = 800 + 8 + 2 + 6,
> +static const struct display_timing auo_g101evn010_timing = {
> +	.pixelclock = { 64000000, 68930000, 85000000 },
> +	.hactive = { 1280, 1280, 1280 },
> +	.hfront_porch = { 8, 64, 256 },
> +	.hback_porch = { 8, 64, 256 },
> +	.hsync_len = { 40, 168, 767 },
> +	.vactive = { 800, 800, 800 },
> +	.vfront_porch = { 4, 8, 100 },
> +	.vback_porch = { 4, 8, 100 },
> +	.vsync_len = { 8, 16, 223 },
>   };
>   
>   static const struct panel_desc auo_g101evn010 = {
> -	.modes = &auo_g101evn010_mode,
> -	.num_modes = 1,
> +	.timings = &auo_g101evn010_timing,
> +	.num_timings = 1,
>   	.bpc = 6,
>   	.size = {
>   		.width = 216,
>   		.height = 135,
>   	},
>   	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
>   	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>   };
>
[PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
Posted by Kevin Baker 7 months, 2 weeks ago 
Switch to panel timings based on datasheet for the AUO G101EVN01.0
LVDS panel. Default timings were tested on the panel.

Previous mode-based timings resulted in horizontal display shift.

Signed-off-by: Kevin Baker <kevinb@ventureresearch.com>
Fixes: 4fb86404a977 ("drm/panel: simple: Add AUO G101EVN010 panel support")
---
 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index df718c4a86cb..c79dc8581054 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1026,27 +1026,28 @@ static const struct panel_desc auo_g070vvn01 = {
 	},
 };
 
-static const struct drm_display_mode auo_g101evn010_mode = {
-	.clock = 68930,
-	.hdisplay = 1280,
-	.hsync_start = 1280 + 82,
-	.hsync_end = 1280 + 82 + 2,
-	.htotal = 1280 + 82 + 2 + 84,
-	.vdisplay = 800,
-	.vsync_start = 800 + 8,
-	.vsync_end = 800 + 8 + 2,
-	.vtotal = 800 + 8 + 2 + 6,
+static const struct display_timing auo_g101evn010_timing = {
+	.pixelclock = { 64000000, 68930000, 85000000 },
+	.hactive = { 1280, 1280, 1280 },
+	.hfront_porch = { 8, 64, 256 },
+	.hback_porch = { 8, 64, 256 },
+	.hsync_len = { 40, 168, 767 },
+	.vactive = { 800, 800, 800 },
+	.vfront_porch = { 4, 8, 100 },
+	.vback_porch = { 4, 8, 100 },
+	.vsync_len = { 8, 16, 223 },
 };
 
 static const struct panel_desc auo_g101evn010 = {
-	.modes = &auo_g101evn010_mode,
-	.num_modes = 1,
+	.timings = &auo_g101evn010_timing,
+	.num_timings = 1,
 	.bpc = 6,
 	.size = {
 		.width = 216,
 		.height = 135,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
-- 
2.39.5
Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
Posted by Neil Armstrong 7 months, 2 weeks ago 
Hi,

On Mon, 05 May 2025 12:02:56 -0500, Kevin Baker wrote:
> Switch to panel timings based on datasheet for the AUO G101EVN01.0
> LVDS panel. Default timings were tested on the panel.
> 
> Previous mode-based timings resulted in horizontal display shift.
> 
> 

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)

[1/1] drm/panel: simple: Update timings for AUO G101EVN010
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/7c6fa1797a725732981f2d77711c867166737719

-- 
Neil
Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
Posted by Dmitry Baryshkov 7 months, 2 weeks ago 
On Mon, 05 May 2025 12:02:56 -0500, Kevin Baker wrote:
> Switch to panel timings based on datasheet for the AUO G101EVN01.0
> LVDS panel. Default timings were tested on the panel.
> 
> Previous mode-based timings resulted in horizontal display shift.
> 
> 

Applied to drm-misc-next, thanks!

[1/1] drm/panel: simple: Update timings for AUO G101EVN010
      commit: d5d283d45c85e774b64100137f34e7d55bfbe45e

Best regards,
-- 
With best wishes
Dmitry
Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
Posted by Neil Armstrong 7 months, 2 weeks ago 
On 06/05/2025 13:59, Dmitry Baryshkov wrote:
> On Mon, 05 May 2025 12:02:56 -0500, Kevin Baker wrote:
>> Switch to panel timings based on datasheet for the AUO G101EVN01.0
>> LVDS panel. Default timings were tested on the panel.
>>
>> Previous mode-based timings resulted in horizontal display shift.
>>
>>
> 
> Applied to drm-misc-next, thanks!

Hmm, I applied to -fixes how it should be

> 
> [1/1] drm/panel: simple: Update timings for AUO G101EVN010
>        commit: d5d283d45c85e774b64100137f34e7d55bfbe45e
> 
> Best regards,
Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
Posted by Neil Armstrong 7 months, 2 weeks ago 
On 05/05/2025 19:02, Kevin Baker wrote:
> Switch to panel timings based on datasheet for the AUO G101EVN01.0
> LVDS panel. Default timings were tested on the panel.
> 
> Previous mode-based timings resulted in horizontal display shift.
> 
> Signed-off-by: Kevin Baker <kevinb@ventureresearch.com>
> Fixes: 4fb86404a977 ("drm/panel: simple: Add AUO G101EVN010 panel support")
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++------------
>   1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index df718c4a86cb..c79dc8581054 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1026,27 +1026,28 @@ static const struct panel_desc auo_g070vvn01 = {
>   	},
>   };
>   
> -static const struct drm_display_mode auo_g101evn010_mode = {
> -	.clock = 68930,
> -	.hdisplay = 1280,
> -	.hsync_start = 1280 + 82,
> -	.hsync_end = 1280 + 82 + 2,
> -	.htotal = 1280 + 82 + 2 + 84,
> -	.vdisplay = 800,
> -	.vsync_start = 800 + 8,
> -	.vsync_end = 800 + 8 + 2,
> -	.vtotal = 800 + 8 + 2 + 6,
> +static const struct display_timing auo_g101evn010_timing = {
> +	.pixelclock = { 64000000, 68930000, 85000000 },
> +	.hactive = { 1280, 1280, 1280 },
> +	.hfront_porch = { 8, 64, 256 },
> +	.hback_porch = { 8, 64, 256 },
> +	.hsync_len = { 40, 168, 767 },
> +	.vactive = { 800, 800, 800 },
> +	.vfront_porch = { 4, 8, 100 },
> +	.vback_porch = { 4, 8, 100 },
> +	.vsync_len = { 8, 16, 223 },
>   };
>   
>   static const struct panel_desc auo_g101evn010 = {
> -	.modes = &auo_g101evn010_mode,
> -	.num_modes = 1,
> +	.timings = &auo_g101evn010_timing,
> +	.num_timings = 1,
>   	.bpc = 6,
>   	.size = {
>   		.width = 216,
>   		.height = 135,
>   	},
>   	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
>   	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>   };
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.