drm/st7571-i2c: select CONFIG_DRM_CLIENT_SELECTION

[PATCH] drm/st7571-i2c: select CONFIG_DRM_CLIENT_SELECTION

Posted by Arnd Bergmann 7 months, 3 weeks ago

From: Arnd Bergmann <arnd@arndb.de>

The newly added driver calls drm_client_setup(), but that is not
always built in:

x86_64-linux-ld: vmlinux.o: in function `st7571_probe':
st7571-i2c.c:(.text+0x7b7119): undefined reference to `drm_client_setup'

Select the appropriate Kconfig symbol.

Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/tiny/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig
index 1dfe6291d9c0..654cd6f25faa 100644
--- a/drivers/gpu/drm/tiny/Kconfig
+++ b/drivers/gpu/drm/tiny/Kconfig
@@ -215,6 +215,7 @@ config TINYDRM_ST7586
 config DRM_ST7571_I2C
 	tristate "DRM support for Sitronix ST7571 display panels (I2C)"
 	depends on DRM && I2C && MMU
+	select DRM_CLIENT_SELECTION
 	select DRM_GEM_SHMEM_HELPER
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
-- 
2.39.5

Re: [PATCH] drm/st7571-i2c: select CONFIG_DRM_CLIENT_SELECTION

Posted by Javier Martinez Canillas 7 months, 3 weeks ago

Hello Arnd,

Arnd Bergmann <arnd@kernel.org> writes:

> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added driver calls drm_client_setup(), but that is not
> always built in:
>
> x86_64-linux-ld: vmlinux.o: in function `st7571_probe':
> st7571-i2c.c:(.text+0x7b7119): undefined reference to `drm_client_setup'
>
> Select the appropriate Kconfig symbol.
>
> Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Re: [PATCH] drm/st7571-i2c: select CONFIG_DRM_CLIENT_SELECTION

Posted by Marcus Folkesson 7 months, 3 weeks ago

On Mon, Apr 28, 2025 at 05:07:45PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver calls drm_client_setup(), but that is not
> always built in:
> 
> x86_64-linux-ld: vmlinux.o: in function `st7571_probe':
> st7571-i2c.c:(.text+0x7b7119): undefined reference to `drm_client_setup'
> 
> Select the appropriate Kconfig symbol.
> 
> Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Marcus Folkesson <marcus.folkesson@gmail.com>