[v1] Bug fixes from XDP patch series

[PATCH net 0/4] Bug fixes from XDP patch series

Meghana Malladi posted 4 patches 9 months, 2 weeks ago

Diff against v2
Download series mbox

There is a newer version of this series

drivers/net/ethernet/ti/icssg/icssg_common.c | 22 ++++++++++++++++++--
drivers/net/ethernet/ti/icssg/icssg_prueth.c | 16 ++++++++------
drivers/net/ethernet/ti/icssg/icssg_prueth.h |  1 +
3 files changed, 31 insertions(+), 8 deletions(-)

Expand all Fold all

[PATCH net 0/4] Bug fixes from XDP patch series

Posted by Meghana Malladi 9 months, 2 weeks ago

This patch series fixes the bugs introduced while adding
xdp support in the icssg driver, and were reproduced while
running xdp-trafficgen to generate xdp traffic on icssg interfaces. 

Meghana Malladi (4):
  net: ti: icssg-prueth: Set XDP feature flags for ndev
  net: ti: icssg-prueth: Report BQL before sending XDP packets
  net: ti: icssg-prueth: Fix race condition for traffic from different
    network sockets
  net: ti: icssg-prueth: Fix kernel panic during concurrent Tx queue
    access

 drivers/net/ethernet/ti/icssg/icssg_common.c | 22 ++++++++++++++++++--
 drivers/net/ethernet/ti/icssg/icssg_prueth.c | 16 ++++++++------
 drivers/net/ethernet/ti/icssg/icssg_prueth.h |  1 +
 3 files changed, 31 insertions(+), 8 deletions(-)


base-commit: cc17b4b9c332cc654b248619c1d8ca40d80d1155
-- 
2.43.0

Re: [PATCH net 0/4] Bug fixes from XDP patch series

Posted by Jesper Dangaard Brouer 9 months, 1 week ago


On 28/04/2025 14.04, Meghana Malladi wrote:
> This patch series fixes the bugs introduced while adding
> xdp support in the icssg driver, and were reproduced while
> running xdp-trafficgen to generate xdp traffic on icssg interfaces.
> 

This patchset clearly hurts performance by introducing a lot of locking.

Can you please report what the performance regressions this is introducing?


> Meghana Malladi (4):
>    net: ti: icssg-prueth: Set XDP feature flags for ndev
>    net: ti: icssg-prueth: Report BQL before sending XDP packets
>    net: ti: icssg-prueth: Fix race condition for traffic from different
>      network sockets
>    net: ti: icssg-prueth: Fix kernel panic during concurrent Tx queue
>      access
> 
>   drivers/net/ethernet/ti/icssg/icssg_common.c | 22 ++++++++++++++++++--
>   drivers/net/ethernet/ti/icssg/icssg_prueth.c | 16 ++++++++------
>   drivers/net/ethernet/ti/icssg/icssg_prueth.h |  1 +
>   3 files changed, 31 insertions(+), 8 deletions(-)
> 
> 
> base-commit: cc17b4b9c332cc654b248619c1d8ca40d80d1155