[PATCH v6 net-next 09/14] net: enetc: change enetc_set_rss() to void type

Wei Fang posted 14 patches 9 months, 2 weeks ago
Only 13 patches received!
There is a newer version of this series
[PATCH v6 net-next 09/14] net: enetc: change enetc_set_rss() to void type
Posted by Wei Fang 9 months, 2 weeks ago
Actually enetc_set_rss() does not need a return value, so change its
type to void.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v5 changes:
New patch, suggested by Vladimir
v6: no changes
---
 drivers/net/ethernet/freescale/enetc/enetc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index 08762772c045..daea85cbf043 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -3242,7 +3242,7 @@ struct net_device_stats *enetc_get_stats(struct net_device *ndev)
 }
 EXPORT_SYMBOL_GPL(enetc_get_stats);
 
-static int enetc_set_rss(struct net_device *ndev, int en)
+static void enetc_set_rss(struct net_device *ndev, int en)
 {
 	struct enetc_ndev_priv *priv = netdev_priv(ndev);
 	struct enetc_hw *hw = &priv->si->hw;
@@ -3254,8 +3254,6 @@ static int enetc_set_rss(struct net_device *ndev, int en)
 	reg &= ~ENETC_SIMR_RSSE;
 	reg |= (en) ? ENETC_SIMR_RSSE : 0;
 	enetc_wr(hw, ENETC_SIMR, reg);
-
-	return 0;
 }
 
 static void enetc_enable_rxvlan(struct net_device *ndev, bool en)
-- 
2.34.1
Re: [PATCH v6 net-next 09/14] net: enetc: change enetc_set_rss() to void type
Posted by Vladimir Oltean 9 months, 2 weeks ago
On Mon, Apr 28, 2025 at 06:56:52PM +0800, Wei Fang wrote:
> Actually enetc_set_rss() does not need a return value, so change its
> type to void.
> 
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>

The Acked-by: was supposed to be on patch "net: enetc: enable RSS
feature by default".
https://patchwork.kernel.org/project/imx/patch/20250311053830.1516523-10-wei.fang@nxp.com/