[v1] rtc: loongson: Add missing alarm notifications for ACPI RTC events

[PATCH] rtc: loongson: Add missing alarm notifications for ACPI RTC events

Liu Dalin posted 1 patch 9 months, 2 weeks ago

Diff against v1 v1 v2
Download mbox

There is a newer version of this series

drivers/rtc/rtc-loongson.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] rtc: loongson: Add missing alarm notifications for ACPI RTC events

Posted by Liu Dalin 9 months, 2 weeks ago

When an application sets and enables an alarm on Loongson RTC devices,
the alarm notification fails to propagate to userspace because the
ACPI event handler omits calling rtc_update_irq().

As a result, processes waiting via select() or poll() on RTC device
files fail to receive alarm notifications.

Fixes: 1b733a9ebc3d ("rtc: Add rtc driver for the Loongson family chips")
Signed-off-by: Liu Dalin <liudalin@kylinsec.com.cn>
---
 drivers/rtc/rtc-loongson.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-loongson.c b/drivers/rtc/rtc-loongson.c
index 97e5625c064c..0c573f198f63 100644
--- a/drivers/rtc/rtc-loongson.c
+++ b/drivers/rtc/rtc-loongson.c
@@ -129,6 +129,8 @@ static u32 loongson_rtc_handler(void *id)
 {
 	struct loongson_rtc_priv *priv = (struct loongson_rtc_priv *)id;
 
+	rtc_update_irq(priv->rtcdev, 1, RTC_AF | RTC_IRQF);
+
 	spin_lock(&priv->lock);
 	/* Disable RTC alarm wakeup and interrupt */
 	writel(readl(priv->pm_base + PM1_EN_REG) & ~RTC_EN,
-- 
2.33.0