1. Patchew
  2. linux
  3. View series

[PATCH] platform/chrome: cros_ec_typec: Set Pin Assignment E in DP PORT VDO

Benson Leung posted 1 patch 7 months, 3 weeks ago
There is a newer version of this series
drivers/platform/chrome/cros_ec_typec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[PATCH] platform/chrome: cros_ec_typec: Set Pin Assignment E in DP PORT VDO
Posted by Benson Leung 7 months, 3 weeks ago 
Pin C and D are used on C-to-C cable applications including docks,
and for USB-C adapters that convert from DP over USB-C to other
video standards.

Pin Assignment E is intended to be used with adapter from USB-C to DP
plugs or receptacles.

All Chromebook USB-C DFPs support DisplayPort Alternate Mode as the DP
Source with support for all 3 pin assignments. Pin Assignment E is required
in order to support if the user attaches a Pin E C-to-DP cable.

Without this, the displayport.c alt mode driver will error out of
dp_altmode_probe with an -ENODEV, as it cannot find a compatible matching
pin assignment between the DFP_D and UFP_D.

Signed-off-by: Benson Leung <bleung@chromium.org>
---
 drivers/platform/chrome/cros_ec_typec.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index d2228720991f..7678e3d05fd3 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -22,8 +22,10 @@
 
 #define DRV_NAME "cros-ec-typec"
 
-#define DP_PORT_VDO	(DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D)) | \
-				DP_CAP_DFP_D | DP_CAP_RECEPTACLE)
+#define DP_PORT_VDO	(DP_CAP_DFP_D | DP_CAP_RECEPTACLE | \
+			 DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | \
+						BIT(DP_PIN_ASSIGN_D) | \
+						BIT(DP_PIN_ASSIGN_E)))
 
 static void cros_typec_role_switch_quirk(struct fwnode_handle *fwnode)
 {
-- 
2.49.0.850.g28803427d3-goog
Re: [PATCH] platform/chrome: cros_ec_typec: Set Pin Assignment E in DP PORT VDO
Posted by Abhishek Pandit-Subedi 7 months, 3 weeks ago 
On Fri, Apr 25, 2025 at 7:48 PM Benson Leung <bleung@chromium.org> wrote:
>
> Pin C and D are used on C-to-C cable applications including docks,
> and for USB-C adapters that convert from DP over USB-C to other
> video standards.
>
> Pin Assignment E is intended to be used with adapter from USB-C to DP
> plugs or receptacles.
>
> All Chromebook USB-C DFPs support DisplayPort Alternate Mode as the DP
> Source with support for all 3 pin assignments. Pin Assignment E is required
> in order to support if the user attaches a Pin E C-to-DP cable.
>
> Without this, the displayport.c alt mode driver will error out of
> dp_altmode_probe with an -ENODEV, as it cannot find a compatible matching
> pin assignment between the DFP_D and UFP_D.
>
> Signed-off-by: Benson Leung <bleung@chromium.org>
> ---
>  drivers/platform/chrome/cros_ec_typec.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index d2228720991f..7678e3d05fd3 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -22,8 +22,10 @@
>
>  #define DRV_NAME "cros-ec-typec"
>
> -#define DP_PORT_VDO    (DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D)) | \
> -                               DP_CAP_DFP_D | DP_CAP_RECEPTACLE)
> +#define DP_PORT_VDO    (DP_CAP_DFP_D | DP_CAP_RECEPTACLE | \
> +                        DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | \
> +                                               BIT(DP_PIN_ASSIGN_D) | \
> +                                               BIT(DP_PIN_ASSIGN_E)))
>
>  static void cros_typec_role_switch_quirk(struct fwnode_handle *fwnode)
>  {
> --
> 2.49.0.850.g28803427d3-goog
>

Please add a Fixes: dbb3fc0ffa95788e00e50ffc6501eb0085d48231

Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Re: [PATCH] platform/chrome: cros_ec_typec: Set Pin Assignment E in DP PORT VDO
Posted by Benson Leung 7 months, 3 weeks ago 
Hi Abhishek,

On Mon, Apr 28, 2025 at 09:24:08AM -0700, Abhishek Pandit-Subedi wrote:
> On Fri, Apr 25, 2025 at 7:48 PM Benson Leung <bleung@chromium.org> wrote:
> >
> > Pin C and D are used on C-to-C cable applications including docks,
> > and for USB-C adapters that convert from DP over USB-C to other
> > video standards.
> >
> > Pin Assignment E is intended to be used with adapter from USB-C to DP
> > plugs or receptacles.
> >
> > All Chromebook USB-C DFPs support DisplayPort Alternate Mode as the DP
> > Source with support for all 3 pin assignments. Pin Assignment E is required
> > in order to support if the user attaches a Pin E C-to-DP cable.
> >
> > Without this, the displayport.c alt mode driver will error out of
> > dp_altmode_probe with an -ENODEV, as it cannot find a compatible matching
> > pin assignment between the DFP_D and UFP_D.
> >
> > Signed-off-by: Benson Leung <bleung@chromium.org>
> > ---
> >  drivers/platform/chrome/cros_ec_typec.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> > index d2228720991f..7678e3d05fd3 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -22,8 +22,10 @@
> >
> >  #define DRV_NAME "cros-ec-typec"
> >
> > -#define DP_PORT_VDO    (DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D)) | \
> > -                               DP_CAP_DFP_D | DP_CAP_RECEPTACLE)
> > +#define DP_PORT_VDO    (DP_CAP_DFP_D | DP_CAP_RECEPTACLE | \
> > +                        DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | \
> > +                                               BIT(DP_PIN_ASSIGN_D) | \
> > +                                               BIT(DP_PIN_ASSIGN_E)))
> >
> >  static void cros_typec_role_switch_quirk(struct fwnode_handle *fwnode)
> >  {
> > --
> > 2.49.0.850.g28803427d3-goog
> >
> 
> Please add a Fixes: dbb3fc0ffa95788e00e50ffc6501eb0085d48231

Done, Thanks!
Re: [PATCH] platform/chrome: cros_ec_typec: Set Pin Assignment E in DP PORT VDO
Posted by Jameson Thies 7 months, 3 weeks ago 
On Fri, Apr 25, 2025 at 7:48 PM Benson Leung <bleung@chromium.org> wrote:
>
> Pin C and D are used on C-to-C cable applications including docks,
> and for USB-C adapters that convert from DP over USB-C to other
> video standards.
>
> Pin Assignment E is intended to be used with adapter from USB-C to DP
> plugs or receptacles.
>
> All Chromebook USB-C DFPs support DisplayPort Alternate Mode as the DP
> Source with support for all 3 pin assignments. Pin Assignment E is required
> in order to support if the user attaches a Pin E C-to-DP cable.
>
> Without this, the displayport.c alt mode driver will error out of
> dp_altmode_probe with an -ENODEV, as it cannot find a compatible matching
> pin assignment between the DFP_D and UFP_D.
>
> Signed-off-by: Benson Leung <bleung@chromium.org>

Reviewed-by: Jameson Thies <jthies@google.com>
[PATCH v2] platform/chrome: cros_ec_typec: Set Pin Assignment E in DP PORT VDO
Posted by Benson Leung 7 months, 3 weeks ago 
Pin C and D are used on C-to-C cable applications including docks,
and for USB-C adapters that convert from DP over USB-C to other
video standards.

Pin Assignment E is intended to be used with adapter from USB-C to DP
plugs or receptacles.

All Chromebook USB-C DFPs support DisplayPort Alternate Mode as the DP
Source with support for all 3 pin assignments. Pin Assignment E is required
in order to support if the user attaches a Pin E C-to-DP cable.

Without this, the displayport.c alt mode driver will error out of
dp_altmode_probe with an -ENODEV, as it cannot find a compatible matching
pin assignment between the DFP_D and UFP_D.

Fixes: dbb3fc0ffa95 ("platform/chrome: cros_ec_typec: Displayport support")

Signed-off-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Jameson Thies <jthies@google.com>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
---

Notes:
    v2 - Add Fixes to commit message.

 drivers/platform/chrome/cros_ec_typec.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index d2228720991f..7678e3d05fd3 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -22,8 +22,10 @@
 
 #define DRV_NAME "cros-ec-typec"
 
-#define DP_PORT_VDO	(DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D)) | \
-				DP_CAP_DFP_D | DP_CAP_RECEPTACLE)
+#define DP_PORT_VDO	(DP_CAP_DFP_D | DP_CAP_RECEPTACLE | \
+			 DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | \
+						BIT(DP_PIN_ASSIGN_D) | \
+						BIT(DP_PIN_ASSIGN_E)))
 
 static void cros_typec_role_switch_quirk(struct fwnode_handle *fwnode)
 {
-- 
2.49.0.901.g37484f566f-goog
Re: [PATCH v2] platform/chrome: cros_ec_typec: Set Pin Assignment E in DP PORT VDO
Posted by Tzung-Bi Shih 7 months, 3 weeks ago 
On Mon, Apr 28, 2025 at 05:48:28PM +0000, Benson Leung wrote:
> Pin C and D are used on C-to-C cable applications including docks,
> and for USB-C adapters that convert from DP over USB-C to other
> video standards.
> 
> Pin Assignment E is intended to be used with adapter from USB-C to DP
> plugs or receptacles.
> 
> [...]

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/1] platform/chrome: cros_ec_typec: Set Pin Assignment E in DP PORT VDO
      commit: a9635ef0ca12e7914f42bfa7ca6a019f606c2817

Thanks!

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.