[PATCH v3 0/4] AsoC: Phase out hybrid PCI devres

Philipp Stanner posted 4 patches 7 months, 4 weeks ago
sound/soc/intel/atom/sst/sst_pci.c | 59 ++++++++++++------------------
sound/soc/intel/avs/core.c         |  8 +---
sound/soc/sof/sof-pci-dev.c        | 16 ++------
3 files changed, 29 insertions(+), 54 deletions(-)
[PATCH v3 0/4] AsoC: Phase out hybrid PCI devres
Posted by Philipp Stanner 7 months, 4 weeks ago
Changes in v3:
  - Remove two forgotten calls to pci_release_regions(). (Amadeusz)
  - Adjust commit titles to common format. (Amadeusz, Cezary)
  - Apply RB by Czeray (not everywhere, two patches changed, see point
    1 above)

Changes in v2:
  - sof: simplify return. (Andy)
  - intel/atom: simplify return. (Andy)
  - Send a separate series for AsoC. (Andy)
  - intel/atom: Add another patch that switches EINVAL to ENOMEM. (Andy)

Hi,

a year ago we spent quite some work trying to get PCI into better shape.
Some pci_ functions can be sometimes managed with devres, which is
obviously bad. We want to provide an obvious API, where pci_ functions
are never, and pcim_ functions are always managed.

Thus, everyone enabling his device with pcim_enable_device() must be
ported to pcim_ functions. Porting all users will later enable us to
significantly simplify parts of the PCI subsystem. See here [1] for
details.

This patch series does that for sound.

Feel free to squash the commits as you see fit.

P.

[1] https://elixir.bootlin.com/linux/v6.14-rc4/source/drivers/pci/devres.c#L18

Philipp Stanner (4):
  ASoC: sof: Use pure devres PCI
  ASoC: intel: avs: Use pure devres PCI
  AsoC: intel: atom: Use pure devres PCI
  AsoC: intel: atom: Return -ENOMEM if pcim_iomap() fails

 sound/soc/intel/atom/sst/sst_pci.c | 59 ++++++++++++------------------
 sound/soc/intel/avs/core.c         |  8 +---
 sound/soc/sof/sof-pci-dev.c        | 16 ++------
 3 files changed, 29 insertions(+), 54 deletions(-)

-- 
2.48.1
Re: [PATCH v3 0/4] AsoC: Phase out hybrid PCI devres
Posted by Mark Brown 7 months, 2 weeks ago
On Fri, 25 Apr 2025 10:17:39 +0200, Philipp Stanner wrote:
> Changes in v3:
>   - Remove two forgotten calls to pci_release_regions(). (Amadeusz)
>   - Adjust commit titles to common format. (Amadeusz, Cezary)
>   - Apply RB by Czeray (not everywhere, two patches changed, see point
>     1 above)
> 
> Changes in v2:
>   - sof: simplify return. (Andy)
>   - intel/atom: simplify return. (Andy)
>   - Send a separate series for AsoC. (Andy)
>   - intel/atom: Add another patch that switches EINVAL to ENOMEM. (Andy)
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: sof: Use pure devres PCI
      commit: 45054bb10fd8a545a1feeaab16af1a87ab7fcce3
[2/4] ASoC: intel: avs: Use pure devres PCI
      commit: 58fa9c629e29ae921d055c2b7a1e372ae991fb79
[3/4] AsoC: intel: atom: Use pure devres PCI
      commit: 938cabc603dc9b040fbfbf7c37b2b48dff8946d4
[4/4] AsoC: intel: atom: Return -ENOMEM if pcim_iomap() fails
      commit: 14a3fd030c033453d436233f4c422b4903786ed3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark