[PATCH 4/5] cdx: controller: Do not open-code module_platform_driver()

Krzysztof Kozlowski posted 5 patches 9 months, 2 weeks ago
There is a newer version of this series
[PATCH 4/5] cdx: controller: Do not open-code module_platform_driver()
Posted by Krzysztof Kozlowski 9 months, 2 weeks ago
Replace standard platform_driver_register() boilerplate with
module_platform_driver() to make code smaller.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/cdx/controller/cdx_controller.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c
index fce90926d3378ae60166426cbf8e4a4fe014af86..fca83141e3e66e68e6916077833db2b7d816395f 100644
--- a/drivers/cdx/controller/cdx_controller.c
+++ b/drivers/cdx/controller/cdx_controller.c
@@ -243,31 +243,13 @@ MODULE_DEVICE_TABLE(of, cdx_match_table);
 static struct platform_driver cdx_pdriver = {
 	.driver = {
 		   .name = "cdx-controller",
-		   .pm = NULL,
 		   .of_match_table = cdx_match_table,
 		   },
 	.probe = xlnx_cdx_probe,
 	.remove = xlnx_cdx_remove,
 };
 
-static int __init cdx_controller_init(void)
-{
-	int ret;
-
-	ret = platform_driver_register(&cdx_pdriver);
-	if (ret)
-		pr_err("platform_driver_register() failed: %d\n", ret);
-
-	return ret;
-}
-
-static void __exit cdx_controller_exit(void)
-{
-	platform_driver_unregister(&cdx_pdriver);
-}
-
-module_init(cdx_controller_init);
-module_exit(cdx_controller_exit);
+module_platform_driver(cdx_pdriver);
 
 MODULE_AUTHOR("AMD Inc.");
 MODULE_DESCRIPTION("CDX controller for AMD devices");

-- 
2.45.2
Re: [PATCH 4/5] cdx: controller: Do not open-code module_platform_driver()
Posted by Krzysztof Kozlowski 9 months, 2 weeks ago
On 25/04/2025 08:54, Krzysztof Kozlowski wrote:
> Replace standard platform_driver_register() boilerplate with
> module_platform_driver() to make code smaller.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/cdx/controller/cdx_controller.c | 20 +-------------------
>  1 file changed, 1 insertion(+), 19 deletions(-)
> 
> diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c
> index fce90926d3378ae60166426cbf8e4a4fe014af86..fca83141e3e66e68e6916077833db2b7d816395f 100644
> --- a/drivers/cdx/controller/cdx_controller.c
> +++ b/drivers/cdx/controller/cdx_controller.c
> @@ -243,31 +243,13 @@ MODULE_DEVICE_TABLE(of, cdx_match_table);
>  static struct platform_driver cdx_pdriver = {
>  	.driver = {
>  		   .name = "cdx-controller",
> -		   .pm = NULL,


Too big chunk in `git add -p`. This should be separate patch.

I will wait a day for more reviews and then send v2.


Best regards,
Krzysztof