1. Patchew
  2. linux
  3. [PATCH iwl-next v2 00/14] Introduce iXD driver
  4. View patch

[PATCH iwl-next v2 01/14] virtchnl: create 'include/linux/intel' and move necessary header files

Larysa Zaremba posted 14 patches 9 months, 2 weeks ago
There is a newer version of this series
[PATCH iwl-next v2 01/14] virtchnl: create 'include/linux/intel' and move necessary header files
Posted by Larysa Zaremba 9 months, 2 weeks ago 
From: Victor Raj <victor.raj@intel.com>

Move intel specific header files into new folder
include/linux/intel.

Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
Signed-off-by: Victor Raj <victor.raj@intel.com>
Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
---
 MAINTAINERS                                                 | 6 +++---
 drivers/infiniband/hw/irdma/i40iw_if.c                      | 2 +-
 drivers/infiniband/hw/irdma/main.h                          | 2 +-
 drivers/infiniband/hw/irdma/osdep.h                         | 2 +-
 drivers/net/ethernet/intel/i40e/i40e.h                      | 4 ++--
 drivers/net/ethernet/intel/i40e/i40e_client.c               | 2 +-
 drivers/net/ethernet/intel/i40e/i40e_common.c               | 2 +-
 drivers/net/ethernet/intel/i40e/i40e_prototype.h            | 2 +-
 drivers/net/ethernet/intel/i40e/i40e_txrx.c                 | 2 +-
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h          | 2 +-
 drivers/net/ethernet/intel/iavf/iavf.h                      | 2 +-
 drivers/net/ethernet/intel/iavf/iavf_common.c               | 2 +-
 drivers/net/ethernet/intel/iavf/iavf_main.c                 | 2 +-
 drivers/net/ethernet/intel/iavf/iavf_prototype.h            | 2 +-
 drivers/net/ethernet/intel/iavf/iavf_txrx.c                 | 2 +-
 drivers/net/ethernet/intel/iavf/iavf_types.h                | 4 +---
 drivers/net/ethernet/intel/iavf/iavf_virtchnl.c             | 2 +-
 drivers/net/ethernet/intel/ice/ice.h                        | 2 +-
 drivers/net/ethernet/intel/ice/ice_common.h                 | 2 +-
 drivers/net/ethernet/intel/ice/ice_idc_int.h                | 2 +-
 drivers/net/ethernet/intel/ice/ice_txrx_lib.c               | 2 +-
 drivers/net/ethernet/intel/ice/ice_vf_lib.h                 | 2 +-
 drivers/net/ethernet/intel/ice/ice_virtchnl.h               | 2 +-
 drivers/net/ethernet/intel/idpf/idpf.h                      | 2 +-
 drivers/net/ethernet/intel/idpf/idpf_txrx.h                 | 2 +-
 drivers/net/ethernet/intel/libie/rx.c                       | 2 +-
 include/linux/{net => }/intel/i40e_client.h                 | 0
 include/linux/{net => }/intel/iidc.h                        | 0
 include/linux/{net => }/intel/libie/rx.h                    | 0
 include/linux/{avf => intel}/virtchnl.h                     | 0
 .../ethernet/intel/idpf => include/linux/intel}/virtchnl2.h | 0
 .../intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h | 0
 32 files changed, 29 insertions(+), 31 deletions(-)
 rename include/linux/{net => }/intel/i40e_client.h (100%)
 rename include/linux/{net => }/intel/iidc.h (100%)
 rename include/linux/{net => }/intel/libie/rx.h (100%)
 rename include/linux/{avf => intel}/virtchnl.h (100%)
 rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2.h (100%)
 rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index 657a67f9031e..2e2a57dfea8f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11884,8 +11884,8 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
 F:	Documentation/networking/device_drivers/ethernet/intel/
 F:	drivers/net/ethernet/intel/
 F:	drivers/net/ethernet/intel/*/
-F:	include/linux/avf/virtchnl.h
-F:	include/linux/net/intel/iidc.h
+F:	include/linux/intel/iidc.h
+F:	include/linux/intel/virtchnl.h
 
 INTEL ETHERNET PROTOCOL DRIVER FOR RDMA
 M:	Mustafa Ismail <mustafa.ismail@intel.com>
@@ -13534,7 +13534,7 @@ L:	netdev@vger.kernel.org
 S:	Maintained
 T:	git https://github.com/alobakin/linux.git
 F:	drivers/net/ethernet/intel/libie/
-F:	include/linux/net/intel/libie/
+F:	include/linux/intel/libie/
 K:	libie
 
 LIBNVDIMM BTT: BLOCK TRANSLATION TABLE
diff --git a/drivers/infiniband/hw/irdma/i40iw_if.c b/drivers/infiniband/hw/irdma/i40iw_if.c
index cc50a7070371..cfd71fe5bd79 100644
--- a/drivers/infiniband/hw/irdma/i40iw_if.c
+++ b/drivers/infiniband/hw/irdma/i40iw_if.c
@@ -2,7 +2,7 @@
 /* Copyright (c) 2015 - 2021 Intel Corporation */
 #include "main.h"
 #include "i40iw_hw.h"
-#include <linux/net/intel/i40e_client.h>
+#include <linux/intel/i40e_client.h>
 
 static struct i40e_client i40iw_client;
 
diff --git a/drivers/infiniband/hw/irdma/main.h b/drivers/infiniband/hw/irdma/main.h
index bb0b6494ccb2..d6e446dec2be 100644
--- a/drivers/infiniband/hw/irdma/main.h
+++ b/drivers/infiniband/hw/irdma/main.h
@@ -29,7 +29,7 @@
 #include <linux/io-64-nonatomic-lo-hi.h>
 #endif
 #include <linux/auxiliary_bus.h>
-#include <linux/net/intel/iidc.h>
+#include <linux/intel/iidc.h>
 #include <rdma/ib_smi.h>
 #include <rdma/ib_verbs.h>
 #include <rdma/ib_pack.h>
diff --git a/drivers/infiniband/hw/irdma/osdep.h b/drivers/infiniband/hw/irdma/osdep.h
index 4b4f78288d12..abb10e35d33b 100644
--- a/drivers/infiniband/hw/irdma/osdep.h
+++ b/drivers/infiniband/hw/irdma/osdep.h
@@ -5,7 +5,7 @@
 
 #include <linux/pci.h>
 #include <linux/bitfield.h>
-#include <linux/net/intel/iidc.h>
+#include <linux/intel/iidc.h>
 #include <rdma/ib_verbs.h>
 
 #define STATS_TIMER_DELAY	60000
diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h
index c67963bfe14e..287ddfec5024 100644
--- a/drivers/net/ethernet/intel/i40e/i40e.h
+++ b/drivers/net/ethernet/intel/i40e/i40e.h
@@ -8,8 +8,8 @@
 #include <linux/pci.h>
 #include <linux/ptp_clock_kernel.h>
 #include <linux/types.h>
-#include <linux/avf/virtchnl.h>
-#include <linux/net/intel/i40e_client.h>
+#include <linux/intel/virtchnl.h>
+#include <linux/intel/i40e_client.h>
 #include <net/devlink.h>
 #include <net/pkt_cls.h>
 #include <net/udp_tunnel.h>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c
index 59263551c383..a6a6d12ec250 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_client.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c
@@ -3,7 +3,7 @@
 
 #include <linux/list.h>
 #include <linux/errno.h>
-#include <linux/net/intel/i40e_client.h>
+#include <linux/intel/i40e_client.h>
 
 #include "i40e.h"
 
diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c
index b11c35e307ca..cd82d4069861 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Copyright(c) 2013 - 2021 Intel Corporation. */
 
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include <linux/bitfield.h>
 #include <linux/delay.h>
 #include <linux/etherdevice.h>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_prototype.h b/drivers/net/ethernet/intel/i40e/i40e_prototype.h
index 099bb8ab7d70..eae76404289a 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_prototype.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_prototype.h
@@ -5,7 +5,7 @@
 #define _I40E_PROTOTYPE_H_
 
 #include <linux/ethtool.h>
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include "i40e_debug.h"
 #include "i40e_type.h"
 
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index c006f716a3bd..30df45a146da 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -2,7 +2,7 @@
 /* Copyright(c) 2013 - 2018 Intel Corporation. */
 
 #include <linux/bpf_trace.h>
-#include <linux/net/intel/libie/rx.h>
+#include <linux/intel/libie/rx.h>
 #include <linux/prefetch.h>
 #include <linux/sctp.h>
 #include <net/mpls.h>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h
index 5cf74f16f433..acaae2f6d00b 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h
@@ -4,7 +4,7 @@
 #ifndef _I40E_VIRTCHNL_PF_H_
 #define _I40E_VIRTCHNL_PF_H_
 
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include <linux/netdevice.h>
 #include "i40e_type.h"
 
diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h
index f7a98ff43a57..a97e8568e37e 100644
--- a/drivers/net/ethernet/intel/iavf/iavf.h
+++ b/drivers/net/ethernet/intel/iavf/iavf.h
@@ -37,7 +37,7 @@
 #include <net/net_shaper.h>
 
 #include "iavf_type.h"
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include "iavf_txrx.h"
 #include "iavf_fdir.h"
 #include "iavf_adv_rss.h"
diff --git a/drivers/net/ethernet/intel/iavf/iavf_common.c b/drivers/net/ethernet/intel/iavf/iavf_common.c
index aa751ce3425b..e9968e540110 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_common.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_common.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Copyright(c) 2013 - 2018 Intel Corporation. */
 
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include <linux/bitfield.h>
 #include "iavf_type.h"
 #include "iavf_adminq.h"
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 2c0bb41809a4..2733207812bd 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Copyright(c) 2013 - 2018 Intel Corporation. */
 
-#include <linux/net/intel/libie/rx.h>
+#include <linux/intel/libie/rx.h>
 #include <net/netdev_lock.h>
 
 #include "iavf.h"
diff --git a/drivers/net/ethernet/intel/iavf/iavf_prototype.h b/drivers/net/ethernet/intel/iavf/iavf_prototype.h
index cac9d1a35a52..945be3541e8e 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_prototype.h
+++ b/drivers/net/ethernet/intel/iavf/iavf_prototype.h
@@ -6,7 +6,7 @@
 
 #include "iavf_type.h"
 #include "iavf_alloc.h"
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 
 /* Prototypes for shared code functions that are not in
  * the standard function pointer structures.  These are
diff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
index 422312b8b54a..4c8dca868447 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
@@ -2,7 +2,7 @@
 /* Copyright(c) 2013 - 2018 Intel Corporation. */
 
 #include <linux/bitfield.h>
-#include <linux/net/intel/libie/rx.h>
+#include <linux/intel/libie/rx.h>
 #include <linux/prefetch.h>
 
 #include "iavf.h"
diff --git a/drivers/net/ethernet/intel/iavf/iavf_types.h b/drivers/net/ethernet/intel/iavf/iavf_types.h
index a095855122bf..270bc35f933d 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_types.h
+++ b/drivers/net/ethernet/intel/iavf/iavf_types.h
@@ -4,9 +4,7 @@
 #ifndef _IAVF_TYPES_H_
 #define _IAVF_TYPES_H_
 
-#include "iavf_types.h"
-
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include <linux/ptp_clock_kernel.h>
 
 /* structure used to queue PTP commands for processing */
diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
index a6f0e5990be2..c0ba1fd3b98a 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Copyright(c) 2013 - 2018 Intel Corporation. */
 
-#include <linux/net/intel/libie/rx.h>
+#include <linux/intel/libie/rx.h>
 
 #include "iavf.h"
 #include "iavf_ptp.h"
diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
index 5535c76584a1..49df44c22bdb 100644
--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h
@@ -36,7 +36,7 @@
 #include <linux/bpf.h>
 #include <linux/btf.h>
 #include <linux/auxiliary_bus.h>
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include <linux/cpu_rmap.h>
 #include <linux/dim.h>
 #include <linux/gnss.h>
diff --git a/drivers/net/ethernet/intel/ice/ice_common.h b/drivers/net/ethernet/intel/ice/ice_common.h
index 8ef25efa1b81..87fa16669f2a 100644
--- a/drivers/net/ethernet/intel/ice/ice_common.h
+++ b/drivers/net/ethernet/intel/ice/ice_common.h
@@ -11,7 +11,7 @@
 #include "ice_nvm.h"
 #include "ice_flex_pipe.h"
 #include "ice_parser.h"
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include "ice_switch.h"
 #include "ice_fdir.h"
 
diff --git a/drivers/net/ethernet/intel/ice/ice_idc_int.h b/drivers/net/ethernet/intel/ice/ice_idc_int.h
index 4b0c86757df9..3d35118dee90 100644
--- a/drivers/net/ethernet/intel/ice/ice_idc_int.h
+++ b/drivers/net/ethernet/intel/ice/ice_idc_int.h
@@ -4,7 +4,7 @@
 #ifndef _ICE_IDC_INT_H_
 #define _ICE_IDC_INT_H_
 
-#include <linux/net/intel/iidc.h>
+#include <linux/intel/iidc.h>
 
 struct ice_pf;
 
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
index 45cfaabc41cb..fb90916e7ef7 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
@@ -2,7 +2,7 @@
 /* Copyright (c) 2019, Intel Corporation. */
 
 #include <linux/filter.h>
-#include <linux/net/intel/libie/rx.h>
+#include <linux/intel/libie/rx.h>
 
 #include "ice_txrx_lib.h"
 #include "ice_eswitch.h"
diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.h b/drivers/net/ethernet/intel/ice/ice_vf_lib.h
index 482f4285fd35..5cdc98985523 100644
--- a/drivers/net/ethernet/intel/ice/ice_vf_lib.h
+++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.h
@@ -10,7 +10,7 @@
 #include <linux/mutex.h>
 #include <linux/pci.h>
 #include <net/devlink.h>
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include "ice_type.h"
 #include "ice_flow.h"
 #include "ice_virtchnl_fdir.h"
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl.h b/drivers/net/ethernet/intel/ice/ice_virtchnl.h
index 222990f229d5..ca3830617a51 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl.h
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl.h
@@ -7,7 +7,7 @@
 #include <linux/types.h>
 #include <linux/bitops.h>
 #include <linux/if_ether.h>
-#include <linux/avf/virtchnl.h>
+#include <linux/intel/virtchnl.h>
 #include "ice_vf_lib.h"
 
 /* Restrict number of MAC Addr and VLAN that non-trusted VF can programmed */
diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h
index 294f4b7032a1..a46793d34827 100644
--- a/drivers/net/ethernet/intel/idpf/idpf.h
+++ b/drivers/net/ethernet/intel/idpf/idpf.h
@@ -18,7 +18,7 @@ struct idpf_vport_max_q;
 #include <linux/ethtool_netlink.h>
 #include <net/gro.h>
 
-#include "virtchnl2.h"
+#include <linux/intel/virtchnl2.h>
 #include "idpf_txrx.h"
 #include "idpf_controlq.h"
 
diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
index c779fe71df99..d80a90421a6d 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h
+++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.h
@@ -11,7 +11,7 @@
 #include <net/netdev_queues.h>
 
 #include "idpf_lan_txrx.h"
-#include "virtchnl2_lan_desc.h"
+#include <linux/intel/virtchnl2_lan_desc.h>
 
 #define IDPF_LARGE_MAX_Q			256
 #define IDPF_MAX_Q				16
diff --git a/drivers/net/ethernet/intel/libie/rx.c b/drivers/net/ethernet/intel/libie/rx.c
index 66a9825fe11f..668785974727 100644
--- a/drivers/net/ethernet/intel/libie/rx.c
+++ b/drivers/net/ethernet/intel/libie/rx.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /* Copyright (C) 2024 Intel Corporation */
 
-#include <linux/net/intel/libie/rx.h>
+#include <linux/intel/libie/rx.h>
 
 /* O(1) converting i40e/ice/iavf's 8/10-bit hardware packet type to a parsed
  * bitfield struct.
diff --git a/include/linux/net/intel/i40e_client.h b/include/linux/intel/i40e_client.h
similarity index 100%
rename from include/linux/net/intel/i40e_client.h
rename to include/linux/intel/i40e_client.h
diff --git a/include/linux/net/intel/iidc.h b/include/linux/intel/iidc.h
similarity index 100%
rename from include/linux/net/intel/iidc.h
rename to include/linux/intel/iidc.h
diff --git a/include/linux/net/intel/libie/rx.h b/include/linux/intel/libie/rx.h
similarity index 100%
rename from include/linux/net/intel/libie/rx.h
rename to include/linux/intel/libie/rx.h
diff --git a/include/linux/avf/virtchnl.h b/include/linux/intel/virtchnl.h
similarity index 100%
rename from include/linux/avf/virtchnl.h
rename to include/linux/intel/virtchnl.h
diff --git a/drivers/net/ethernet/intel/idpf/virtchnl2.h b/include/linux/intel/virtchnl2.h
similarity index 100%
rename from drivers/net/ethernet/intel/idpf/virtchnl2.h
rename to include/linux/intel/virtchnl2.h
diff --git a/drivers/net/ethernet/intel/idpf/virtchnl2_lan_desc.h b/include/linux/intel/virtchnl2_lan_desc.h
similarity index 100%
rename from drivers/net/ethernet/intel/idpf/virtchnl2_lan_desc.h
rename to include/linux/intel/virtchnl2_lan_desc.h
-- 
2.47.0
Re: [PATCH iwl-next v2 01/14] virtchnl: create 'include/linux/intel' and move necessary header files
Posted by Simon Horman 9 months, 2 weeks ago 
On Thu, Apr 24, 2025 at 01:32:24PM +0200, Larysa Zaremba wrote:
> From: Victor Raj <victor.raj@intel.com>
> 
> Move intel specific header files into new folder
> include/linux/intel.
> 
> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> Signed-off-by: Victor Raj <victor.raj@intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> ---
>  MAINTAINERS                                                 | 6 +++---
>  drivers/infiniband/hw/irdma/i40iw_if.c                      | 2 +-
>  drivers/infiniband/hw/irdma/main.h                          | 2 +-
>  drivers/infiniband/hw/irdma/osdep.h                         | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e.h                      | 4 ++--
>  drivers/net/ethernet/intel/i40e/i40e_client.c               | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e_common.c               | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e_prototype.h            | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c                 | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h          | 2 +-
>  drivers/net/ethernet/intel/iavf/iavf.h                      | 2 +-
>  drivers/net/ethernet/intel/iavf/iavf_common.c               | 2 +-
>  drivers/net/ethernet/intel/iavf/iavf_main.c                 | 2 +-
>  drivers/net/ethernet/intel/iavf/iavf_prototype.h            | 2 +-
>  drivers/net/ethernet/intel/iavf/iavf_txrx.c                 | 2 +-
>  drivers/net/ethernet/intel/iavf/iavf_types.h                | 4 +---
>  drivers/net/ethernet/intel/iavf/iavf_virtchnl.c             | 2 +-
>  drivers/net/ethernet/intel/ice/ice.h                        | 2 +-
>  drivers/net/ethernet/intel/ice/ice_common.h                 | 2 +-
>  drivers/net/ethernet/intel/ice/ice_idc_int.h                | 2 +-
>  drivers/net/ethernet/intel/ice/ice_txrx_lib.c               | 2 +-
>  drivers/net/ethernet/intel/ice/ice_vf_lib.h                 | 2 +-
>  drivers/net/ethernet/intel/ice/ice_virtchnl.h               | 2 +-
>  drivers/net/ethernet/intel/idpf/idpf.h                      | 2 +-
>  drivers/net/ethernet/intel/idpf/idpf_txrx.h                 | 2 +-
>  drivers/net/ethernet/intel/libie/rx.c                       | 2 +-
>  include/linux/{net => }/intel/i40e_client.h                 | 0
>  include/linux/{net => }/intel/iidc.h                        | 0
>  include/linux/{net => }/intel/libie/rx.h                    | 0
>  include/linux/{avf => intel}/virtchnl.h                     | 0
>  .../ethernet/intel/idpf => include/linux/intel}/virtchnl2.h | 0
>  .../intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h | 0
>  32 files changed, 29 insertions(+), 31 deletions(-)
>  rename include/linux/{net => }/intel/i40e_client.h (100%)
>  rename include/linux/{net => }/intel/iidc.h (100%)
>  rename include/linux/{net => }/intel/libie/rx.h (100%)
>  rename include/linux/{avf => intel}/virtchnl.h (100%)
>  rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2.h (100%)
>  rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h (100%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 657a67f9031e..2e2a57dfea8f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11884,8 +11884,8 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
>  F:	Documentation/networking/device_drivers/ethernet/intel/
>  F:	drivers/net/ethernet/intel/
>  F:	drivers/net/ethernet/intel/*/
> -F:	include/linux/avf/virtchnl.h
> -F:	include/linux/net/intel/iidc.h
> +F:	include/linux/intel/iidc.h
> +F:	include/linux/intel/virtchnl.h

I'm not sure that I understand the motivation for moving files out of
include/linux/net, but I guess the answer is that my suggestion, which
would be to move files into include/linux/net, is somehow less good.

But if file are moving out of include/linux/net then I think it would
make sense to make a corresponding update to NETWORKING DRIVERS.

Also, include/linux/intel, does feel a bit too general. These files
seem to relate to NICs (of some sort of flavour or another). But Intel
does a lot more than make NICs.

>  
>  INTEL ETHERNET PROTOCOL DRIVER FOR RDMA
>  M:	Mustafa Ismail <mustafa.ismail@intel.com>
> @@ -13534,7 +13534,7 @@ L:	netdev@vger.kernel.org
>  S:	Maintained
>  T:	git https://github.com/alobakin/linux.git
>  F:	drivers/net/ethernet/intel/libie/
> -F:	include/linux/net/intel/libie/
> +F:	include/linux/intel/libie/
>  K:	libie
>  
>  LIBNVDIMM BTT: BLOCK TRANSLATION TABLE

...
Re: [Intel-wired-lan] [PATCH iwl-next v2 01/14] virtchnl: create 'include/linux/intel' and move necessary header files
Posted by Jacob Keller 9 months, 2 weeks ago 

On 4/28/2025 9:15 AM, Simon Horman wrote:
> On Thu, Apr 24, 2025 at 01:32:24PM +0200, Larysa Zaremba wrote:
>> From: Victor Raj <victor.raj@intel.com>
>>
>> Move intel specific header files into new folder
>> include/linux/intel.
>>
>> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
>> Signed-off-by: Victor Raj <victor.raj@intel.com>
>> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
>> ---
>>  MAINTAINERS                                                 | 6 +++---
>>  drivers/infiniband/hw/irdma/i40iw_if.c                      | 2 +-
>>  drivers/infiniband/hw/irdma/main.h                          | 2 +-
>>  drivers/infiniband/hw/irdma/osdep.h                         | 2 +-
>>  drivers/net/ethernet/intel/i40e/i40e.h                      | 4 ++--
>>  drivers/net/ethernet/intel/i40e/i40e_client.c               | 2 +-
>>  drivers/net/ethernet/intel/i40e/i40e_common.c               | 2 +-
>>  drivers/net/ethernet/intel/i40e/i40e_prototype.h            | 2 +-
>>  drivers/net/ethernet/intel/i40e/i40e_txrx.c                 | 2 +-
>>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h          | 2 +-
>>  drivers/net/ethernet/intel/iavf/iavf.h                      | 2 +-
>>  drivers/net/ethernet/intel/iavf/iavf_common.c               | 2 +-
>>  drivers/net/ethernet/intel/iavf/iavf_main.c                 | 2 +-
>>  drivers/net/ethernet/intel/iavf/iavf_prototype.h            | 2 +-
>>  drivers/net/ethernet/intel/iavf/iavf_txrx.c                 | 2 +-
>>  drivers/net/ethernet/intel/iavf/iavf_types.h                | 4 +---
>>  drivers/net/ethernet/intel/iavf/iavf_virtchnl.c             | 2 +-
>>  drivers/net/ethernet/intel/ice/ice.h                        | 2 +-
>>  drivers/net/ethernet/intel/ice/ice_common.h                 | 2 +-
>>  drivers/net/ethernet/intel/ice/ice_idc_int.h                | 2 +-
>>  drivers/net/ethernet/intel/ice/ice_txrx_lib.c               | 2 +-
>>  drivers/net/ethernet/intel/ice/ice_vf_lib.h                 | 2 +-
>>  drivers/net/ethernet/intel/ice/ice_virtchnl.h               | 2 +-
>>  drivers/net/ethernet/intel/idpf/idpf.h                      | 2 +-
>>  drivers/net/ethernet/intel/idpf/idpf_txrx.h                 | 2 +-
>>  drivers/net/ethernet/intel/libie/rx.c                       | 2 +-
>>  include/linux/{net => }/intel/i40e_client.h                 | 0
>>  include/linux/{net => }/intel/iidc.h                        | 0
>>  include/linux/{net => }/intel/libie/rx.h                    | 0
>>  include/linux/{avf => intel}/virtchnl.h                     | 0
>>  .../ethernet/intel/idpf => include/linux/intel}/virtchnl2.h | 0
>>  .../intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h | 0
>>  32 files changed, 29 insertions(+), 31 deletions(-)
>>  rename include/linux/{net => }/intel/i40e_client.h (100%)
>>  rename include/linux/{net => }/intel/iidc.h (100%)
>>  rename include/linux/{net => }/intel/libie/rx.h (100%)
>>  rename include/linux/{avf => intel}/virtchnl.h (100%)
>>  rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2.h (100%)
>>  rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h (100%)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 657a67f9031e..2e2a57dfea8f 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11884,8 +11884,8 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
>>  F:	Documentation/networking/device_drivers/ethernet/intel/
>>  F:	drivers/net/ethernet/intel/
>>  F:	drivers/net/ethernet/intel/*/
>> -F:	include/linux/avf/virtchnl.h
>> -F:	include/linux/net/intel/iidc.h
>> +F:	include/linux/intel/iidc.h
>> +F:	include/linux/intel/virtchnl.h
> 
> I'm not sure that I understand the motivation for moving files out of
> include/linux/net, but I guess the answer is that my suggestion, which
> would be to move files into include/linux/net, is somehow less good.
> 
> But if file are moving out of include/linux/net then I think it would
> make sense to make a corresponding update to NETWORKING DRIVERS.
> 
> Also, include/linux/intel, does feel a bit too general. These files
> seem to relate to NICs (of some sort of flavour or another). But Intel
> does a lot more than make NICs.
> 

'include/linux/net/intel' seems fine to me. I agree with moving
virtchnl.h there since it is quite clear that any historical ambitions
about AVF being vendor agnostic are long dead, so having it in its own
'non-intel' folder is silly.

Strictly speaking, I think the goal of moving the files is due to the
fact that a lot of the core ixd code is not really network layer but
instead PCI layer.
Re: [Intel-wired-lan] [PATCH iwl-next v2 01/14] virtchnl: create 'include/linux/intel' and move necessary header files
Posted by Simon Horman 9 months, 2 weeks ago 
On Tue, Apr 29, 2025 at 11:47:58AM -0700, Jacob Keller wrote:
> 
> 
> On 4/28/2025 9:15 AM, Simon Horman wrote:
> > On Thu, Apr 24, 2025 at 01:32:24PM +0200, Larysa Zaremba wrote:
> >> From: Victor Raj <victor.raj@intel.com>
> >>
> >> Move intel specific header files into new folder
> >> include/linux/intel.
> >>
> >> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> >> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> >> Signed-off-by: Victor Raj <victor.raj@intel.com>
> >> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> >> ---
> >>  MAINTAINERS                                                 | 6 +++---
> >>  drivers/infiniband/hw/irdma/i40iw_if.c                      | 2 +-
> >>  drivers/infiniband/hw/irdma/main.h                          | 2 +-
> >>  drivers/infiniband/hw/irdma/osdep.h                         | 2 +-
> >>  drivers/net/ethernet/intel/i40e/i40e.h                      | 4 ++--
> >>  drivers/net/ethernet/intel/i40e/i40e_client.c               | 2 +-
> >>  drivers/net/ethernet/intel/i40e/i40e_common.c               | 2 +-
> >>  drivers/net/ethernet/intel/i40e/i40e_prototype.h            | 2 +-
> >>  drivers/net/ethernet/intel/i40e/i40e_txrx.c                 | 2 +-
> >>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h          | 2 +-
> >>  drivers/net/ethernet/intel/iavf/iavf.h                      | 2 +-
> >>  drivers/net/ethernet/intel/iavf/iavf_common.c               | 2 +-
> >>  drivers/net/ethernet/intel/iavf/iavf_main.c                 | 2 +-
> >>  drivers/net/ethernet/intel/iavf/iavf_prototype.h            | 2 +-
> >>  drivers/net/ethernet/intel/iavf/iavf_txrx.c                 | 2 +-
> >>  drivers/net/ethernet/intel/iavf/iavf_types.h                | 4 +---
> >>  drivers/net/ethernet/intel/iavf/iavf_virtchnl.c             | 2 +-
> >>  drivers/net/ethernet/intel/ice/ice.h                        | 2 +-
> >>  drivers/net/ethernet/intel/ice/ice_common.h                 | 2 +-
> >>  drivers/net/ethernet/intel/ice/ice_idc_int.h                | 2 +-
> >>  drivers/net/ethernet/intel/ice/ice_txrx_lib.c               | 2 +-
> >>  drivers/net/ethernet/intel/ice/ice_vf_lib.h                 | 2 +-
> >>  drivers/net/ethernet/intel/ice/ice_virtchnl.h               | 2 +-
> >>  drivers/net/ethernet/intel/idpf/idpf.h                      | 2 +-
> >>  drivers/net/ethernet/intel/idpf/idpf_txrx.h                 | 2 +-
> >>  drivers/net/ethernet/intel/libie/rx.c                       | 2 +-
> >>  include/linux/{net => }/intel/i40e_client.h                 | 0
> >>  include/linux/{net => }/intel/iidc.h                        | 0
> >>  include/linux/{net => }/intel/libie/rx.h                    | 0
> >>  include/linux/{avf => intel}/virtchnl.h                     | 0
> >>  .../ethernet/intel/idpf => include/linux/intel}/virtchnl2.h | 0
> >>  .../intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h | 0
> >>  32 files changed, 29 insertions(+), 31 deletions(-)
> >>  rename include/linux/{net => }/intel/i40e_client.h (100%)
> >>  rename include/linux/{net => }/intel/iidc.h (100%)
> >>  rename include/linux/{net => }/intel/libie/rx.h (100%)
> >>  rename include/linux/{avf => intel}/virtchnl.h (100%)
> >>  rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2.h (100%)
> >>  rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h (100%)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 657a67f9031e..2e2a57dfea8f 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -11884,8 +11884,8 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
> >>  F:	Documentation/networking/device_drivers/ethernet/intel/
> >>  F:	drivers/net/ethernet/intel/
> >>  F:	drivers/net/ethernet/intel/*/
> >> -F:	include/linux/avf/virtchnl.h
> >> -F:	include/linux/net/intel/iidc.h
> >> +F:	include/linux/intel/iidc.h
> >> +F:	include/linux/intel/virtchnl.h
> > 
> > I'm not sure that I understand the motivation for moving files out of
> > include/linux/net, but I guess the answer is that my suggestion, which
> > would be to move files into include/linux/net, is somehow less good.
> > 
> > But if file are moving out of include/linux/net then I think it would
> > make sense to make a corresponding update to NETWORKING DRIVERS.
> > 
> > Also, include/linux/intel, does feel a bit too general. These files
> > seem to relate to NICs (of some sort of flavour or another). But Intel
> > does a lot more than make NICs.
> > 
> 
> 'include/linux/net/intel' seems fine to me. I agree with moving
> virtchnl.h there since it is quite clear that any historical ambitions
> about AVF being vendor agnostic are long dead, so having it in its own
> 'non-intel' folder is silly.
> 
> Strictly speaking, I think the goal of moving the files is due to the
> fact that a lot of the core ixd code is not really network layer but
> instead PCI layer.

Sure. I was more thinking out loud in my previous email than requesting any
action. Thanks for filling in my understanding of the situation.

But could we please consider updating NETWORKING DRIVERS so
that get_maintainers.pl can help people to CC netdev and it's maintainers
as appropriate?
Re: [Intel-wired-lan] [PATCH iwl-next v2 01/14] virtchnl: create 'include/linux/intel' and move necessary header files
Posted by Larysa Zaremba 9 months, 1 week ago 
On Wed, Apr 30, 2025 at 09:55:45AM +0100, Simon Horman wrote:
> On Tue, Apr 29, 2025 at 11:47:58AM -0700, Jacob Keller wrote:
> > 
> > 
> > On 4/28/2025 9:15 AM, Simon Horman wrote:
> > > On Thu, Apr 24, 2025 at 01:32:24PM +0200, Larysa Zaremba wrote:
> > >> From: Victor Raj <victor.raj@intel.com>
> > >>
> > >> Move intel specific header files into new folder
> > >> include/linux/intel.
> > >>
> > >> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> > >> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> > >> Signed-off-by: Victor Raj <victor.raj@intel.com>
> > >> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> > >> ---
> > >>  MAINTAINERS                                                 | 6 +++---
> > >>  drivers/infiniband/hw/irdma/i40iw_if.c                      | 2 +-
> > >>  drivers/infiniband/hw/irdma/main.h                          | 2 +-
> > >>  drivers/infiniband/hw/irdma/osdep.h                         | 2 +-
> > >>  drivers/net/ethernet/intel/i40e/i40e.h                      | 4 ++--
> > >>  drivers/net/ethernet/intel/i40e/i40e_client.c               | 2 +-
> > >>  drivers/net/ethernet/intel/i40e/i40e_common.c               | 2 +-
> > >>  drivers/net/ethernet/intel/i40e/i40e_prototype.h            | 2 +-
> > >>  drivers/net/ethernet/intel/i40e/i40e_txrx.c                 | 2 +-
> > >>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h          | 2 +-
> > >>  drivers/net/ethernet/intel/iavf/iavf.h                      | 2 +-
> > >>  drivers/net/ethernet/intel/iavf/iavf_common.c               | 2 +-
> > >>  drivers/net/ethernet/intel/iavf/iavf_main.c                 | 2 +-
> > >>  drivers/net/ethernet/intel/iavf/iavf_prototype.h            | 2 +-
> > >>  drivers/net/ethernet/intel/iavf/iavf_txrx.c                 | 2 +-
> > >>  drivers/net/ethernet/intel/iavf/iavf_types.h                | 4 +---
> > >>  drivers/net/ethernet/intel/iavf/iavf_virtchnl.c             | 2 +-
> > >>  drivers/net/ethernet/intel/ice/ice.h                        | 2 +-
> > >>  drivers/net/ethernet/intel/ice/ice_common.h                 | 2 +-
> > >>  drivers/net/ethernet/intel/ice/ice_idc_int.h                | 2 +-
> > >>  drivers/net/ethernet/intel/ice/ice_txrx_lib.c               | 2 +-
> > >>  drivers/net/ethernet/intel/ice/ice_vf_lib.h                 | 2 +-
> > >>  drivers/net/ethernet/intel/ice/ice_virtchnl.h               | 2 +-
> > >>  drivers/net/ethernet/intel/idpf/idpf.h                      | 2 +-
> > >>  drivers/net/ethernet/intel/idpf/idpf_txrx.h                 | 2 +-
> > >>  drivers/net/ethernet/intel/libie/rx.c                       | 2 +-
> > >>  include/linux/{net => }/intel/i40e_client.h                 | 0
> > >>  include/linux/{net => }/intel/iidc.h                        | 0
> > >>  include/linux/{net => }/intel/libie/rx.h                    | 0
> > >>  include/linux/{avf => intel}/virtchnl.h                     | 0
> > >>  .../ethernet/intel/idpf => include/linux/intel}/virtchnl2.h | 0
> > >>  .../intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h | 0
> > >>  32 files changed, 29 insertions(+), 31 deletions(-)
> > >>  rename include/linux/{net => }/intel/i40e_client.h (100%)
> > >>  rename include/linux/{net => }/intel/iidc.h (100%)
> > >>  rename include/linux/{net => }/intel/libie/rx.h (100%)
> > >>  rename include/linux/{avf => intel}/virtchnl.h (100%)
> > >>  rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2.h (100%)
> > >>  rename {drivers/net/ethernet/intel/idpf => include/linux/intel}/virtchnl2_lan_desc.h (100%)
> > >>
> > >> diff --git a/MAINTAINERS b/MAINTAINERS
> > >> index 657a67f9031e..2e2a57dfea8f 100644
> > >> --- a/MAINTAINERS
> > >> +++ b/MAINTAINERS
> > >> @@ -11884,8 +11884,8 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
> > >>  F:	Documentation/networking/device_drivers/ethernet/intel/
> > >>  F:	drivers/net/ethernet/intel/
> > >>  F:	drivers/net/ethernet/intel/*/
> > >> -F:	include/linux/avf/virtchnl.h
> > >> -F:	include/linux/net/intel/iidc.h
> > >> +F:	include/linux/intel/iidc.h
> > >> +F:	include/linux/intel/virtchnl.h
> > > 
> > > I'm not sure that I understand the motivation for moving files out of
> > > include/linux/net, but I guess the answer is that my suggestion, which
> > > would be to move files into include/linux/net, is somehow less good.
> > > 
> > > But if file are moving out of include/linux/net then I think it would
> > > make sense to make a corresponding update to NETWORKING DRIVERS.
> > > 
> > > Also, include/linux/intel, does feel a bit too general. These files
> > > seem to relate to NICs (of some sort of flavour or another). But Intel
> > > does a lot more than make NICs.
> > > 
> > 
> > 'include/linux/net/intel' seems fine to me. I agree with moving
> > virtchnl.h there since it is quite clear that any historical ambitions
> > about AVF being vendor agnostic are long dead, so having it in its own
> > 'non-intel' folder is silly.
> > 
> > Strictly speaking, I think the goal of moving the files is due to the
> > fact that a lot of the core ixd code is not really network layer but
> > instead PCI layer.
> 
> Sure. I was more thinking out loud in my previous email than requesting any
> action. Thanks for filling in my understanding of the situation.
>

Olek suggested this because intel was the only resident in include/linux/net and 
include/linux/intel was vacant.
 
> But could we please consider updating NETWORKING DRIVERS so
> that get_maintainers.pl can help people to CC netdev and it's maintainers
> as appropriate?

I am not sure what kind of update do you mean, include/linux/net directory was 
not under any maintainer. include/linux/mlx5 and include/linux/mlx4 are only 
under vendor maintainers.

For sure I should add include/linux/intel/* under Tony.
Do you think it also should be added to general networking maintainers?
Re: [Intel-wired-lan] [PATCH iwl-next v2 01/14] virtchnl: create 'include/linux/intel' and move necessary header files
Posted by Simon Horman 9 months, 1 week ago 
On Mon, May 05, 2025 at 09:56:37AM +0200, Larysa Zaremba wrote:
> On Wed, Apr 30, 2025 at 09:55:45AM +0100, Simon Horman wrote:
> > On Tue, Apr 29, 2025 at 11:47:58AM -0700, Jacob Keller wrote:
> > > On 4/28/2025 9:15 AM, Simon Horman wrote:
> > > > On Thu, Apr 24, 2025 at 01:32:24PM +0200, Larysa Zaremba wrote:

...

> > > >> diff --git a/MAINTAINERS b/MAINTAINERS
> > > >> index 657a67f9031e..2e2a57dfea8f 100644
> > > >> --- a/MAINTAINERS
> > > >> +++ b/MAINTAINERS
> > > >> @@ -11884,8 +11884,8 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
> > > >>  F:	Documentation/networking/device_drivers/ethernet/intel/
> > > >>  F:	drivers/net/ethernet/intel/
> > > >>  F:	drivers/net/ethernet/intel/*/
> > > >> -F:	include/linux/avf/virtchnl.h
> > > >> -F:	include/linux/net/intel/iidc.h
> > > >> +F:	include/linux/intel/iidc.h
> > > >> +F:	include/linux/intel/virtchnl.h
> > > > 
> > > > I'm not sure that I understand the motivation for moving files out of
> > > > include/linux/net, but I guess the answer is that my suggestion, which
> > > > would be to move files into include/linux/net, is somehow less good.
> > > > 
> > > > But if file are moving out of include/linux/net then I think it would
> > > > make sense to make a corresponding update to NETWORKING DRIVERS.
> > > > 
> > > > Also, include/linux/intel, does feel a bit too general. These files
> > > > seem to relate to NICs (of some sort of flavour or another). But Intel
> > > > does a lot more than make NICs.
> > > > 
> > > 
> > > 'include/linux/net/intel' seems fine to me. I agree with moving
> > > virtchnl.h there since it is quite clear that any historical ambitions
> > > about AVF being vendor agnostic are long dead, so having it in its own
> > > 'non-intel' folder is silly.
> > > 
> > > Strictly speaking, I think the goal of moving the files is due to the
> > > fact that a lot of the core ixd code is not really network layer but
> > > instead PCI layer.
> > 
> > Sure. I was more thinking out loud in my previous email than requesting any
> > action. Thanks for filling in my understanding of the situation.
> >
> 
> Olek suggested this because intel was the only resident in include/linux/net and 
> include/linux/intel was vacant.
>  
> > But could we please consider updating NETWORKING DRIVERS so
> > that get_maintainers.pl can help people to CC netdev and it's maintainers
> > as appropriate?
> 
> I am not sure what kind of update do you mean, include/linux/net directory was 

Thanks I missed that.

> not under any maintainer. include/linux/mlx5 and include/linux/mlx4 are only 
> under vendor maintainers.
> 
> For sure I should add include/linux/intel/* under Tony.
> Do you think it also should be added to general networking maintainers?

I think it would make sense to add it to general networking, or at least
those files that would tend to be updated via netdev. But at least let's
put the directory under Tony so it's maintained by somebody.
Re: [Intel-wired-lan] [PATCH iwl-next v2 01/14] virtchnl: create 'include/linux/intel' and move necessary header files
Posted by Larysa Zaremba 9 months, 1 week ago 
On Tue, May 06, 2025 at 04:59:58PM +0100, Simon Horman wrote:
> On Mon, May 05, 2025 at 09:56:37AM +0200, Larysa Zaremba wrote:
> > On Wed, Apr 30, 2025 at 09:55:45AM +0100, Simon Horman wrote:
> > > On Tue, Apr 29, 2025 at 11:47:58AM -0700, Jacob Keller wrote:
> > > > On 4/28/2025 9:15 AM, Simon Horman wrote:
> > > > > On Thu, Apr 24, 2025 at 01:32:24PM +0200, Larysa Zaremba wrote:
> 
> ...
> 
> > > > >> diff --git a/MAINTAINERS b/MAINTAINERS
> > > > >> index 657a67f9031e..2e2a57dfea8f 100644
> > > > >> --- a/MAINTAINERS
> > > > >> +++ b/MAINTAINERS
> > > > >> @@ -11884,8 +11884,8 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
> > > > >>  F:	Documentation/networking/device_drivers/ethernet/intel/
> > > > >>  F:	drivers/net/ethernet/intel/
> > > > >>  F:	drivers/net/ethernet/intel/*/
> > > > >> -F:	include/linux/avf/virtchnl.h
> > > > >> -F:	include/linux/net/intel/iidc.h
> > > > >> +F:	include/linux/intel/iidc.h
> > > > >> +F:	include/linux/intel/virtchnl.h
> > > > > 
> > > > > I'm not sure that I understand the motivation for moving files out of
> > > > > include/linux/net, but I guess the answer is that my suggestion, which
> > > > > would be to move files into include/linux/net, is somehow less good.
> > > > > 
> > > > > But if file are moving out of include/linux/net then I think it would
> > > > > make sense to make a corresponding update to NETWORKING DRIVERS.
> > > > > 
> > > > > Also, include/linux/intel, does feel a bit too general. These files
> > > > > seem to relate to NICs (of some sort of flavour or another). But Intel
> > > > > does a lot more than make NICs.
> > > > > 
> > > > 
> > > > 'include/linux/net/intel' seems fine to me. I agree with moving
> > > > virtchnl.h there since it is quite clear that any historical ambitions
> > > > about AVF being vendor agnostic are long dead, so having it in its own
> > > > 'non-intel' folder is silly.
> > > > 
> > > > Strictly speaking, I think the goal of moving the files is due to the
> > > > fact that a lot of the core ixd code is not really network layer but
> > > > instead PCI layer.
> > > 
> > > Sure. I was more thinking out loud in my previous email than requesting any
> > > action. Thanks for filling in my understanding of the situation.
> > >
> > 
> > Olek suggested this because intel was the only resident in include/linux/net and 
> > include/linux/intel was vacant.
> >  
> > > But could we please consider updating NETWORKING DRIVERS so
> > > that get_maintainers.pl can help people to CC netdev and it's maintainers
> > > as appropriate?
> > 
> > I am not sure what kind of update do you mean, include/linux/net directory was 
> 
> Thanks I missed that.
> 
> > not under any maintainer. include/linux/mlx5 and include/linux/mlx4 are only 
> > under vendor maintainers.
> > 
> > For sure I should add include/linux/intel/* under Tony.
> > Do you think it also should be added to general networking maintainers?
> 
> I think it would make sense to add it to general networking, or at least
> those files that would tend to be updated via netdev. But at least let's
> put the directory under Tony so it's maintained by somebody.

Thanks for the clarification!

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.