[v5] virtio-net: disable delayed refill when pausing rx

[PATCH v5 0/3] virtio-net: disable delayed refill when pausing rx

Posted by Bui Quang Minh 9 months, 2 weeks ago

Hi everyone,

This only includes the selftest for virtio-net deadlock bug. The fix
commit has been applied already.

Link: https://lore.kernel.org/virtualization/174537302875.2111809.8543884098526067319.git-patchwork-notify@kernel.org/T/

Version 5 changes:
- Refactor the selftest

Version 4 changes:
- Add force zerocopy mode to xdp_helper
- Make virtio_net selftest use force zerocopy mode
- Move virtio_net selftest to drivers/net/hw

Version 3 changes:
- Patch 1: refactor to avoid code duplication

Version 2 changes:
- Add selftest for deadlock scenario

Thanks,
Quang Minh.

Bui Quang Minh (3):
  selftests: net: move xdp_helper to net/lib
  selftests: net: add flag to force zerocopy mode in xdp_helper
  selftests: net: add a virtio_net deadlock selftest

 tools/testing/selftests/drivers/net/Makefile  |  2 -
 .../testing/selftests/drivers/net/hw/Makefile |  1 +
 .../selftests/drivers/net/hw/xsk_reconfig.py  | 68 +++++++++++++++++++
 tools/testing/selftests/drivers/net/queues.py |  4 +-
 tools/testing/selftests/net/lib/.gitignore    |  1 +
 tools/testing/selftests/net/lib/Makefile      |  1 +
 .../{drivers/net => net/lib}/xdp_helper.c     | 19 +++++-
 7 files changed, 90 insertions(+), 6 deletions(-)
 create mode 100755 tools/testing/selftests/drivers/net/hw/xsk_reconfig.py
 rename tools/testing/selftests/{drivers/net => net/lib}/xdp_helper.c (90%)

-- 
2.43.0

Re: [PATCH v5 0/3] virtio-net: disable delayed refill when pausing rx

Posted by Jakub Kicinski 9 months, 2 weeks ago

On Thu, 24 Apr 2025 17:47:13 +0700 Bui Quang Minh wrote:
> This only includes the selftest for virtio-net deadlock bug. The fix
> commit has been applied already.

This conflicts with Joe's series slightly: 
https://lore.kernel.org/all/20250424002746.16891-1-jdamato@fastly.com/
Could you rebase on latest net-next and perhaps follow the comment 
I left on v4 ? 
-- 
pw-bot: cr

Re: [PATCH v5 0/3] virtio-net: disable delayed refill when pausing rx

Posted by Bui Quang Minh 9 months, 2 weeks ago

On 4/25/25 08:34, Jakub Kicinski wrote:
> On Thu, 24 Apr 2025 17:47:13 +0700 Bui Quang Minh wrote:
>> This only includes the selftest for virtio-net deadlock bug. The fix
>> commit has been applied already.
> This conflicts with Joe's series slightly:
> https://lore.kernel.org/all/20250424002746.16891-1-jdamato@fastly.com/
> Could you rebase on latest net-next and perhaps follow the comment
> I left on v4 ?

Sure, I'll do it. Thanks for your review :)

Quang Minh.

Re: [PATCH v5 0/3] virtio-net: disable delayed refill when pausing rx

Posted by Michael S. Tsirkin 9 months, 2 weeks ago

On Thu, Apr 24, 2025 at 05:47:13PM +0700, Bui Quang Minh wrote:
> Hi everyone,
> 
> This only includes the selftest for virtio-net deadlock bug. The fix
> commit has been applied already.
> 
> Link: https://lore.kernel.org/virtualization/174537302875.2111809.8543884098526067319.git-patchwork-notify@kernel.org/T/

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> Version 5 changes:
> - Refactor the selftest
> 
> Version 4 changes:
> - Add force zerocopy mode to xdp_helper
> - Make virtio_net selftest use force zerocopy mode
> - Move virtio_net selftest to drivers/net/hw
> 
> Version 3 changes:
> - Patch 1: refactor to avoid code duplication
> 
> Version 2 changes:
> - Add selftest for deadlock scenario
> 
> Thanks,
> Quang Minh.
> 
> Bui Quang Minh (3):
>   selftests: net: move xdp_helper to net/lib
>   selftests: net: add flag to force zerocopy mode in xdp_helper
>   selftests: net: add a virtio_net deadlock selftest
> 
>  tools/testing/selftests/drivers/net/Makefile  |  2 -
>  .../testing/selftests/drivers/net/hw/Makefile |  1 +
>  .../selftests/drivers/net/hw/xsk_reconfig.py  | 68 +++++++++++++++++++
>  tools/testing/selftests/drivers/net/queues.py |  4 +-
>  tools/testing/selftests/net/lib/.gitignore    |  1 +
>  tools/testing/selftests/net/lib/Makefile      |  1 +
>  .../{drivers/net => net/lib}/xdp_helper.c     | 19 +++++-
>  7 files changed, 90 insertions(+), 6 deletions(-)
>  create mode 100755 tools/testing/selftests/drivers/net/hw/xsk_reconfig.py
>  rename tools/testing/selftests/{drivers/net => net/lib}/xdp_helper.c (90%)
> 
> -- 
> 2.43.0