arm64: dts: ti: k3-j721e-common-proc-board-infotainment: Fix nodes for dtbs warnings

[PATCH] arm64: dts: ti: k3-j721e-common-proc-board-infotainment: Fix nodes for dtbs warnings

Posted by Jayesh Choudhary 9 months, 2 weeks ago

Fix hdmi-connector and tfp bridge node as per the bindings,
- remove 'digital' property which is required for DVI connector not HDMI
- Add 'ti,deskew' property which is a required property
- Fix ports property for tfp410 bridge
- Change node names appropriately

Redefine the ports for dss and for k3-j721e-common-proc-board.dts,
add reg property for the port (@0) to get rid of dtbs_warnings in
infotainment overlay when ports for dss are re-defined.

Fixes: 9c0fa304fa56 ("arm64: dts: ti: k3-j721e: Add overlay for J721E Infotainment Expansion Board")
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
 ...-j721e-common-proc-board-infotainment.dtso | 57 +++++++++++--------
 .../dts/ti/k3-j721e-common-proc-board.dts     |  6 +-
 2 files changed, 38 insertions(+), 25 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board-infotainment.dtso b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board-infotainment.dtso
index 65a7e54f0884..e4e5f941f20b 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board-infotainment.dtso
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board-infotainment.dtso
@@ -15,12 +15,11 @@
 #include "k3-pinctrl.h"
 
 &{/} {
-	hdmi-connector {
+	connector-hdmi {
 		compatible = "hdmi-connector";
 		label = "hdmi";
 		type = "a";
 		ddc-i2c-bus = <&main_i2c1>;
-		digital;
 		/* P12 - HDMI_HPD */
 		hpd-gpios = <&exp6 10 GPIO_ACTIVE_HIGH>;
 
@@ -31,28 +30,32 @@ hdmi_connector_in: endpoint {
 		};
 	};
 
-	dvi-bridge {
-		#address-cells = <1>;
-		#size-cells = <0>;
+	bridge-dvi {
 		compatible = "ti,tfp410";
 		/* P10 - HDMI_PDn */
 		powerdown-gpios = <&exp6 8 GPIO_ACTIVE_LOW>;
+		ti,deskew = <0>;
 
-		port@0 {
-			reg = <0>;
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
 
-			tfp410_in: endpoint {
-				remote-endpoint = <&dpi_out0>;
-				pclk-sample = <1>;
+				tfp410_in: endpoint {
+					remote-endpoint = <&dpi_out0>;
+					pclk-sample = <1>;
+				};
 			};
-		};
 
-		port@1 {
-			reg = <1>;
+			port@1 {
+				reg = <1>;
 
-			tfp410_out: endpoint {
-				remote-endpoint =
-					<&hdmi_connector_in>;
+				tfp410_out: endpoint {
+					remote-endpoint =
+						<&hdmi_connector_in>;
+				};
 			};
 		};
 	};
@@ -148,17 +151,23 @@ p11-hog {
 &dss {
 	pinctrl-names = "default";
 	pinctrl-0 = <&dss_vout0_pins_default>;
-};
 
-&dss_ports {
-	#address-cells = <1>;
-	#size-cells = <0>;
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
 
-	port@1 {
-		reg = <1>;
+		port@0 {
+			reg = <0>;
+			dpi0_out: endpoint {
+				remote-endpoint = <&dp0_in>;
+			};
+		};
 
-		dpi_out0: endpoint {
-			remote-endpoint = <&tfp410_in>;
+		port@1 {
+			reg = <1>;
+			dpi_out0: endpoint {
+				remote-endpoint = <&tfp410_in>;
+			};
 		};
 	};
 };
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 4421852161dd..e3d0ef6913b2 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -804,7 +804,11 @@ &dss {
 };
 
 &dss_ports {
-	port {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	port@0 {
+		reg = <0>;
 		dpi0_out: endpoint {
 			remote-endpoint = <&dp0_in>;
 		};
-- 
2.34.1

Re: [PATCH] arm64: dts: ti: k3-j721e-common-proc-board-infotainment: Fix nodes for dtbs warnings

Posted by Nishanth Menon 9 months, 2 weeks ago

Hi Jayesh Choudhary,

On Thu, 24 Apr 2025 13:33:28 +0530, Jayesh Choudhary wrote:
> Fix hdmi-connector and tfp bridge node as per the bindings,
> - remove 'digital' property which is required for DVI connector not HDMI
> - Add 'ti,deskew' property which is a required property
> - Fix ports property for tfp410 bridge
> - Change node names appropriately
> 
> Redefine the ports for dss and for k3-j721e-common-proc-board.dts,
> add reg property for the port (@0) to get rid of dtbs_warnings in
> infotainment overlay when ports for dss are re-defined.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1]. I had
done minor fixups in the commit message and dropped the fixes tag as
the fixups donot seem to have functional impact to require to go down
the stable flow. Let me know if you think otherwise and we can drop
the patch and respin the series.

Thank you!

[1/1] arm64: dts: ti: k3-j721e-common-proc-board-infotainment: Fix nodes for dtbs warnings
      commit: 8a0bba5b6730a1491a111bf54de5d8dcc23c8e10

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH] arm64: dts: ti: k3-j721e-common-proc-board-infotainment: Fix nodes for dtbs warnings

Posted by Kumar, Udit 9 months, 2 weeks ago

On 4/24/2025 1:33 PM, Jayesh Choudhary wrote:
> Fix hdmi-connector and tfp bridge node as per the bindings,
> - remove 'digital' property which is required for DVI connector not HDMI
> - Add 'ti,deskew' property which is a required property
> - Fix ports property for tfp410 bridge
> - Change node names appropriately
>
> Redefine the ports for dss and for k3-j721e-common-proc-board.dts,
> add reg property for the port (@0) to get rid of dtbs_warnings in
> infotainment overlay when ports for dss are re-defined.
>
> Fixes: 9c0fa304fa56 ("arm64: dts: ti: k3-j721e: Add overlay for J721E Infotainment Expansion Board")
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
>   ...-j721e-common-proc-board-infotainment.dtso | 57 +++++++++++--------
>   .../dts/ti/k3-j721e-common-proc-board.dts     |  6 +-
>   2 files changed, 38 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board-infotainment.dtso b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board-infotainment.dtso
> index 65a7e54f0884..e4e5f941f20b 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board-infotainment.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board-infotainment.dtso
> @@ -15,12 +15,11 @@
>   #include "k3-pinctrl.h"
>   
>   &{/} {
> -	hdmi-connector {
> +	connector-hdmi {
>   		compatible = "hdmi-connector";
>   		label = "hdmi";
>   		type = "a";
>   		ddc-i2c-bus = <&main_i2c1>;
> -		digital;
>   		/* P12 - HDMI_HPD */
>   		hpd-gpios = <&exp6 10 GPIO_ACTIVE_HIGH>;
>   
> @@ -31,28 +30,32 @@ hdmi_connector_in: endpoint {
>   		};
>   	};
>   
> -	dvi-bridge {
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> +	bridge-dvi {
>   		compatible = "ti,tfp410";
>   		/* P10 - HDMI_PDn */
>   		powerdown-gpios = <&exp6 8 GPIO_ACTIVE_LOW>;
> +		ti,deskew = <0>;
>   
> -		port@0 {
> -			reg = <0>;
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;

Reviewed-by: Udit Kumar <u-kumar1@ti.com>


>   
> -			tfp410_in: endpoint {
> -				remote-endpoint = <&dpi_out0>;
> -				pclk-sample = <1>;
> [..]