Introduce 'firmware-name' property to allow end-users and/or integrators
to decide which usecase-specific firmware to run on the WCN7850 platform.
This is necessary due to resource limitations such as memory capacity and
CPU capability, or performance and power optimization for different
application scenarios.

Two firmwares are supported: 'WCN7850/hw2.0' and 'WCN7850/hw2.0/ncm825'.
The former is the default firmware, suitable for most WiFi 7 STA
functions. The latter adds support for commercial-quality SAP and
optimizes power consumption for IoT applications.

Signed-off-by: Miaoqing Pan <quic_miaoqing@quicinc.com>
---
 .../devicetree/bindings/net/wireless/qcom,ath12k.yaml       | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
index 9e557cb838c7..dc68dd59988f 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
@@ -21,6 +21,12 @@ properties:
   reg:
     maxItems: 1
 
+  firmware-name:
+    maxItems: 1
+    description:
+      If present, a board or platform specific string used to lookup
+      usecase-specific firmware files for the device.
+
   vddaon-supply:
     description: VDD_AON supply regulator handle
 
-- 
2.25.1

On 24/04/2025 02:57, Miaoqing Pan wrote:
> Introduce 'firmware-name' property to allow end-users and/or integrators
> to decide which usecase-specific firmware to run on the WCN7850 platform.
> This is necessary due to resource limitations such as memory capacity and
> CPU capability, or performance and power optimization for different
> application scenarios.
> 
> Two firmwares are supported: 'WCN7850/hw2.0' and 'WCN7850/hw2.0/ncm825'.
> The former is the default firmware, suitable for most WiFi 7 STA
> functions. The latter adds support for commercial-quality SAP and
> optimizes power consumption for IoT applications.
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

On Thu, Apr 24, 2025 at 08:57:02AM GMT, Miaoqing Pan wrote:
> Introduce 'firmware-name' property to allow end-users and/or integrators
> to decide which usecase-specific firmware to run on the WCN7850 platform.
> This is necessary due to resource limitations such as memory capacity and
> CPU capability, or performance and power optimization for different
> application scenarios.
> 
> Two firmwares are supported: 'WCN7850/hw2.0' and 'WCN7850/hw2.0/ncm825'.
> The former is the default firmware, suitable for most WiFi 7 STA
> functions. The latter adds support for commercial-quality SAP and
> optimizes power consumption for IoT applications.
> 
> Signed-off-by: Miaoqing Pan <quic_miaoqing@quicinc.com>
> ---
>  .../devicetree/bindings/net/wireless/qcom,ath12k.yaml       | 6 ++++++
>  1 file changed, 6 insertions(+)

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here. However, there's no
need to repost patches *only* to add the tags. The upstream maintainer
will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof

On 4/28/2025 4:25 PM, Krzysztof Kozlowski wrote:
> On Thu, Apr 24, 2025 at 08:57:02AM GMT, Miaoqing Pan wrote:
>> Introduce 'firmware-name' property to allow end-users and/or integrators
>> to decide which usecase-specific firmware to run on the WCN7850 platform.
>> This is necessary due to resource limitations such as memory capacity and
>> CPU capability, or performance and power optimization for different
>> application scenarios.
>>
>> Two firmwares are supported: 'WCN7850/hw2.0' and 'WCN7850/hw2.0/ncm825'.
>> The former is the default firmware, suitable for most WiFi 7 STA
>> functions. The latter adds support for commercial-quality SAP and
>> optimizes power consumption for IoT applications.
>>
>> Signed-off-by: Miaoqing Pan <quic_miaoqing@quicinc.com>
>> ---
>>   .../devicetree/bindings/net/wireless/qcom,ath12k.yaml       | 6 ++++++
>>   1 file changed, 6 insertions(+)
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 

I don't find any tags on previous version: 
https://patchwork.kernel.org/project/linux-wireless/patch/20250423054152.2471568-2-quic_miaoqing@quicinc.com/.

Do you mean I should add 'Reviewed-by: Krzysztof Kozlowski 
<krzk@kernel.org>' ?


> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless
> patch changed significantly (e.g. new properties added to the DT
> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags. The upstream maintainer
> will do that for tags received on the version they apply.
> 
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 
> Best regards,
> Krzysztof
>

On 28/04/2025 11:48, Miaoqing Pan wrote:
> 
> 
> On 4/28/2025 4:25 PM, Krzysztof Kozlowski wrote:
>> On Thu, Apr 24, 2025 at 08:57:02AM GMT, Miaoqing Pan wrote:
>>> Introduce 'firmware-name' property to allow end-users and/or integrators
>>> to decide which usecase-specific firmware to run on the WCN7850 platform.
>>> This is necessary due to resource limitations such as memory capacity and
>>> CPU capability, or performance and power optimization for different
>>> application scenarios.
>>>
>>> Two firmwares are supported: 'WCN7850/hw2.0' and 'WCN7850/hw2.0/ncm825'.
>>> The former is the default firmware, suitable for most WiFi 7 STA
>>> functions. The latter adds support for commercial-quality SAP and
>>> optimizes power consumption for IoT applications.
>>>
>>> Signed-off-by: Miaoqing Pan <quic_miaoqing@quicinc.com>
>>> ---
>>>   .../devicetree/bindings/net/wireless/qcom,ath12k.yaml       | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
> 
> I don't find any tags on previous version: 
> https://patchwork.kernel.org/project/linux-wireless/patch/20250423054152.2471568-2-quic_miaoqing@quicinc.com/.
> 
> Do you mean I should add 'Reviewed-by: Krzysztof Kozlowski 
> <krzk@kernel.org>' ?

No, probably I mixed up the patches.

Best regards,
Krzysztof