serdev: Improve messages printed by dev_err() and dev_dbg()

[PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

Posted by Zijun Hu 9 months, 2 weeks ago

From: Zijun Hu <quic_zijuhu@quicinc.com>

There are serval dev_err() and dev_dbg() usages shown below:

dev_dbg(dev, "...%s...", dev_name(dev))

The device name is repeated since dev_dbg() also prints device
name as prefix.

Fix by optimizing the messages printed.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 drivers/tty/serdev/core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
 
 	err = device_add(&serdev->dev);
 	if (err < 0) {
-		dev_err(&serdev->dev, "Can't add %s, status %pe\n",
-			dev_name(&serdev->dev), ERR_PTR(err));
+		dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
+			ERR_PTR(err));
 		goto err_clear_serdev;
 	}
 
-	dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev));
+	dev_dbg(&serdev->dev, "serdev registered successfully\n");
 
 	return 0;
 
@@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
 		goto err_rpm_disable;
 	}
 
-	dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
-		dev_name(&ctrl->dev), &ctrl->dev);
+	dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n",
+		&ctrl->dev);
 	return 0;
 
 err_rpm_disable:

-- 
2.34.1

Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

Posted by Jiri Slaby 9 months, 2 weeks ago

On 24. 04. 25, 14:23, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> There are serval dev_err() and dev_dbg() usages shown below:
> 
> dev_dbg(dev, "...%s...", dev_name(dev))
> 
> The device name is repeated since dev_dbg() also prints device
> name as prefix.
> 
> Fix by optimizing the messages printed.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>   drivers/tty/serdev/core.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> index 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644
> --- a/drivers/tty/serdev/core.c
> +++ b/drivers/tty/serdev/core.c
> @@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
>   
>   	err = device_add(&serdev->dev);
>   	if (err < 0) {
> -		dev_err(&serdev->dev, "Can't add %s, status %pe\n",
> -			dev_name(&serdev->dev), ERR_PTR(err));
> +		dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
> +			ERR_PTR(err));

You don't need to wrap now.

Could you also get rid of ERR_PTR() and print err directly using %d?

>   		goto err_clear_serdev;
>   	}
>   
> -	dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev));
> +	dev_dbg(&serdev->dev, "serdev registered successfully\n");
>   
>   	return 0;
>   
> @@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
>   		goto err_rpm_disable;
>   	}
>   
> -	dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
> -		dev_name(&ctrl->dev), &ctrl->dev);
> +	dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n",
> +		&ctrl->dev);

No need to wrap.

-- 
js
suse labs

Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

Posted by Zijun Hu 9 months, 2 weeks ago

On 2025/4/25 13:38, Jiri Slaby wrote:
>>
>> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
>> index
>> 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644
>> --- a/drivers/tty/serdev/core.c
>> +++ b/drivers/tty/serdev/core.c
>> @@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
>>         err = device_add(&serdev->dev);
>>       if (err < 0) {
>> -        dev_err(&serdev->dev, "Can't add %s, status %pe\n",
>> -            dev_name(&serdev->dev), ERR_PTR(err));
>> +        dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
>> +            ERR_PTR(err));
> 
> You don't need to wrap now.
> 
> Could you also get rid of ERR_PTR() and print err directly using %d?
> 
>>           goto err_clear_serdev; 

sure, will do it in next revision.

Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

Posted by Rob Herring 9 months, 2 weeks ago

On Thu, Apr 24, 2025 at 7:24 AM Zijun Hu <zijun_hu@icloud.com> wrote:
>
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> There are serval dev_err() and dev_dbg() usages shown below:
>
> dev_dbg(dev, "...%s...", dev_name(dev))
>
> The device name is repeated since dev_dbg() also prints device
> name as prefix.
>
> Fix by optimizing the messages printed.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>  drivers/tty/serdev/core.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> index 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644
> --- a/drivers/tty/serdev/core.c
> +++ b/drivers/tty/serdev/core.c
> @@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
>
>         err = device_add(&serdev->dev);
>         if (err < 0) {
> -               dev_err(&serdev->dev, "Can't add %s, status %pe\n",
> -                       dev_name(&serdev->dev), ERR_PTR(err));
> +               dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
> +                       ERR_PTR(err));
>                 goto err_clear_serdev;
>         }
>
> -       dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev));
> +       dev_dbg(&serdev->dev, "serdev registered successfully\n");
>
>         return 0;
>
> @@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
>                 goto err_rpm_disable;
>         }
>
> -       dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
> -               dev_name(&ctrl->dev), &ctrl->dev);

I don't understand why you add dev_name() and then turn around and
remove it in the next patch. Just squash the patches.

> +       dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n",
> +               &ctrl->dev);
>         return 0;
>
>  err_rpm_disable:
>
> --
> 2.34.1
>

Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

Posted by Zijun Hu 9 months, 2 weeks ago

On 2025/4/25 02:34, Rob Herring wrote:
>> @@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
>>                 goto err_rpm_disable;
>>         }
>>
>> -       dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
>> -               dev_name(&ctrl->dev), &ctrl->dev);
> I don't understand why you add dev_name() and then turn around and
> remove it in the next patch. Just squash the patches.

okay, will do it in next revision.