[PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property

Kory Maincent posted 5 patches 7 months, 3 weeks ago
[PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property
Posted by Kory Maincent 7 months, 3 weeks ago
Add the data-lanes property to specify the number of DSI lanes used by the
panel. This allows configuring the panel for either two, three or four
lanes.

At the same time, extend the devicetree example with an endpoint node for
better clarity.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v2:
- Use data-lanes property from video-interfaces.yaml
- Add endpoint description example
---
 .../bindings/display/panel/ilitek,ili9881c.yaml      | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
index baf5dfe5f5ebdd92f460a78d0e56e1b45e7dd323..3a897e464178dfc8a7c70e0fafb51184c50a520b 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
@@ -27,6 +27,20 @@ properties:
   reg:
     maxItems: 1
 
+  port:
+    $ref: /schemas/graph.yaml#/$defs/port-base
+    unevaluatedProperties: false
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          data-lanes:
+            minItems: 1
+            maxItems: 4
+
   backlight: true
   power-supply: true
   reset-gpios: true
@@ -53,6 +67,12 @@ examples:
             power-supply = <&reg_display>;
             reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */
             backlight = <&pwm_bl>;
+            port {
+                panel_in: endpoint {
+                    remote-endpoint = <&dsi_out>;
+                    data-lanes = <1 2>;
+                };
+            };
         };
     };
 

-- 
2.34.1
Re: [PATCH RFC v2 2/5] dt-bindings: display: panel: ili9881c: Add data-lanes property
Posted by Krzysztof Kozlowski 7 months, 3 weeks ago
On Thu, Apr 24, 2025 at 05:07:40PM GMT, Kory Maincent wrote:
> Add the data-lanes property to specify the number of DSI lanes used by the
> panel. This allows configuring the panel for either two, three or four
> lanes.

That's the property of DSI controller, not the panel. I do not
understand why this is different than every other panel binding and your
commit msg should explain that. If you do something than everyone else
it is a clear hint you need to explain that.

Best regards,
Krzysztof