[v1] libbpf: remove sample_period init in perf_buffer

[PATCH bpf-next] libbpf: remove sample_period init in perf_buffer

Posted by Tao Chen 7 months, 4 weeks ago

It seems that sample_period no used in perf buffer, actually only
wakeup_events valid about events aggregation for wakeup. So remove
it to avoid causing confusion.

Fixes: fb84b8224655 ("libbpf: add perf buffer API")
Acked-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Tao Chen <chen.dylane@linux.dev>
---
 tools/lib/bpf/libbpf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 194809da5172..1830e3c011a5 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -13306,7 +13306,6 @@ struct perf_buffer *perf_buffer__new(int map_fd, size_t page_cnt,
 	attr.config = PERF_COUNT_SW_BPF_OUTPUT;
 	attr.type = PERF_TYPE_SOFTWARE;
 	attr.sample_type = PERF_SAMPLE_RAW;
-	attr.sample_period = sample_period;
 	attr.wakeup_events = sample_period;
 
 	p.attr = &attr;
-- 
2.43.0

Re: [PATCH bpf-next] libbpf: remove sample_period init in perf_buffer

Posted by Tao Chen 7 months, 3 weeks ago

在 2025/4/24 00:39, Tao Chen 写道:

ping...

> It seems that sample_period no used in perf buffer, actually only
> wakeup_events valid about events aggregation for wakeup. So remove
> it to avoid causing confusion.
> 
> Fixes: fb84b8224655 ("libbpf: add perf buffer API")
> Acked-by: Jiri Olsa <jolsa@kernel.org>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Tao Chen <chen.dylane@linux.dev>
> ---
>   tools/lib/bpf/libbpf.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 194809da5172..1830e3c011a5 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -13306,7 +13306,6 @@ struct perf_buffer *perf_buffer__new(int map_fd, size_t page_cnt,
>   	attr.config = PERF_COUNT_SW_BPF_OUTPUT;
>   	attr.type = PERF_TYPE_SOFTWARE;
>   	attr.sample_type = PERF_SAMPLE_RAW;
> -	attr.sample_period = sample_period;
>   	attr.wakeup_events = sample_period;
>   
>   	p.attr = &attr;


-- 
Best Regards
Tao Chen

Re: [PATCH bpf-next] libbpf: remove sample_period init in perf_buffer

Posted by Yafang Shao 7 months, 3 weeks ago

On Tue, Apr 29, 2025 at 1:48 PM Tao Chen <chen.dylane@linux.dev> wrote:
>
> 在 2025/4/24 00:39, Tao Chen 写道:
>
> ping...

The patch has already been accepted and merged into bpf-next:
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=64821d25f05ac468d435e61669ae745ce5a633ea

Interestingly, patchwork-bot+netdevbpf@kernel.org didn't send a
notification about this.

You can check the current status of your patches on Patchwork:
https://patchwork.kernel.org/project/netdevbpf/list/?delegate=121173&state=*


-- 
Regards
Yafang

Re: [PATCH bpf-next] libbpf: remove sample_period init in perf_buffer

Posted by Andrii Nakryiko 7 months, 3 weeks ago

On Mon, Apr 28, 2025 at 11:19 PM Yafang Shao <laoar.shao@gmail.com> wrote:
>
> On Tue, Apr 29, 2025 at 1:48 PM Tao Chen <chen.dylane@linux.dev> wrote:
> >
> > 在 2025/4/24 00:39, Tao Chen 写道:
> >
> > ping...
>
> The patch has already been accepted and merged into bpf-next:
> https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=64821d25f05ac468d435e61669ae745ce5a633ea
>
> Interestingly, patchwork-bot+netdevbpf@kernel.org didn't send a
> notification about this.

Yeah, we had a day or two of patchwork not working. The patch was
applied. Sorry, I forgot to reply manually to let everyone know.

>
> You can check the current status of your patches on Patchwork:
> https://patchwork.kernel.org/project/netdevbpf/list/?delegate=121173&state=*
>
>
> --
> Regards
> Yafang