@Ilpos you can ignore my small question from my last e-mail. The spec file
of the firmware wants the struct to be zeroed (albeit it does also work if
not) so I implemented it like that.

v2: - Integrated Armins feedback and fixed kernel test robot warnings.
v3: - Fixed borked subject line of v2.
v4: - Remove unrequired WMI mutex.
    - Move device checking from probe to init.
    - Fix device checking working exactly reverse as it should.
    - Fix null pointer dereference because,
        hdev->driver_data != hdev->dev.driver_data.
v5: - Move everything to subfolder nb04 in preparation for the eventual
        upstreaming of other tuxedo-driver parts.
    - Integrated Ilpos coding style feedback.
    - Use dev_set/get_drvdata() based on Armins feedback.
v6: - Integrated more of Ilpo coding style feedback from a different LKML
        patch-thread (less files, local functions prefixed with a short
        string).
v7: - Integrated more of Ilpos feedback e.g.:
        - Use cleanup.h
        - replace some if cases with a pointer in driver_data
        - coding style oversights
v8: - Integrated more of Ilpos feedback
    - Typo fix spotted by Alok

Werner Sembach (1):
  platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

 MAINTAINERS                                 |   6 +
 drivers/platform/x86/Kconfig                |   2 +
 drivers/platform/x86/Makefile               |   3 +
 drivers/platform/x86/tuxedo/Kconfig         |   8 +
 drivers/platform/x86/tuxedo/Makefile        |   8 +
 drivers/platform/x86/tuxedo/nb04/Kconfig    |  15 +
 drivers/platform/x86/tuxedo/nb04/Makefile   |  10 +
 drivers/platform/x86/tuxedo/nb04/wmi_ab.c   | 916 ++++++++++++++++++++
 drivers/platform/x86/tuxedo/nb04/wmi_util.c |  91 ++
 drivers/platform/x86/tuxedo/nb04/wmi_util.h | 109 +++
 10 files changed, 1168 insertions(+)
 create mode 100644 drivers/platform/x86/tuxedo/Kconfig
 create mode 100644 drivers/platform/x86/tuxedo/Makefile
 create mode 100644 drivers/platform/x86/tuxedo/nb04/Kconfig
 create mode 100644 drivers/platform/x86/tuxedo/nb04/Makefile
 create mode 100644 drivers/platform/x86/tuxedo/nb04/wmi_ab.c
 create mode 100644 drivers/platform/x86/tuxedo/nb04/wmi_util.c
 create mode 100644 drivers/platform/x86/tuxedo/nb04/wmi_util.h

-- 
2.43.0

On Wed 2025-04-23 17:33:09, Werner Sembach wrote:
> @Ilpos you can ignore my small question from my last e-mail. The spec file
> of the firmware wants the struct to be zeroed (albeit it does also work if
> not) so I implemented it like that.

You forgot to cc me.

Anyway, lets not do this. Kernel should have real interfaces, not
crazy tables to emulate Microsoft interface noone else uses.

NAK.

									Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, and Musk!

Hi,

Am 26.04.25 um 10:17 schrieb Pavel Machek:
> On Wed 2025-04-23 17:33:09, Werner Sembach wrote:
>> @Ilpos you can ignore my small question from my last e-mail. The spec file
>> of the firmware wants the struct to be zeroed (albeit it does also work if
>> not) so I implemented it like that.
> You forgot to cc me.
>
> Anyway, lets not do this. Kernel should have real interfaces, not
> crazy tables to emulate Microsoft interface noone else uses.

The HID standard is not a "Microsoft interface noone else uses."

Best regards,

Werner

>
> NAK.
>
> 									Pavel