[PATCH net v2 0/3] net: stmmac: socfpga: 1000BaseX support and cleanups

Maxime Chevallier posted 3 patches 8 months ago
There is a newer version of this series
.../net/ethernet/stmicro/stmmac/dwmac-socfpga.c   | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
[PATCH net v2 0/3] net: stmmac: socfpga: 1000BaseX support and cleanups
Posted by Maxime Chevallier 8 months ago
Hello everyone,

This small series sorts-out 1000BaseX support and does a bit of cleanup
for the Lynx conversion.

Patch 1 makes sure that we set the right phy_mode when working in
1000BaseX mode, so that the internal GMII is configured correctly.

Patch 2 removes a check for phy_device upon calling fix_mac_speed(). As
the SGMII adapter may be chained to a Lynx PCS, checking for a
phy_device to be attached to the netdev before enabling the SGMII
adapter doesn't make sense, as we won't have a downstream PHY when using
1000BaseX.

Patch 3 cleans an unused field from the PCS conversion.

Changes in V2: 
 - Added Russell's review tags
 - Reworked patch 2 to check for phy_interface when configuring the
   adapter, as suggested by Russell.

V1: https://lore.kernel.org/netdev/20250422094701.49798-1-maxime.chevallier@bootlin.com/

Maxime Chevallier (3):
  net: stmmac: socfpga: Enable internal GMII when using 1000BaseX
  net: stmmac: socfpga: Don't check for phy to enable the SGMII adapter
  net: stmmac: socfpga: Remove unused pcs-mdiodev field

 .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c   | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

-- 
2.49.0
Re: [PATCH net v2 0/3] net: stmmac: socfpga: 1000BaseX support and cleanups
Posted by Maxime Chevallier 8 months ago
On Wed, 23 Apr 2025 12:46:42 +0200
Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:

Hi,

> Hello everyone,
> 
> This small series sorts-out 1000BaseX support and does a bit of cleanup
> for the Lynx conversion.
> 
> Patch 1 makes sure that we set the right phy_mode when working in
> 1000BaseX mode, so that the internal GMII is configured correctly.
> 
> Patch 2 removes a check for phy_device upon calling fix_mac_speed(). As
> the SGMII adapter may be chained to a Lynx PCS, checking for a
> phy_device to be attached to the netdev before enabling the SGMII
> adapter doesn't make sense, as we won't have a downstream PHY when using
> 1000BaseX.
> 
> Patch 3 cleans an unused field from the PCS conversion.

I mixed-up my command while generating this series, it targets net-next
and not net...

I'll respin tomorrow with the proper destination tree, sorry about that.

Maxime