On 2025-04-23 10:28 AM, Philipp Stanner wrote:
> Changes in v2:
> - sof: simplify return. (Andy)
> - intel/atom: simplify return. (Andy)
> - Send a separate series for AsoC. (Andy)
> - intel/atom: Add another patch that switches EINVAL to ENOMEM. (Andy)
>
> Hi,
>
> a year ago we spent quite some work trying to get PCI into better shape.
> Some pci_ functions can be sometimes managed with devres, which is
> obviously bad. We want to provide an obvious API, where pci_ functions
> are never, and pcim_ functions are always managed.
>
> Thus, everyone enabling his device with pcim_enable_device() must be
> ported to pcim_ functions. Porting all users will later enable us to
> significantly simplify parts of the PCI subsystem. See here [1] for
> details.
>
> This patch series does that for sound.
>
> Feel free to squash the commits as you see fit.
>
> P.
>
> [1] https://elixir.bootlin.com/linux/v6.14-rc4/source/drivers/pci/devres.c#L18
>
> Philipp Stanner (4):
> ASoC: sof: Use pure devres PCI
> ASoC: intel/avs: Use pure devres PCI
> AsoC: intel/atom: Use pure devres PCI
> AsoC: intel/atom: Return -ENOMEM if pcim_iomap() fails
Nitpick: the scopes used in commit titles do not match recommendations.
Below the suggested ones:
'ASoC: Intel: atom:' for the atom-driver
'ASoC: Intel: avs:' for the avs-driver
> sound/soc/intel/atom/sst/sst_pci.c | 58 +++++++++++++-----------------
> sound/soc/intel/avs/core.c | 7 ++--
> sound/soc/sof/sof-pci-dev.c | 16 ++-------
> 3 files changed, 29 insertions(+), 52 deletions(-)
>
Hi Philipp,
Thank you for the contribution. I do not see any major issues so feel
free to add:
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Kind Regards,
Czarek