1. Patchew
  2. linux
  3. View series

[PATCH 0/6] arm64: dts: qcom: x1*: Fix vreg_l2j_1p2 voltage

Stephan Gerhold posted 6 patches 8 months ago 
arch/arm64/boot/dts/qcom/x1-crd.dtsi                     | 4 ++--
arch/arm64/boot/dts/qcom/x1e001de-devkit.dts             | 4 ++--
arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts  | 4 ++--
arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts    | 4 ++--
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 4 ++--
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                | 4 ++--
6 files changed, 12 insertions(+), 12 deletions(-)
[PATCH 0/6] arm64: dts: qcom: x1*: Fix vreg_l2j_1p2 voltage
Posted by Stephan Gerhold 8 months ago 
Several of the Qualcomm X1* device trees upstream specify the wrong voltage
for the L2J regulator. In the ACPI DSDT table, PPP_RESOURCE_ID_LDO2_J is
configured with 1256000 uV instead of the 1200000 uV. Change all affected
device trees to use the same for consistency and correctness.

In the other device trees upstream, the voltage is already correct:
 - x1e78100-lenovo-thinkpad-t14s.dtsi
 - x1e80100-dell-xps13-9345.dts
 - x1e80100-microsoft-romulus.dtsi

Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
Stephan Gerhold (6):
      arm64: dts: qcom: x1-crd: Fix vreg_l2j_1p2 voltage
      arm64: dts: qcom: x1e001de-devkit: Fix vreg_l2j_1p2 voltage
      arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix vreg_l2j_1p2 voltage
      arm64: dts: qcom: x1e80100-hp-omnibook-x14: Fix vreg_l2j_1p2 voltage
      arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix vreg_l2j_1p2 voltage
      arm64: dts: qcom: x1e80100-qcp: Fix vreg_l2j_1p2 voltage

 arch/arm64/boot/dts/qcom/x1-crd.dtsi                     | 4 ++--
 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts             | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts  | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts    | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 4 ++--
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                | 4 ++--
 6 files changed, 12 insertions(+), 12 deletions(-)
---
base-commit: 39155a896925c3af2156ad61e821aa9fa5a1dbdb
change-id: 20250422-x1e-vreg-l2j-voltage-4281dd747278

Best regards,
-- 
Stephan Gerhold <stephan.gerhold@linaro.org>
Re: [PATCH 0/6] arm64: dts: qcom: x1*: Fix vreg_l2j_1p2 voltage
Posted by Bjorn Andersson 7 months, 2 weeks ago 
On Wed, 23 Apr 2025 09:30:06 +0200, Stephan Gerhold wrote:
> Several of the Qualcomm X1* device trees upstream specify the wrong voltage
> for the L2J regulator. In the ACPI DSDT table, PPP_RESOURCE_ID_LDO2_J is
> configured with 1256000 uV instead of the 1200000 uV. Change all affected
> device trees to use the same for consistency and correctness.
> 
> In the other device trees upstream, the voltage is already correct:
>  - x1e78100-lenovo-thinkpad-t14s.dtsi
>  - x1e80100-dell-xps13-9345.dts
>  - x1e80100-microsoft-romulus.dtsi
> 
> [...]

Applied, thanks!

[1/6] arm64: dts: qcom: x1-crd: Fix vreg_l2j_1p2 voltage
      commit: 5ce920e6a8db40e4b094c0d863cbd19fdcfbbb7a
[2/6] arm64: dts: qcom: x1e001de-devkit: Fix vreg_l2j_1p2 voltage
      commit: 3ed2a9e03abfeece9e30ebc746f935536f661414
[3/6] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix vreg_l2j_1p2 voltage
      commit: 0fb9ecf8713a7a458f7378c86e0703467db2ad22
[4/6] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Fix vreg_l2j_1p2 voltage
      commit: 4a09dad9d437a13e9cd4383ff7791a816a6e1652
[5/6] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix vreg_l2j_1p2 voltage
      commit: 4f27ede34ca3369cdcde80c5a4ca84cdb28edbbb
[6/6] arm64: dts: qcom: x1e80100-qcp: Fix vreg_l2j_1p2 voltage
      commit: efdbeae860bf0278b050c6c9ad5921afba4596d0

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH 0/6] arm64: dts: qcom: x1*: Fix vreg_l2j_1p2 voltage
Posted by Johan Hovold 7 months, 3 weeks ago 
On Wed, Apr 23, 2025 at 09:30:06AM +0200, Stephan Gerhold wrote:
> Several of the Qualcomm X1* device trees upstream specify the wrong voltage
> for the L2J regulator. In the ACPI DSDT table, PPP_RESOURCE_ID_LDO2_J is
> configured with 1256000 uV instead of the 1200000 uV. Change all affected
> device trees to use the same for consistency and correctness.
> 
> In the other device trees upstream, the voltage is already correct:
>  - x1e78100-lenovo-thinkpad-t14s.dtsi
>  - x1e80100-dell-xps13-9345.dts
>  - x1e80100-microsoft-romulus.dtsi
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
> Stephan Gerhold (6):
>       arm64: dts: qcom: x1-crd: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e001de-devkit: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e80100-hp-omnibook-x14: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e80100-qcp: Fix vreg_l2j_1p2 voltage

I only checked the CRD (and T14s) DSDT, but this looks correct:

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Re: [PATCH 0/6] arm64: dts: qcom: x1*: Fix vreg_l2j_1p2 voltage
Posted by Abel Vesa 7 months, 4 weeks ago 
On 25-04-23 09:30:06, Stephan Gerhold wrote:
> Several of the Qualcomm X1* device trees upstream specify the wrong voltage
> for the L2J regulator. In the ACPI DSDT table, PPP_RESOURCE_ID_LDO2_J is
> configured with 1256000 uV instead of the 1200000 uV. Change all affected
> device trees to use the same for consistency and correctness.
> 
> In the other device trees upstream, the voltage is already correct:
>  - x1e78100-lenovo-thinkpad-t14s.dtsi
>  - x1e80100-dell-xps13-9345.dts
>  - x1e80100-microsoft-romulus.dtsi
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Re: [PATCH 0/6] arm64: dts: qcom: x1*: Fix vreg_l2j_1p2 voltage
Posted by Konrad Dybcio 8 months ago 
On 4/23/25 9:30 AM, Stephan Gerhold wrote:
> Several of the Qualcomm X1* device trees upstream specify the wrong voltage
> for the L2J regulator. In the ACPI DSDT table, PPP_RESOURCE_ID_LDO2_J is
> configured with 1256000 uV instead of the 1200000 uV. Change all affected
> device trees to use the same for consistency and correctness.
> 
> In the other device trees upstream, the voltage is already correct:
>  - x1e78100-lenovo-thinkpad-t14s.dtsi
>  - x1e80100-dell-xps13-9345.dts
>  - x1e80100-microsoft-romulus.dtsi
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
> ---
> Stephan Gerhold (6):
>       arm64: dts: qcom: x1-crd: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e001de-devkit: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e80100-hp-omnibook-x14: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Fix vreg_l2j_1p2 voltage
>       arm64: dts: qcom: x1e80100-qcp: Fix vreg_l2j_1p2 voltage

This goes to some PHYs, so it better match what it's supposed to!

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.