[PATCH v3 0/3] Apple PMIC NVMEM cell driver (Formerly: Generic SPMI NVMEM cell driver)

Sasha Finkelstein via B4 Relay posted 3 patches 9 months, 2 weeks ago
.../bindings/nvmem/apple,spmi-nvmem.yaml           | 54 +++++++++++++++++++
MAINTAINERS                                        |  2 +
arch/arm64/boot/dts/apple/t6001.dtsi               |  1 +
arch/arm64/boot/dts/apple/t6002.dtsi               |  1 +
arch/arm64/boot/dts/apple/t600x-die0.dtsi          | 50 +++++++++++++++++
arch/arm64/boot/dts/apple/t8103.dtsi               | 50 +++++++++++++++++
arch/arm64/boot/dts/apple/t8112.dtsi               | 50 +++++++++++++++++
drivers/nvmem/Kconfig                              | 13 +++++
drivers/nvmem/Makefile                             |  2 +
drivers/nvmem/apple-spmi-nvmem.c                   | 62 ++++++++++++++++++++++
10 files changed, 285 insertions(+)
[PATCH v3 0/3] Apple PMIC NVMEM cell driver (Formerly: Generic SPMI NVMEM cell driver)
Posted by Sasha Finkelstein via B4 Relay 9 months, 2 weeks ago
Hi.

This patch series adds a driver for exposing a set of registers
as NVMEM cells on a SPMI-attached PMIC on Apple ARM platforms.
Those are used to store the RTC offset and to communicate platform
power state between the OS and boot firmware.

The NVMEM cell consumer drivers will be sent in a further series.

Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
---
Changes in v3:
- No longer try to make it generic, use for the 3 relevant PMICs only
- Link to v2: https://lore.kernel.org/r/20250417-spmi-nvmem-v2-0-b88851e34afb@gmail.com

Changes in v2:
- s/pmu/pmic/
- Sort dts in unit-order, instead of t600x-unit-order
- Link to v1: https://lore.kernel.org/r/20250415-spmi-nvmem-v1-0-22067be253cf@gmail.com

---
Hector Martin (2):
      nvmem: Add apple-spmi-nvmem driver
      arm64: dts: apple: Add PMIC NVMEM

Sasha Finkelstein (1):
      dt-bindings: spmi: Add Apple SPMI NVMEM

 .../bindings/nvmem/apple,spmi-nvmem.yaml           | 54 +++++++++++++++++++
 MAINTAINERS                                        |  2 +
 arch/arm64/boot/dts/apple/t6001.dtsi               |  1 +
 arch/arm64/boot/dts/apple/t6002.dtsi               |  1 +
 arch/arm64/boot/dts/apple/t600x-die0.dtsi          | 50 +++++++++++++++++
 arch/arm64/boot/dts/apple/t8103.dtsi               | 50 +++++++++++++++++
 arch/arm64/boot/dts/apple/t8112.dtsi               | 50 +++++++++++++++++
 drivers/nvmem/Kconfig                              | 13 +++++
 drivers/nvmem/Makefile                             |  2 +
 drivers/nvmem/apple-spmi-nvmem.c                   | 62 ++++++++++++++++++++++
 10 files changed, 285 insertions(+)
---
base-commit: 2e0e70c95077172b29a5b13716c4b159d578e82c
change-id: 20250415-spmi-nvmem-e08635316175

Best regards,
-- 
Sasha Finkelstein <fnkl.kernel@gmail.com>
Re: [PATCH v3 0/3] Apple PMIC NVMEM cell driver (Formerly: Generic SPMI NVMEM cell driver)
Posted by Neal Gompa 9 months, 2 weeks ago
On Wed, Apr 23, 2025 at 1:55 PM Sasha Finkelstein via B4 Relay
<devnull+fnkl.kernel.gmail.com@kernel.org> wrote:
>
> Hi.
>
> This patch series adds a driver for exposing a set of registers
> as NVMEM cells on a SPMI-attached PMIC on Apple ARM platforms.
> Those are used to store the RTC offset and to communicate platform
> power state between the OS and boot firmware.
>
> The NVMEM cell consumer drivers will be sent in a further series.
>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> ---
> Changes in v3:
> - No longer try to make it generic, use for the 3 relevant PMICs only
> - Link to v2: https://lore.kernel.org/r/20250417-spmi-nvmem-v2-0-b88851e34afb@gmail.com
>
> Changes in v2:
> - s/pmu/pmic/
> - Sort dts in unit-order, instead of t600x-unit-order
> - Link to v1: https://lore.kernel.org/r/20250415-spmi-nvmem-v1-0-22067be253cf@gmail.com
>
> ---
> Hector Martin (2):
>       nvmem: Add apple-spmi-nvmem driver
>       arm64: dts: apple: Add PMIC NVMEM
>
> Sasha Finkelstein (1):
>       dt-bindings: spmi: Add Apple SPMI NVMEM
>
>  .../bindings/nvmem/apple,spmi-nvmem.yaml           | 54 +++++++++++++++++++
>  MAINTAINERS                                        |  2 +
>  arch/arm64/boot/dts/apple/t6001.dtsi               |  1 +
>  arch/arm64/boot/dts/apple/t6002.dtsi               |  1 +
>  arch/arm64/boot/dts/apple/t600x-die0.dtsi          | 50 +++++++++++++++++
>  arch/arm64/boot/dts/apple/t8103.dtsi               | 50 +++++++++++++++++
>  arch/arm64/boot/dts/apple/t8112.dtsi               | 50 +++++++++++++++++
>  drivers/nvmem/Kconfig                              | 13 +++++
>  drivers/nvmem/Makefile                             |  2 +
>  drivers/nvmem/apple-spmi-nvmem.c                   | 62 ++++++++++++++++++++++
>  10 files changed, 285 insertions(+)
> ---
> base-commit: 2e0e70c95077172b29a5b13716c4b159d578e82c
> change-id: 20250415-spmi-nvmem-e08635316175
>

Series LGTM.

Reviewed-by: Neal Gompa <neal@gompa.dev>


-- 
真実はいつも一つ!/ Always, there's only one truth!
Re: (subset) [PATCH v3 0/3] Apple PMIC NVMEM cell driver (Formerly: Generic SPMI NVMEM cell driver)
Posted by Sven Peter 9 months, 1 week ago
On Wed, 23 Apr 2025 19:55:12 +0200, Sasha Finkelstein wrote:
> This patch series adds a driver for exposing a set of registers
> as NVMEM cells on a SPMI-attached PMIC on Apple ARM platforms.
> Those are used to store the RTC offset and to communicate platform
> power state between the OS and boot firmware.
> 
> The NVMEM cell consumer drivers will be sent in a further series.
> 
> [...]

Applied to git@github.com:AsahiLinux/linux.git (asahi-soc/dt), thanks!

[3/3] arm64: dts: apple: Add PMIC NVMEM
      https://github.com/AsahiLinux/linux/commit/d8bf82081c9e

Best regards,
-- 
Sven Peter <sven@svenpeter.dev>
Re: (subset) [PATCH v3 0/3] Apple PMIC NVMEM cell driver (Formerly: Generic SPMI NVMEM cell driver)
Posted by Srinivas Kandagatla 9 months, 1 week ago
On Wed, 23 Apr 2025 19:55:12 +0200, Sasha Finkelstein wrote:
> This patch series adds a driver for exposing a set of registers
> as NVMEM cells on a SPMI-attached PMIC on Apple ARM platforms.
> Those are used to store the RTC offset and to communicate platform
> power state between the OS and boot firmware.
> 
> The NVMEM cell consumer drivers will be sent in a further series.
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: spmi: Add Apple SPMI NVMEM
      commit: 342ad99689be22776c50ab5d82064b700e516a98
[2/3] nvmem: Add apple-spmi-nvmem driver
      commit: 8d2900cc141122ad3a754d6d86cd15a9a4bf0b74

Best regards,
-- 
Srinivas Kandagatla <srini@kernel.org>