This is a spin-off from my mwifiex cleanup series. I have split the
original single patch into a series which hopefully makes the changes
easier to follow and verify.

Sascha

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
Changes in v2:
- squashed fixup sent separately into series
- Fix some checkpatch warnings in commit messages
- Add Acked-by tags from Brian Norris
- Add Reviewed-by tags from Francesco Dolcini
- Link to v1: https://lore.kernel.org/r/20250410-mwifiex-drop-asynchronous-init-v1-0-6a212fa9185e@pengutronix.de

---
Sascha Hauer (4):
      wifi: mwifiex: remove unnecessary queue empty check
      wifi: mwifiex: let mwifiex_init_fw() return 0 for success
      wifi: mwifiex: drop asynchronous init waiting code
      wifi: mwifiex: remove mwifiex_sta_init_cmd() last argument

 drivers/net/wireless/marvell/mwifiex/cfg80211.c |  8 ++++----
 drivers/net/wireless/marvell/mwifiex/cmdevt.c   | 16 ----------------
 drivers/net/wireless/marvell/mwifiex/init.c     | 21 ++++++++-------------
 drivers/net/wireless/marvell/mwifiex/main.c     | 25 +++----------------------
 drivers/net/wireless/marvell/mwifiex/main.h     |  8 +-------
 drivers/net/wireless/marvell/mwifiex/sta_cmd.c  |  8 +-------
 drivers/net/wireless/marvell/mwifiex/util.c     | 18 ------------------
 7 files changed, 17 insertions(+), 87 deletions(-)
---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250410-mwifiex-drop-asynchronous-init-a1f2339095a7

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>

On Wed, 2025-04-23 at 10:21 +0200, Sascha Hauer wrote:
> This is a spin-off from my mwifiex cleanup series. I have split the
> original single patch into a series which hopefully makes the changes
> easier to follow and verify.
> 

I'm applying this, but I removed a now unused variable in the first
patch that you only removed in the third. I guess that comment might've
gone into the wrong patch too.

Please, everyone, especially when resubmitting look at patchwork first,
there's a reason I put the bot there :)


In this case the issue was already in v1:

https://patchwork.kernel.org/project/linux-wireless/patch/20250410-mwifiex-drop-asynchronous-init-v1-1-6a212fa9185e@pengutronix.de/

->
http://wifibot.sipsolutions.net/results/951965/14046284/build_clang/summary

[...]
New errors added
--- /tmp/tmp.KVymmMae73	2025-04-10 15:54:35.187566833 +0300
+++ /tmp/tmp.xeV1sgB9ae	2025-04-10 15:54:51.973439711 +0300
@@ -17,0 +18,4 @@
+../drivers/net/wireless/marvell/mwifiex/init.c:490:6: warning: unused variable 'is_cmd_pend_q_empty' [-Wunused-variable]
+  490 |         int is_cmd_pend_q_empty;
+      |             ^~~~~~~~~~~~~~~~~~~
+1 warning generated.
Per-file breakdown
--- /tmp/tmp.LJz16ltpSv	2025-04-10 15:54:51.980439658 +0300
+++ /tmp/tmp.5qRbEVE9cC	2025-04-10 15:54:51.983439635 +0300
@@ -0,0 +1 @@
+      1 ../drivers/net/wireless/marvell/mwifiex/init.c

johannes

On Wed, Apr 23, 2025 at 03:42:32PM +0200, Johannes Berg wrote:
> On Wed, 2025-04-23 at 10:21 +0200, Sascha Hauer wrote:
> > This is a spin-off from my mwifiex cleanup series. I have split the
> > original single patch into a series which hopefully makes the changes
> > easier to follow and verify.
> > 
> 
> I'm applying this, but I removed a now unused variable in the first
> patch that you only removed in the third. I guess that comment might've
> gone into the wrong patch too.
> 
> Please, everyone, especially when resubmitting look at patchwork first,
> there's a reason I put the bot there :)

As an occasional WiFi developer I wasn't aware of this. Now that I am
I'll look there next time.

Thanks for fixing.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |