[v3] rust: list: remove HasListLinks::OFFSET

[PATCH v3 0/6] rust: list: remove HasListLinks::OFFSET

Posted by Tamir Duberstein 7 months, 4 weeks ago

The bulk of this change occurs in the last commit, please its commit
messages for details.

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
Changes in v3:
- Add a patch to improve macro hygiene.
- Add a patch to include examples for all macros.
- Make it build properly!
- Link to v2: https://lore.kernel.org/r/20250409-list-no-offset-v2-0-0bab7e3c9fd8@gmail.com

Changes in v2:
- Change type parameter delimiter to `{}` for consistency. (Boqun Feng)
- Rebase on v6.15-rc1.
- Extract first commit to its own series as it is shared with other
  series.
- Link to v1: https://lore.kernel.org/r/20250324-list-no-offset-v1-0-afd2b7fc442a@gmail.com

---
Tamir Duberstein (6):
      rust: list: simplify macro capture
      rust: list: use consistent type parameter style
      rust: list: use consistent self parameter name
      rust: list: use fully qualified path
      rust: list: add `impl_list_item!` examples
      rust: list: remove OFFSET constants

 rust/kernel/list.rs                    |  18 ++-
 rust/kernel/list/impl_list_item_mod.rs | 233 ++++++++++++++++++++++-----------
 2 files changed, 165 insertions(+), 86 deletions(-)
---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250324-list-no-offset-96ef65cb2a95
prerequisite-change-id: 20250409-container-of-mutness-b153dab4388d:v1
prerequisite-patch-id: 53d5889db599267f87642bb0ae3063c29bc24863

Best regards,
-- 
Tamir Duberstein <tamird@gmail.com>

Re: [PATCH v3 0/6] rust: list: remove HasListLinks::OFFSET

Posted by Alice Ryhl 5 months, 1 week ago

On Wed, Apr 23, 2025 at 6:30 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> The bulk of this change occurs in the last commit, please its commit
> messages for details.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH v3 0/6] rust: list: remove HasListLinks::OFFSET

Posted by Alice Ryhl 7 months, 4 weeks ago

On Wed, Apr 23, 2025 at 12:30:01PM -0400, Tamir Duberstein wrote:
> The bulk of this change occurs in the last commit, please its commit
> messages for details.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

This works with Rust Binder and Ashmem.

Tested-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH v3 0/6] rust: list: remove HasListLinks::OFFSET

Posted by Tamir Duberstein 6 months, 1 week ago

On Wed, Apr 23, 2025 at 1:50 PM Alice Ryhl <aliceryhl@google.com> wrote:
>
> On Wed, Apr 23, 2025 at 12:30:01PM -0400, Tamir Duberstein wrote:
> > The bulk of this change occurs in the last commit, please its commit
> > messages for details.
> >
> > Signed-off-by: Tamir Duberstein <tamird@gmail.com>
>
> This works with Rust Binder and Ashmem.
>
> Tested-by: Alice Ryhl <aliceryhl@google.com>

Thanks Alice. Could you also review? I guess this still needs some
RBs. @Benno Lossin could you perhaps have a look as well? You both
reviewed my other series[0] which was quite similar.

[0] https://lore.kernel.org/all/20250411-no-offset-v3-1-c0b174640ec3@gmail.com/

Re: [PATCH v3 0/6] rust: list: remove HasListLinks::OFFSET

Posted by Benno Lossin 6 months ago

On Fri Jun 13, 2025 at 6:45 PM CEST, Tamir Duberstein wrote:
> On Wed, Apr 23, 2025 at 1:50 PM Alice Ryhl <aliceryhl@google.com> wrote:
>>
>> On Wed, Apr 23, 2025 at 12:30:01PM -0400, Tamir Duberstein wrote:
>> > The bulk of this change occurs in the last commit, please its commit
>> > messages for details.
>> >
>> > Signed-off-by: Tamir Duberstein <tamird@gmail.com>
>>
>> This works with Rust Binder and Ashmem.
>>
>> Tested-by: Alice Ryhl <aliceryhl@google.com>
>
> Thanks Alice. Could you also review? I guess this still needs some
> RBs. @Benno Lossin could you perhaps have a look as well? You both
> reviewed my other series[0] which was quite similar.
>
> [0] https://lore.kernel.org/all/20250411-no-offset-v3-1-c0b174640ec3@gmail.com/

I probably won't have time for this one.

---
Cheers,
Benno