ocfs2: remove unnecessary NULL check before unregister_sysctl_table()

[PATCH] ocfs2: remove unnecessary NULL check before unregister_sysctl_table()

Posted by Chen Ni 9 months, 3 weeks ago

unregister_sysctl_table() checks for NULL pointers internally.
Remove unneeded NULL check here.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/ocfs2/stackglue.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
index ddd761cf44c8..a28c127b9934 100644
--- a/fs/ocfs2/stackglue.c
+++ b/fs/ocfs2/stackglue.c
@@ -691,8 +691,7 @@ static void __exit ocfs2_stack_glue_exit(void)
 	memset(&locking_max_version, 0,
 	       sizeof(struct ocfs2_protocol_version));
 	ocfs2_sysfs_exit();
-	if (ocfs2_table_header)
-		unregister_sysctl_table(ocfs2_table_header);
+	unregister_sysctl_table(ocfs2_table_header);
 }
 
 MODULE_AUTHOR("Oracle");
-- 
2.25.1

Re: [PATCH] ocfs2: remove unnecessary NULL check before unregister_sysctl_table()

Posted by Joseph Qi 9 months, 2 weeks ago


On 2025/4/22 15:30, Chen Ni wrote:
> unregister_sysctl_table() checks for NULL pointers internally.
> Remove unneeded NULL check here.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
>  fs/ocfs2/stackglue.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
> index ddd761cf44c8..a28c127b9934 100644
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -691,8 +691,7 @@ static void __exit ocfs2_stack_glue_exit(void)
>  	memset(&locking_max_version, 0,
>  	       sizeof(struct ocfs2_protocol_version));
>  	ocfs2_sysfs_exit();
> -	if (ocfs2_table_header)
> -		unregister_sysctl_table(ocfs2_table_header);
> +	unregister_sysctl_table(ocfs2_table_header);
>  }
>  
>  MODULE_AUTHOR("Oracle");