iommu: apple-dart: Remove unnecessary NULL check before free_io_pgtable_ops()

[PATCH] iommu: apple-dart: Remove unnecessary NULL check before free_io_pgtable_ops()

Chen Ni posted 1 patch 7 months, 3 weeks ago

Download mbox

drivers/iommu/apple-dart.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] iommu: apple-dart: Remove unnecessary NULL check before free_io_pgtable_ops()

Posted by Chen Ni 7 months, 3 weeks ago

free_io_pgtable_ops() checks for NULL pointers internally.
Remove unneeded NULL check here.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/iommu/apple-dart.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
index e13501541fdd..757d24f67ad4 100644
--- a/drivers/iommu/apple-dart.c
+++ b/drivers/iommu/apple-dart.c
@@ -776,8 +776,7 @@ static void apple_dart_domain_free(struct iommu_domain *domain)
 {
 	struct apple_dart_domain *dart_domain = to_dart_domain(domain);
 
-	if (dart_domain->pgtbl_ops)
-		free_io_pgtable_ops(dart_domain->pgtbl_ops);
+	free_io_pgtable_ops(dart_domain->pgtbl_ops);
 
 	kfree(dart_domain);
 }
-- 
2.25.1

Re: [PATCH] iommu: apple-dart: Remove unnecessary NULL check before free_io_pgtable_ops()

Posted by Joerg Roedel 7 months, 2 weeks ago

On Tue, Apr 22, 2025 at 03:25:11PM +0800, Chen Ni wrote:
> free_io_pgtable_ops() checks for NULL pointers internally.
> Remove unneeded NULL check here.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/iommu/apple-dart.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.