[PATCH] powerpc: Replace strcpy() with strscpy() in proc_ppc64_init()

Thorsten Blum posted 1 patch 7 months, 3 weeks ago
arch/powerpc/kernel/proc_powerpc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] powerpc: Replace strcpy() with strscpy() in proc_ppc64_init()
Posted by Thorsten Blum 7 months, 3 weeks ago
strcpy() is deprecated; use strscpy() instead.

Don't cast the destination buffer from 'u8[]' to 'char *' to satisfy the
__must_be_array() requirement of strscpy().

No functional changes intended.

Link: https://github.com/KSPP/linux/issues/88
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/powerpc/kernel/proc_powerpc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/proc_powerpc.c b/arch/powerpc/kernel/proc_powerpc.c
index 3816a2bf2b84..d083b4517065 100644
--- a/arch/powerpc/kernel/proc_powerpc.c
+++ b/arch/powerpc/kernel/proc_powerpc.c
@@ -9,6 +9,7 @@
 #include <linux/proc_fs.h>
 #include <linux/kernel.h>
 #include <linux/of.h>
+#include <linux/string.h>
 
 #include <asm/machdep.h>
 #include <asm/vdso_datapage.h>
@@ -56,7 +57,7 @@ static int __init proc_ppc64_init(void)
 {
 	struct proc_dir_entry *pde;
 
-	strcpy((char *)systemcfg->eye_catcher, "SYSTEMCFG:PPC64");
+	strscpy(systemcfg->eye_catcher, "SYSTEMCFG:PPC64");
 	systemcfg->version.major = SYSTEMCFG_MAJOR;
 	systemcfg->version.minor = SYSTEMCFG_MINOR;
 	systemcfg->processor = mfspr(SPRN_PVR);
-- 
2.49.0
Re: [PATCH] powerpc: Replace strcpy() with strscpy() in proc_ppc64_init()
Posted by Madhavan Srinivasan 7 months ago
On Mon, 21 Apr 2025 20:31:08 +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
> 
> Don't cast the destination buffer from 'u8[]' to 'char *' to satisfy the
> __must_be_array() requirement of strscpy().
> 
> No functional changes intended.
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc: Replace strcpy() with strscpy() in proc_ppc64_init()
      https://git.kernel.org/powerpc/c/7e99a4a60d8fc9b24a3f9632011bf7e197f1aff9

Thanks