From: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>

Test correct structure member, ecc_cecnt_offset, before using it.

Fixes: 73bcc942f4271 ("EDAC, altera: Add Arria10 EDAC support")
Cc: stable@kernel.org
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>
Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
---
v2:
 - Improve commit message.
 - Add Fixes: and Cc: tags.
---
 drivers/edac/altera_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 3e971f902363..88d9d2f458ee 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -99,7 +99,7 @@ static irqreturn_t altr_sdram_mc_err_handler(int irq, void *dev_id)
 	if (status & priv->ecc_stat_ce_mask) {
 		regmap_read(drvdata->mc_vbase, priv->ecc_saddr_offset,
 			    &err_addr);
-		if (priv->ecc_uecnt_offset)
+		if (priv->ecc_cecnt_offset)
 			regmap_read(drvdata->mc_vbase,  priv->ecc_cecnt_offset,
 				    &err_count);
 		edac_mc_handle_error(HW_EVENT_ERR_CORRECTED, mci, err_count,
-- 
2.35.3

On 4/21/25 11:14, Matthew Gerlach wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>
> 
> Test correct structure member, ecc_cecnt_offset, before using it.
> 
> Fixes: 73bcc942f4271 ("EDAC, altera: Add Arria10 EDAC support")

Please just use a 12-digit HASH...

On 4/24/2025 3:53 PM, Dinh Nguyen wrote:
> 
> On 4/21/25 11:14, Matthew Gerlach wrote:
>> From: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>
>>
>> Test correct structure member, ecc_cecnt_offset, before using it.
>>
>> Fixes: 73bcc942f4271 ("EDAC, altera: Add Arria10 EDAC support")
> 
> Please just use a 12-digit HASH...

I cut 'n pasted from git blame. I will use a 12-digit HASH for Fixes: 
tag in v3.

Thanks for the review,
Matthew Geralch

>> Please just use a 12-digit HASH...
>
> I cut 'n pasted from git blame. I will use a 12-digit HASH for Fixes: 
> tag in v3.

Here's a useful alias I picked up (I think from Boris).  My ~/.gitconfig has
these lines:

[core]
	abbrev = 12
[alias]
	one = show -s --pretty='format:%h (\"%s\")'

So I can type this (with the 13 chars from git blame, or any other SHA1)

$ git one 73bcc942f4271
73bcc942f427 ("EDAC, altera: Add Arria10 EDAC support")

and get the canonical form to reference an earlier commit
in e-mail or git commit messages and tags.

-Tony