Patch 1 includes the initial fix.

Patch 2 refactors the code to use the out_altvoltage_powerdown ABI.

Patch 3 adds small improvements by minimizing the size of types and
doing a redundancy check.

Not sure whether to include a read function for powerdown as well since
all the other attributes only had write permissions. I can also do this
for the other attributes to help modernize the driver.

Changes in v3:
	- Include version log in cover letter.
Changes in v2:
	- Refactor and make small improvements ontop of the initial fix.

Gabriel Shahrouzi (3):
  iio: frequency: Use SLEEP bit instead of RESET to disable output
  staging: iio: ad9832: Refactor powerdown control
  staging: iio: ad9832: Add minor improvements to ad9832_write_powerdown

 drivers/staging/iio/frequency/ad9832.c | 50 ++++++++++++++++++--------
 1 file changed, 36 insertions(+), 14 deletions(-)

-- 
2.43.0

On Sun, Apr 20, 2025 at 01:54:16PM -0400, Gabriel Shahrouzi wrote:
> Patch 1 includes the initial fix.
> 
> Patch 2 refactors the code to use the out_altvoltage_powerdown ABI.
> 
> Patch 3 adds small improvements by minimizing the size of types and
> doing a redundancy check.
> 
> Not sure whether to include a read function for powerdown as well since
> all the other attributes only had write permissions. I can also do this
> for the other attributes to help modernize the driver.
> 
> Changes in v3:
> 	- Include version log in cover letter.

Please don't resend patches the same day.  Give us a chance to review
it otherwise it gets split across multiple threads.

regards,
dan carpenter

On Tue, Apr 22, 2025 at 6:09 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> On Sun, Apr 20, 2025 at 01:54:16PM -0400, Gabriel Shahrouzi wrote:
> > Patch 1 includes the initial fix.
> >
> > Patch 2 refactors the code to use the out_altvoltage_powerdown ABI.
> >
> > Patch 3 adds small improvements by minimizing the size of types and
> > doing a redundancy check.
> >
> > Not sure whether to include a read function for powerdown as well since
> > all the other attributes only had write permissions. I can also do this
> > for the other attributes to help modernize the driver.
> >
> > Changes in v3:
> >       - Include version log in cover letter.
>
> Please don't resend patches the same day.  Give us a chance to review
> it otherwise it gets split across multiple threads.
Noted, thanks.
>
> regards,
> dan carpenter
>

On Sun, 20 Apr 2025 13:54:16 -0400
Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote:

> Patch 1 includes the initial fix.
> 
> Patch 2 refactors the code to use the out_altvoltage_powerdown ABI.
> 
> Patch 3 adds small improvements by minimizing the size of types and
> doing a redundancy check.
> 
> Not sure whether to include a read function for powerdown as well since
> all the other attributes only had write permissions. I can also do this
> for the other attributes to help modernize the driver.
> 
> Changes in v3:
> 	- Include version log in cover letter.
Just post it in reply to that v2!

Note though that this needs a rebase as I mentioned in the thread wrt to
the original fix. I'll take a quick look though to see if I can spot
anything else for v4.

> Changes in v2:
> 	- Refactor and make small improvements ontop of the initial fix.
> 
> Gabriel Shahrouzi (3):
>   iio: frequency: Use SLEEP bit instead of RESET to disable output
>   staging: iio: ad9832: Refactor powerdown control
>   staging: iio: ad9832: Add minor improvements to ad9832_write_powerdown
> 
>  drivers/staging/iio/frequency/ad9832.c | 50 ++++++++++++++++++--------
>  1 file changed, 36 insertions(+), 14 deletions(-)
>

On Mon, Apr 21, 2025 at 7:33 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun, 20 Apr 2025 13:54:16 -0400
> Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote:
>
> > Patch 1 includes the initial fix.
> >
> > Patch 2 refactors the code to use the out_altvoltage_powerdown ABI.
> >
> > Patch 3 adds small improvements by minimizing the size of types and
> > doing a redundancy check.
> >
> > Not sure whether to include a read function for powerdown as well since
> > all the other attributes only had write permissions. I can also do this
> > for the other attributes to help modernize the driver.
> >
> > Changes in v3:
> >       - Include version log in cover letter.
> Just post it in reply to that v2!
Got it.
>
> Note though that this needs a rebase as I mentioned in the thread wrt to
> the original fix. I'll take a quick look though to see if I can spot
> anything else for v4.
Got it.
>
> > Changes in v2:
> >       - Refactor and make small improvements ontop of the initial fix.
> >
> > Gabriel Shahrouzi (3):
> >   iio: frequency: Use SLEEP bit instead of RESET to disable output
> >   staging: iio: ad9832: Refactor powerdown control
> >   staging: iio: ad9832: Add minor improvements to ad9832_write_powerdown
> >
> >  drivers/staging/iio/frequency/ad9832.c | 50 ++++++++++++++++++--------
> >  1 file changed, 36 insertions(+), 14 deletions(-)
> >
>