[v2] mm/vmalloc.c: code cleanup and improvements

[PATCH v2 0/5] mm/vmalloc.c: code cleanup and improvements

Posted by Baoquan He 7 months, 4 weeks ago

These were made from code inspection in mm/vmalloc.c.

v1->v2:
=======
- In patch 3:
  - made change to improve code according to Uladzislau's suggestion;
  - use WRITE_ONCE() to assign the value to vn->pool[i].len finally,
    according to Shivank's suggestion.
In patch 5:
  - add back the WARN_ON_ONCE() on returned value from va_clip()
    invocation, and also add back the code comment. These are pointed
    out by Uladzislau. 

- Add reviewers' tag from Uladzislau, Shivank and Vishal. And I only add
  Shivank's tag in patch 1, 2, 4 according to his comment because patch 3
  and 5 are changed in v2.

Baoquan He (5):
  mm/vmalloc.c: change purge_ndoes as local static variable
  mm/vmalloc.c: find the vmap of vmap_nodes in reverse order
  mm/vmalloc.c: optimize code in decay_va_pool_node() a little bit
  mm/vmalloc: optimize function vm_unmap_aliases()
  mm/vmalloc.c: return explicit error value in alloc_vmap_area()

 mm/vmalloc.c | 61 ++++++++++++++++++++++++----------------------------
 1 file changed, 28 insertions(+), 33 deletions(-)

-- 
2.41.0

Re: [PATCH v2 0/5] mm/vmalloc.c: code cleanup and improvements

Posted by Uladzislau Rezki 7 months, 3 weeks ago

On Sat, Apr 19, 2025 at 06:36:48AM +0800, Baoquan He wrote:
> These were made from code inspection in mm/vmalloc.c.
> 
> v1->v2:
> =======
> - In patch 3:
>   - made change to improve code according to Uladzislau's suggestion;
>   - use WRITE_ONCE() to assign the value to vn->pool[i].len finally,
>     according to Shivank's suggestion.
> In patch 5:
>   - add back the WARN_ON_ONCE() on returned value from va_clip()
>     invocation, and also add back the code comment. These are pointed
>     out by Uladzislau. 
> 
> - Add reviewers' tag from Uladzislau, Shivank and Vishal. And I only add
>   Shivank's tag in patch 1, 2, 4 according to his comment because patch 3
>   and 5 are changed in v2.
> 
> Baoquan He (5):
>   mm/vmalloc.c: change purge_ndoes as local static variable
>   mm/vmalloc.c: find the vmap of vmap_nodes in reverse order
>   mm/vmalloc.c: optimize code in decay_va_pool_node() a little bit
>   mm/vmalloc: optimize function vm_unmap_aliases()
>   mm/vmalloc.c: return explicit error value in alloc_vmap_area()
> 
>  mm/vmalloc.c | 61 ++++++++++++++++++++++++----------------------------
>  1 file changed, 28 insertions(+), 33 deletions(-)
> 
> -- 
> 2.41.0
> 
LGTM for whole series:

Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

--
Uladzislau Rezki