[v1] EDAC/altera: two bug fixes

[PATCH 1/2] EDAC/altera: fix cut and paste error

Posted by Matthew Gerlach 9 months, 3 weeks ago

From: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>

Fix bug testing the wrong structure member, ecc_uecnt_offset, before using
ecc_cecnt_offset.

Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>
Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
---
 drivers/edac/altera_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 3e971f902363..88d9d2f458ee 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -99,7 +99,7 @@ static irqreturn_t altr_sdram_mc_err_handler(int irq, void *dev_id)
 	if (status & priv->ecc_stat_ce_mask) {
 		regmap_read(drvdata->mc_vbase, priv->ecc_saddr_offset,
 			    &err_addr);
-		if (priv->ecc_uecnt_offset)
+		if (priv->ecc_cecnt_offset)
 			regmap_read(drvdata->mc_vbase,  priv->ecc_cecnt_offset,
 				    &err_count);
 		edac_mc_handle_error(HW_EVENT_ERR_CORRECTED, mci, err_count,
-- 
2.35.3

Re: [PATCH 1/2] EDAC/altera: fix cut and paste error

Posted by Borislav Petkov 9 months, 3 weeks ago

On Fri, Apr 18, 2025 at 07:30:51AM -0700, Matthew Gerlach wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>
> 
> Fix bug testing the wrong structure member, ecc_uecnt_offset, before using

A lot of patches "fix bug". Just write "Test the correct structure member..."

> ecc_cecnt_offset.
> 
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
> ---
>  drivers/edac/altera_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Any

Fixes:
Cc: <stable@kernel.org>

tags for this one?

You probably want this propagated to the affected trees no?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH 1/2] EDAC/altera: fix cut and paste error

Posted by Gerlach, Matthew 9 months, 3 weeks ago


On 4/18/2025 1:45 PM, Borislav Petkov wrote:
> [CAUTION: This email is from outside your organization. Unless you trust the sender, do not click on links or open attachments as it may be a fraudulent email attempting to steal your information and/or compromise your computer.]
> 
> On Fri, Apr 18, 2025 at 07:30:51AM -0700, Matthew Gerlach wrote:
>> From: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>
>>
>> Fix bug testing the wrong structure member, ecc_uecnt_offset, before using
> 
> A lot of patches "fix bug". Just write "Test the correct structure member..."

Your suggestion is a much better description.

> 
>> ecc_cecnt_offset.
>>
>> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>
>> Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
>> ---
>>  drivers/edac/altera_edac.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Any
> 
> Fixes:
> Cc: <stable@kernel.org>
> 
> tags for this one?
> 
> You probably want this propagated to the affected trees no?
> 
> Thx.

Thanks for the review,

Matthew Gerlach

> 
> --
> Regards/Gruss,
>      Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette