[PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF

Lu Baolu posted 8 patches 7 months, 4 weeks ago
drivers/accel/amdxdna/aie2_pci.c              |  13 +-
drivers/dma/idxd/init.c                       |  43 +-----
drivers/iommu/amd/iommu.c                     |  34 -----
.../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c   |  86 +----------
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c   | 136 ++++++++++--------
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h   |  39 +----
drivers/iommu/intel/iommu.c                   |  71 +++++----
drivers/iommu/intel/iommu.h                   |  33 +++++
drivers/iommu/intel/nested.c                  |  16 ++-
drivers/iommu/intel/svm.c                     |   9 +-
drivers/iommu/iommu-sva.c                     |   3 -
drivers/iommu/iommu.c                         |  32 -----
drivers/iommu/iommufd/device.c                |  59 ++++----
drivers/iommu/iommufd/eventq.c                |  48 +------
drivers/iommu/iommufd/iommufd_private.h       |   6 -
drivers/iommu/iommufd/selftest.c              |  57 ++++++--
drivers/misc/uacce/uacce.c                    |  40 ------
include/linux/iommu.h                         |  35 -----
18 files changed, 262 insertions(+), 498 deletions(-)
[PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF
Posted by Lu Baolu 7 months, 4 weeks ago
The new method for driver fault reporting support relies on the domain
to specify a iopf_handler. The driver should detect this and setup the
HW when fault capable domains are attached.

Move SMMUv3 to use this method and have VT-D validate support during
attach so that all three fault capable drivers have a no-op FEAT_SVA and
_IOPF. Then remove them.

This was initiated by Jason. I'm following up to remove FEAT_IOPF and
further clean up.

The whole series is also available at github:
https://github.com/LuBaolu/intel-iommu/commits/iommu_no_feat-v5

Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Change log:
v5:
 - Rebased to v6.15-rc1. No functionality change.

v4: https://lore.kernel.org/linux-iommu/20250313051953.4064532-1-baolu.lu@linux.intel.com/
 - Refined arm_smmu_disable_iopf() to improve code clarity.
 - Separate patches for vt-d refactoring have been merged.
 - All patches are based on the latest iommu/next branch to prevent
   potential merge conflicts.

v3: https://lore.kernel.org/linux-iommu/20250228092631.3425464-1-baolu.lu@linux.intel.com/
 - Series has been tested by Zhangfei Gao with arm-smmu-v3 driver.
 - Refined some code according to Kevin's suggestions.
 - No functional change.

v2: https://lore.kernel.org/linux-iommu/20250224051627.2956304-1-baolu.lu@linux.intel.com/
 - Fix removing wrong nesting master_domain in
   arm_smmu_remove_master_domain().
 - Fix iopf enable/disable in iommufd mock driver for domain
   replacement.

v1: https://lore.kernel.org/linux-iommu/20250214061104.1959525-1-baolu.lu@linux.intel.com/

Jason Gunthorpe (2):
  iommu/arm-smmu-v3: Put iopf enablement in the domain attach path
  iommu: Remove IOMMU_DEV_FEAT_SVA

Lu Baolu (6):
  iommu/vt-d: Put iopf enablement in domain attach path
  iommufd/selftest: Put iopf enablement in domain attach path
  dmaengine: idxd: Remove unnecessary IOMMU_DEV_FEAT_IOPF
  uacce: Remove unnecessary IOMMU_DEV_FEAT_IOPF
  iommufd: Remove unnecessary IOMMU_DEV_FEAT_IOPF
  iommu: Remove iommu_dev_enable/disable_feature()

 drivers/accel/amdxdna/aie2_pci.c              |  13 +-
 drivers/dma/idxd/init.c                       |  43 +-----
 drivers/iommu/amd/iommu.c                     |  34 -----
 .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c   |  86 +----------
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c   | 136 ++++++++++--------
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h   |  39 +----
 drivers/iommu/intel/iommu.c                   |  71 +++++----
 drivers/iommu/intel/iommu.h                   |  33 +++++
 drivers/iommu/intel/nested.c                  |  16 ++-
 drivers/iommu/intel/svm.c                     |   9 +-
 drivers/iommu/iommu-sva.c                     |   3 -
 drivers/iommu/iommu.c                         |  32 -----
 drivers/iommu/iommufd/device.c                |  59 ++++----
 drivers/iommu/iommufd/eventq.c                |  48 +------
 drivers/iommu/iommufd/iommufd_private.h       |   6 -
 drivers/iommu/iommufd/selftest.c              |  57 ++++++--
 drivers/misc/uacce/uacce.c                    |  40 ------
 include/linux/iommu.h                         |  35 -----
 18 files changed, 262 insertions(+), 498 deletions(-)

-- 
2.43.0
Re: [PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF
Posted by Zhangfei Gao 7 months, 3 weeks ago
On Fri, 18 Apr 2025 at 16:01, Lu Baolu <baolu.lu@linux.intel.com> wrote:
>
> The new method for driver fault reporting support relies on the domain
> to specify a iopf_handler. The driver should detect this and setup the
> HW when fault capable domains are attached.
>
> Move SMMUv3 to use this method and have VT-D validate support during
> attach so that all three fault capable drivers have a no-op FEAT_SVA and
> _IOPF. Then remove them.
>
> This was initiated by Jason. I'm following up to remove FEAT_IOPF and
> further clean up.
>
> The whole series is also available at github:
> https://github.com/LuBaolu/intel-iommu/commits/iommu_no_feat-v5
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Thanks Baolu for the re-spin.
Re-tested OK

Thanks
Re: [PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF
Posted by Joerg Roedel 7 months, 2 weeks ago
On Fri, Apr 18, 2025 at 04:01:22PM +0800, Lu Baolu wrote:
> Jason Gunthorpe (2):
>   iommu/arm-smmu-v3: Put iopf enablement in the domain attach path
>   iommu: Remove IOMMU_DEV_FEAT_SVA
> 
> Lu Baolu (6):
>   iommu/vt-d: Put iopf enablement in domain attach path
>   iommufd/selftest: Put iopf enablement in domain attach path
>   dmaengine: idxd: Remove unnecessary IOMMU_DEV_FEAT_IOPF
>   uacce: Remove unnecessary IOMMU_DEV_FEAT_IOPF
>   iommufd: Remove unnecessary IOMMU_DEV_FEAT_IOPF
>   iommu: Remove iommu_dev_enable/disable_feature()

Applied, thanks.