[PATCH] iio: orientation: hid-sensor-rotation: remove unnecessary alignment

David Lechner posted 1 patch 7 months, 4 weeks ago
drivers/iio/orientation/hid-sensor-rotation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] iio: orientation: hid-sensor-rotation: remove unnecessary alignment
Posted by David Lechner 7 months, 4 weeks ago
Remove __aligned(16) in the scan data struct in the hid-sensor-rotation
driver. There is nothing in the code that requires this alignment.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/iio/orientation/hid-sensor-rotation.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c
index c4b18fd0fa76c17318b262ea9f44ea5c40170298..e759f91a710a2cdec8b708faab49c557e3418146 100644
--- a/drivers/iio/orientation/hid-sensor-rotation.c
+++ b/drivers/iio/orientation/hid-sensor-rotation.c
@@ -19,7 +19,7 @@ struct dev_rot_state {
 	struct hid_sensor_common common_attributes;
 	struct hid_sensor_hub_attribute_info quaternion;
 	struct {
-		s32 sampled_vals[4] __aligned(16);
+		s32 sampled_vals[4];
 		aligned_s64 timestamp;
 	} scan;
 	int scale_pre_decml;

---
base-commit: aff301f37e220970c2f301b5c65a8bfedf52058e
change-id: 20250418-iio-orientation-hid-sensor-rotation-remove-alignment-8d8f8f814d72

Best regards,
-- 
David Lechner <dlechner@baylibre.com>
Re: [PATCH] iio: orientation: hid-sensor-rotation: remove unnecessary alignment
Posted by Andy Shevchenko 7 months, 4 weeks ago
On Fri, Apr 18, 2025 at 03:08:53PM -0500, David Lechner wrote:
> Remove __aligned(16) in the scan data struct in the hid-sensor-rotation
> driver. There is nothing in the code that requires this alignment.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH] iio: orientation: hid-sensor-rotation: remove unnecessary alignment
Posted by Jonathan Cameron 7 months, 3 weeks ago
On Sat, 19 Apr 2025 19:18:39 +0300
Andy Shevchenko <andy@kernel.org> wrote:

> On Fri, Apr 18, 2025 at 03:08:53PM -0500, David Lechner wrote:
> > Remove __aligned(16) in the scan data struct in the hid-sensor-rotation
> > driver. There is nothing in the code that requires this alignment.  
> 
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> 

Odd case. I wonder what motivated that...  Anyhow, I've applied
this to the togreg branch of iio.git and pushed that out as testing.
If there is something odd going on that the 3 of us have missed
hopefully someone will point it out!

Jonathan