strcpy() is deprecated; use strscpy() instead.

Link: https://github.com/KSPP/linux/issues/88
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/alpha/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c
index ed06367ece57..56155b988b9c 100644
--- a/arch/alpha/kernel/smp.c
+++ b/arch/alpha/kernel/smp.c
@@ -262,7 +262,7 @@ recv_secondary_console_msg(void)
 
 		cnt = cpu->ipc_buffer[0] >> 32;
 		if (cnt <= 0 || cnt >= 80)
-			strcpy(buf, "<<< BOGUS MSG >>>");
+			strscpy(buf, "<<< BOGUS MSG >>>");
 		else {
 			cp1 = (char *) &cpu->ipc_buffer[1];
 			cp2 = buf;
-- 
2.49.0

On Thu, Apr 17, 2025 at 09:20:52PM +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.

Are there more strcpy() uses in arch/alpha? Maybe do all of them and
give the Subject prefix as "alpha:". If not, the "smp:" prefix is likely
to non-specific. Maybe "alpha: smp:".

-Kees

> 
> Link: https://github.com/KSPP/linux/issues/88
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  arch/alpha/kernel/smp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c
> index ed06367ece57..56155b988b9c 100644
> --- a/arch/alpha/kernel/smp.c
> +++ b/arch/alpha/kernel/smp.c
> @@ -262,7 +262,7 @@ recv_secondary_console_msg(void)
>  
>  		cnt = cpu->ipc_buffer[0] >> 32;
>  		if (cnt <= 0 || cnt >= 80)
> -			strcpy(buf, "<<< BOGUS MSG >>>");
> +			strscpy(buf, "<<< BOGUS MSG >>>");
>  		else {
>  			cp1 = (char *) &cpu->ipc_buffer[1];
>  			cp2 = buf;
> -- 
> 2.49.0
> 
> 

-- 
Kees Cook

On 18. Apr 2025, at 22:23, Kees Cook wrote:
> On Thu, Apr 17, 2025 at 09:20:52PM +0200, Thorsten Blum wrote:
>> strcpy() is deprecated; use strscpy() instead.
> 
> Are there more strcpy() uses in arch/alpha? Maybe do all of them and
> give the Subject prefix as "alpha:". If not, the "smp:" prefix is likely
> to non-specific. Maybe "alpha: smp:".

There are a handful left, but they're not as straightforward as this
one - so I'd prefer to keep them separate.

Could the committer change the subject to "alpha: smp:" or should I
submit a v2 just for the title?

Thanks,
Thorsten

On Fri, Apr 18, 2025 at 5:11 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> On 18. Apr 2025, at 22:23, Kees Cook wrote:
> > On Thu, Apr 17, 2025 at 09:20:52PM +0200, Thorsten Blum wrote:
> >> strcpy() is deprecated; use strscpy() instead.
> >
> > Are there more strcpy() uses in arch/alpha? Maybe do all of them and
> > give the Subject prefix as "alpha:". If not, the "smp:" prefix is likely
> > to non-specific. Maybe "alpha: smp:".
>
> There are a handful left, but they're not as straightforward as this
> one - so I'd prefer to keep them separate.
>
> Could the committer change the subject to "alpha: smp:" or should I
> submit a v2 just for the title?

I'll fix it up when I add it to my tree.

Thanks!
Matt

Hi Matt,

On 19. Apr 2025, at 01:01, Matt Turner wrote:
> On Fri, Apr 18, 2025 at 5:11 PM Thorsten Blum wrote:
>> 
>> On 18. Apr 2025, at 22:23, Kees Cook wrote:
>>> On Thu, Apr 17, 2025 at 09:20:52PM +0200, Thorsten Blum wrote:
>>>> strcpy() is deprecated; use strscpy() instead.
>>> 
>>> Are there more strcpy() uses in arch/alpha? Maybe do all of them and
>>> give the Subject prefix as "alpha:". If not, the "smp:" prefix is likely
>>> to non-specific. Maybe "alpha: smp:".
>> 
>> There are a handful left, but they're not as straightforward as this
>> one - so I'd prefer to keep them separate.
>> 
>> Could the committer change the subject to "alpha: smp:" or should I
>> submit a v2 just for the title?
> 
> I'll fix it up when I add it to my tree.

This one didn't make it into the last merge window, did it?

Should I resend it or can you take care of it?

Thanks,
Thorsten