[PATCH 8/8] staging: sm750fb: rename hotPlugValue to hot_plug_value

Ruben Wauters posted 8 patches 8 months, 1 week ago
[PATCH 8/8] staging: sm750fb: rename hotPlugValue to hot_plug_value
Posted by Ruben Wauters 8 months, 1 week ago
Renames hotPlugValue to hot_plug_value

fixes checkpatch.pl's camel case check.

Signed-off-by: Ruben Wauters <rubenru09@aol.com>
---
 drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 769cbe768c49..86490c87156a 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -344,11 +344,11 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug)
  */
 unsigned char sii164_is_connected(void)
 {
-	unsigned char hotPlugValue;
+	unsigned char hot_plug_value;
 
-	hotPlugValue = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) &
-		       SII164_DETECT_HOT_PLUG_STATUS_MASK;
-	if (hotPlugValue == SII164_DETECT_HOT_PLUG_STATUS_ON)
+	hot_plug_value = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) &
+			 SII164_DETECT_HOT_PLUG_STATUS_MASK;
+	if (hot_plug_value == SII164_DETECT_HOT_PLUG_STATUS_ON)
 		return 1;
 	else
 		return 0;
-- 
2.45.2
Re: [PATCH 8/8] staging: sm750fb: rename hotPlugValue to hot_plug_value
Posted by Greg Kroah-Hartman 8 months, 1 week ago
On Thu, Apr 17, 2025 at 08:02:56PM +0100, Ruben Wauters wrote:
> Renames hotPlugValue to hot_plug_value
> 
> fixes checkpatch.pl's camel case check.
> 
> Signed-off-by: Ruben Wauters <rubenru09@aol.com>
> ---
>  drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 769cbe768c49..86490c87156a 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -344,11 +344,11 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug)
>   */
>  unsigned char sii164_is_connected(void)

This should be returning a boolean, right?  Not your fault, just noticed
it for further potential cleanups if you want to do that.

thanks,

greg k-h