[PATCH v2 1/3] dt-bindings: i2c: i2c-rk3x: Add compatible string for RK3528

Yao Zi posted 3 patches 8 months ago
[PATCH v2 1/3] dt-bindings: i2c: i2c-rk3x: Add compatible string for RK3528
Posted by Yao Zi 8 months ago
Document I2C controllers integrated in RK3528, which are compatible with
the RK3399 variant.

Signed-off-by: Yao Zi <ziyao@disroot.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
---
 Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
index 8101afa6f146..2f1e97969c3f 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
@@ -37,6 +37,7 @@ properties:
               - rockchip,px30-i2c
               - rockchip,rk3308-i2c
               - rockchip,rk3328-i2c
+              - rockchip,rk3528-i2c
               - rockchip,rk3562-i2c
               - rockchip,rk3568-i2c
               - rockchip,rk3576-i2c
-- 
2.49.0
Re: [PATCH v2 1/3] dt-bindings: i2c: i2c-rk3x: Add compatible string for RK3528
Posted by Heiko Stübner 7 months, 1 week ago
Hi Andi,

Am Donnerstag, 17. April 2025, 14:01:17 Mitteleuropäische Sommerzeit schrieb Yao Zi:
> Document I2C controllers integrated in RK3528, which are compatible with
> the RK3399 variant.
> 
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

do you expect to apply this patch to the i2c tree individually,
or have it go together with the devicetree patch?


Thanks a lot
Heiko

> ---
>  Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
> index 8101afa6f146..2f1e97969c3f 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
> @@ -37,6 +37,7 @@ properties:
>                - rockchip,px30-i2c
>                - rockchip,rk3308-i2c
>                - rockchip,rk3328-i2c
> +              - rockchip,rk3528-i2c
>                - rockchip,rk3562-i2c
>                - rockchip,rk3568-i2c
>                - rockchip,rk3576-i2c
> 
Re: [PATCH v2 1/3] dt-bindings: i2c: i2c-rk3x: Add compatible string for RK3528
Posted by Andi Shyti 7 months, 1 week ago
Hi Heiko,

On Mon, May 05, 2025 at 09:49:36AM +0200, Heiko Stübner wrote:
> Am Donnerstag, 17. April 2025, 14:01:17 Mitteleuropäische Sommerzeit schrieb Yao Zi:
> > Document I2C controllers integrated in RK3528, which are compatible with
> > the RK3399 variant.
> > 
> > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
> 
> do you expect to apply this patch to the i2c tree individually,
> or have it go together with the devicetree patch?

with these patches, I normally wait a bit to see how the others
in the same series go before merging.

I now merged this patch into i2c/i2c-host.

If there is any particular need to merge everything together in
the devicetree, then I can take it out.

Thanks,
Andi
Re: [PATCH v2 1/3] dt-bindings: i2c: i2c-rk3x: Add compatible string for RK3528
Posted by Heiko Stübner 7 months, 1 week ago
Hi Andi,

Am Montag, 5. Mai 2025, 22:47:04 Mitteleuropäische Sommerzeit schrieb Andi Shyti:
> Hi Heiko,
> 
> On Mon, May 05, 2025 at 09:49:36AM +0200, Heiko Stübner wrote:
> > Am Donnerstag, 17. April 2025, 14:01:17 Mitteleuropäische Sommerzeit schrieb Yao Zi:
> > > Document I2C controllers integrated in RK3528, which are compatible with
> > > the RK3399 variant.
> > > 
> > > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
> > 
> > do you expect to apply this patch to the i2c tree individually,
> > or have it go together with the devicetree patch?
> 
> with these patches, I normally wait a bit to see how the others
> in the same series go before merging.
> 
> I now merged this patch into i2c/i2c-host.
> 
> If there is any particular need to merge everything together in
> the devicetree, then I can take it out.

on the contrary ... I was hoping for exactly this :-) .

I.e. there is no need to merge everything together and the common pattern
is "binding goes through the driver-tree", dts goes through some soc-tree
(mine it this case).

But I can only merge the dts patches, _after_ the binding was merged,
so that was more of an elborate "ping" and _sometimes_ maintainers
might expect the binding just going with the dts patches.


So, thanks for merging the binding and I'll merge the dts patches now.


Thanks a lot
Heiko