[PATCH 0/2] rename var for slice refill event and add helper

Honglei Wang posted 2 patches 8 months ago
There is a newer version of this series
kernel/sched/ext.c             | 36 +++++++++++++++++-----------------
tools/sched_ext/scx_qmap.bpf.c |  4 ++--
2 files changed, 20 insertions(+), 20 deletions(-)
[PATCH 0/2] rename var for slice refill event and add helper
Posted by Honglei Wang 8 months ago
SCX_EV_ENQ_SLICE_DFL gives the impression that the event only occurs
when the tasks were enqueued, which seems not accurate. So rename the
variable to SCX_EV_REFILL_SLICE_DFL.

The slice refilling with default slice always come with event
statistics together, add a helper routine to make it cleaner.

Honglei Wang (2):
  sched_ext: change the variable name for slice refill event
  sched_ext: add helper for refill task with default slice

 kernel/sched/ext.c             | 36 +++++++++++++++++-----------------
 tools/sched_ext/scx_qmap.bpf.c |  4 ++--
 2 files changed, 20 insertions(+), 20 deletions(-)

-- 
2.45.2
Re: [PATCH 0/2] rename var for slice refill event and add helper
Posted by Tejun Heo 8 months ago
On Thu, Apr 17, 2025 at 04:07:06PM +0800, Honglei Wang wrote:
> SCX_EV_ENQ_SLICE_DFL gives the impression that the event only occurs
> when the tasks were enqueued, which seems not accurate. So rename the
> variable to SCX_EV_REFILL_SLICE_DFL.
> 
> The slice refilling with default slice always come with event
> statistics together, add a helper routine to make it cleaner.
> 
> Honglei Wang (2):
>   sched_ext: change the variable name for slice refill event
>   sched_ext: add helper for refill task with default slice

They look fine to me. Changwoo?

Thanks.

-- 
tejun