pmdomain: arm: Do not enable by default during compile testing

[PATCH] pmdomain: arm: Do not enable by default during compile testing

Posted by Krzysztof Kozlowski 8 months ago

Enabling the compile test should not cause automatic enabling of all
drivers, but only allow to choose to compile them.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

For longer rationale:
https://lore.kernel.org/all/191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com/
---
 drivers/pmdomain/arm/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pmdomain/arm/Kconfig b/drivers/pmdomain/arm/Kconfig
index efa139c34e08..afed10d382ad 100644
--- a/drivers/pmdomain/arm/Kconfig
+++ b/drivers/pmdomain/arm/Kconfig
@@ -2,7 +2,7 @@
 config ARM_SCMI_PERF_DOMAIN
 	tristate "SCMI performance domain driver"
 	depends on ARM_SCMI_PROTOCOL || (COMPILE_TEST && OF)
-	default y
+	default ARM_SCMI_PROTOCOL
 	select PM_GENERIC_DOMAINS if PM
 	help
 	  This enables support for the SCMI performance domains which can be
@@ -14,7 +14,7 @@ config ARM_SCMI_PERF_DOMAIN
 config ARM_SCMI_POWER_DOMAIN
 	tristate "SCMI power domain driver"
 	depends on ARM_SCMI_PROTOCOL || (COMPILE_TEST && OF)
-	default y
+	default ARM_SCMI_PROTOCOL
 	select PM_GENERIC_DOMAINS if PM
 	help
 	  This enables support for the SCMI power domains which can be
@@ -27,7 +27,7 @@ config ARM_SCMI_POWER_DOMAIN
 config ARM_SCPI_POWER_DOMAIN
 	tristate "SCPI power domain driver"
 	depends on ARM_SCPI_PROTOCOL || (COMPILE_TEST && OF)
-	default y
+	default ARM_SCPI_PROTOCOL
 	select PM_GENERIC_DOMAINS if PM
 	help
 	  This enables support for the SCPI power domains which can be
-- 
2.45.2

Re: [PATCH] pmdomain: arm: Do not enable by default during compile testing

Posted by Ulf Hansson 7 months, 3 weeks ago

On Thu, 17 Apr 2025 at 09:46, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Enabling the compile test should not cause automatic enabling of all
> drivers, but only allow to choose to compile them.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied for next, thanks!

Kind regards
Uffe


>
> ---
>
> For longer rationale:
> https://lore.kernel.org/all/191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com/
> ---
>  drivers/pmdomain/arm/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pmdomain/arm/Kconfig b/drivers/pmdomain/arm/Kconfig
> index efa139c34e08..afed10d382ad 100644
> --- a/drivers/pmdomain/arm/Kconfig
> +++ b/drivers/pmdomain/arm/Kconfig
> @@ -2,7 +2,7 @@
>  config ARM_SCMI_PERF_DOMAIN
>         tristate "SCMI performance domain driver"
>         depends on ARM_SCMI_PROTOCOL || (COMPILE_TEST && OF)
> -       default y
> +       default ARM_SCMI_PROTOCOL
>         select PM_GENERIC_DOMAINS if PM
>         help
>           This enables support for the SCMI performance domains which can be
> @@ -14,7 +14,7 @@ config ARM_SCMI_PERF_DOMAIN
>  config ARM_SCMI_POWER_DOMAIN
>         tristate "SCMI power domain driver"
>         depends on ARM_SCMI_PROTOCOL || (COMPILE_TEST && OF)
> -       default y
> +       default ARM_SCMI_PROTOCOL
>         select PM_GENERIC_DOMAINS if PM
>         help
>           This enables support for the SCMI power domains which can be
> @@ -27,7 +27,7 @@ config ARM_SCMI_POWER_DOMAIN
>  config ARM_SCPI_POWER_DOMAIN
>         tristate "SCPI power domain driver"
>         depends on ARM_SCPI_PROTOCOL || (COMPILE_TEST && OF)
> -       default y
> +       default ARM_SCPI_PROTOCOL
>         select PM_GENERIC_DOMAINS if PM
>         help
>           This enables support for the SCPI power domains which can be
> --
> 2.45.2
>

Re: [PATCH] pmdomain: arm: Do not enable by default during compile testing

Posted by Cristian Marussi 8 months ago

On Thu, Apr 17, 2025 at 09:46:45AM +0200, Krzysztof Kozlowski wrote:
> Enabling the compile test should not cause automatic enabling of all
> drivers, but only allow to choose to compile them.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian