USB: host: omap: Do not enable by default during compile testing

[PATCH] USB: host: omap: Do not enable by default during compile testing

Posted by Krzysztof Kozlowski 8 months ago

Enabling the compile test should not cause automatic enabling of all
drivers, but only allow to choose to compile them.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

For longer rationale:
https://lore.kernel.org/all/191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com/
---
 drivers/usb/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index d011d6c753ed..6dedacba94b3 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -225,7 +225,7 @@ config USB_EHCI_HCD_OMAP
 	tristate "EHCI support for OMAP3 and later chips"
 	depends on ARCH_OMAP || COMPILE_TEST
 	depends on NOP_USB_XCEIV
-	default y
+	default ARCH_OMAP
 	help
 	  Enables support for the on-chip EHCI controller on
 	  OMAP3 and later chips.
-- 
2.45.2

Re: [PATCH] USB: host: omap: Do not enable by default during compile testing

Posted by Greg Kroah-Hartman 8 months ago

On Thu, Apr 17, 2025 at 09:46:34AM +0200, Krzysztof Kozlowski wrote:
> Enabling the compile test should not cause automatic enabling of all
> drivers, but only allow to choose to compile them.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> For longer rationale:
> https://lore.kernel.org/all/191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com/
> ---
>  drivers/usb/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index d011d6c753ed..6dedacba94b3 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -225,7 +225,7 @@ config USB_EHCI_HCD_OMAP
>  	tristate "EHCI support for OMAP3 and later chips"
>  	depends on ARCH_OMAP || COMPILE_TEST
>  	depends on NOP_USB_XCEIV
> -	default y
> +	default ARCH_OMAP

Should this get a "Fixes:" tag as well?

thanks,

greg k-h

Re: [PATCH] USB: host: omap: Do not enable by default during compile testing

Posted by Krzysztof Kozlowski 8 months ago

On 17/04/2025 10:22, Greg Kroah-Hartman wrote:
> On Thu, Apr 17, 2025 at 09:46:34AM +0200, Krzysztof Kozlowski wrote:
>> Enabling the compile test should not cause automatic enabling of all
>> drivers, but only allow to choose to compile them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> For longer rationale:
>> https://lore.kernel.org/all/191543a8-2e2e-4ac4-9b2b-d253820a0c9f@app.fastmail.com/
>> ---
>>  drivers/usb/host/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index d011d6c753ed..6dedacba94b3 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -225,7 +225,7 @@ config USB_EHCI_HCD_OMAP
>>  	tristate "EHCI support for OMAP3 and later chips"
>>  	depends on ARCH_OMAP || COMPILE_TEST
>>  	depends on NOP_USB_XCEIV
>> -	default y
>> +	default ARCH_OMAP
> 
> Should this get a "Fixes:" tag as well?
> 
I think not, because some people's intention was to enable everything
during compile test, thus it was not a bug, but a feature.

Best regards,
Krzysztof