Hi Helen,
On 24/04/25 00:21, Helen Koike wrote:
> Hi Vignesh,
>
> Thanks for this version, please see my comments below.
>
> On 17/04/2025 00:04, Vignesh Raman wrote:
>> Add jobs to validate devicetrees and run KUnit tests.
>>
>> Pipeline link,
>> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1407489
>
> I see this message:
>
> WARNING: Running pip as the 'root' user can result in broken permissions
> and conflicting behaviour with the system package manager. It is
> recommended to use a virtual environment instead: https://pip.pypa.io/
> warnings/venv
We should use --break-system-packages in,
pip3 install dtschema
Will fix it. Thanks.
Regards,
Vignesh
>
>
> It would be nice to fix this at some point.
>
> With or without this, for the entire series:
>
> Acked-by: Helen Koike <helen.fornazier@gmail.com>
>
> Thanks
> Helen
>
>>
>> Link to v1,
>> https://lore.kernel.org/all/20250327160117.945165-1-
>> vignesh.raman@collabora.com/
>>
>> Link to v2,
>> https://lore.kernel.org/all/20250409061543.311184-1-
>> vignesh.raman@collabora.com/
>>
>> Vignesh Raman (2):
>> drm/ci: Add jobs to validate devicetrees
>> drm/ci: Add jobs to run KUnit tests
>>
>> drivers/gpu/drm/ci/check-devicetrees.yml | 44 ++++++++++++++++++++++++
>> drivers/gpu/drm/ci/dt-binding-check.sh | 16 +++++++++
>> drivers/gpu/drm/ci/dtbs-check.sh | 19 ++++++++++
>> drivers/gpu/drm/ci/gitlab-ci.yml | 4 +++
>> drivers/gpu/drm/ci/kunit.sh | 11 ++++++
>> drivers/gpu/drm/ci/kunit.yml | 33 ++++++++++++++++++
>> 6 files changed, 127 insertions(+)
>> create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
>> create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
>> create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
>> create mode 100755 drivers/gpu/drm/ci/kunit.sh
>> create mode 100644 drivers/gpu/drm/ci/kunit.yml
>>
>