[PATCH v3 0/6] Configure Clocks, Add Internal DMA support

Vishwaroop A posted 6 patches 8 months, 1 week ago
arch/arm64/boot/dts/nvidia/tegra234.dtsi |  10 +
drivers/spi/spi-tegra210-quad.c          | 282 +++++++++++++----------
2 files changed, 176 insertions(+), 116 deletions(-)
[PATCH v3 0/6] Configure Clocks, Add Internal DMA support
Posted by Vishwaroop A 8 months, 1 week ago
This series introduces QSPI clock configuration and internal DMA
support for Quad SPI controller. The patches have been reorganized
for better logical flow and review comments from v2 have been addressed.

Vishwaroop A (6):
  spi: tegra210-quad: Fix X1_X2_X4 encoding and support x4 transfers
  spi: tegra210-quad: remove redundant error handling code
  spi: tegra210-quad: modify chip select (CS) deactivation
  arm64: tegra: Configure QSPI clocks and add DMA
  spi: tegra210-quad: Update dummy sequence configuration
  spi: tegra210-quad: Add support for internal DMA

 arch/arm64/boot/dts/nvidia/tegra234.dtsi |  10 +
 drivers/spi/spi-tegra210-quad.c          | 282 +++++++++++++----------
 2 files changed, 176 insertions(+), 116 deletions(-)

---
v2 -> v3:
        * Reorganized the patches.
        * Addressed review comments received on the patches.
---

-- 
2.17.1
Re: [PATCH v3 0/6] Configure Clocks, Add Internal DMA support
Posted by Rob Herring (Arm) 8 months, 1 week ago
On Wed, 16 Apr 2025 11:06:00 +0000, Vishwaroop A wrote:
> This series introduces QSPI clock configuration and internal DMA
> support for Quad SPI controller. The patches have been reorganized
> for better logical flow and review comments from v2 have been addressed.
> 
> Vishwaroop A (6):
>   spi: tegra210-quad: Fix X1_X2_X4 encoding and support x4 transfers
>   spi: tegra210-quad: remove redundant error handling code
>   spi: tegra210-quad: modify chip select (CS) deactivation
>   arm64: tegra: Configure QSPI clocks and add DMA
>   spi: tegra210-quad: Update dummy sequence configuration
>   spi: tegra210-quad: Add support for internal DMA
> 
>  arch/arm64/boot/dts/nvidia/tegra234.dtsi |  10 +
>  drivers/spi/spi-tegra210-quad.c          | 282 +++++++++++++----------
>  2 files changed, 176 insertions(+), 116 deletions(-)
> 
> ---
> v2 -> v3:
>         * Reorganized the patches.
>         * Addressed review comments received on the patches.
> ---
> 
> --
> 2.17.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.15-rc2-1-g36ff6c3f5084 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250416110606.2737315-1-va@nvidia.com:

arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0008.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
	from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
	from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
	from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
	from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dtb: spi@3270000 (nvidia,tegra234-qspi): Unevaluated properties are not allowed ('iommus' was unexpected)
	from schema $id: http://devicetree.org/schemas/spi/nvidia,tegra210-quad.yaml#
Re: (subset) [PATCH v3 0/6] Configure Clocks, Add Internal DMA support
Posted by Mark Brown 7 months, 3 weeks ago
On Wed, 16 Apr 2025 11:06:00 +0000, Vishwaroop A wrote:
> This series introduces QSPI clock configuration and internal DMA
> support for Quad SPI controller. The patches have been reorganized
> for better logical flow and review comments from v2 have been addressed.
> 
> Vishwaroop A (6):
>   spi: tegra210-quad: Fix X1_X2_X4 encoding and support x4 transfers
>   spi: tegra210-quad: remove redundant error handling code
>   spi: tegra210-quad: modify chip select (CS) deactivation
>   arm64: tegra: Configure QSPI clocks and add DMA
>   spi: tegra210-quad: Update dummy sequence configuration
>   spi: tegra210-quad: Add support for internal DMA
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/6] spi: tegra210-quad: Fix X1_X2_X4 encoding and support x4 transfers
      commit: dcb06c638a1174008a985849fa30fc0da7d08904
[2/6] spi: tegra210-quad: remove redundant error handling code
      commit: 400d9f1a27cc2fceabdb1ed93eaf0b89b6d32ba5
[3/6] spi: tegra210-quad: modify chip select (CS) deactivation
      commit: d8966b65413390d1b5b706886987caac05fbe024
[5/6] spi: tegra210-quad: Update dummy sequence configuration
      commit: c283fcdc4e2b89678c171691fd26f576139fc256
[6/6] spi: tegra210-quad: Add support for internal DMA
      (no commit info)

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark