[PATCH -next] HID: hid-steam: Remove the unused variable connected

Jiapeng Chong posted 1 patch 8 months, 1 week ago
drivers/hid/hid-steam.c | 2 --
1 file changed, 2 deletions(-)
[PATCH -next] HID: hid-steam: Remove the unused variable connected
Posted by Jiapeng Chong 8 months, 1 week ago
Variable connected is not effectively used, so delete it.

drivers/hid/hid-steam.c:1153:7: warning: variable ‘connected’ set but not used.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=20462
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/hid/hid-steam.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c
index dfd9d22ed559..949d307c66a8 100644
--- a/drivers/hid/hid-steam.c
+++ b/drivers/hid/hid-steam.c
@@ -1150,11 +1150,9 @@ static void steam_client_ll_close(struct hid_device *hdev)
 	struct steam_device *steam = hdev->driver_data;
 
 	unsigned long flags;
-	bool connected;
 
 	spin_lock_irqsave(&steam->lock, flags);
 	steam->client_opened--;
-	connected = steam->connected && !steam->client_opened;
 	spin_unlock_irqrestore(&steam->lock, flags);
 
 	schedule_work(&steam->unregister_work);
-- 
2.32.0.3.g01195cf9f

Re: [PATCH -next] HID: hid-steam: Remove the unused variable connected
Posted by Jiri Kosina 7 months, 4 weeks ago
On Wed, 16 Apr 2025, Jiapeng Chong wrote:

> Variable connected is not effectively used, so delete it.
> 
> drivers/hid/hid-steam.c:1153:7: warning: variable ‘connected’ set but not used.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=20462
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs