ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y

[PATCH] ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y

Posted by Caleb Sander Mateos 8 months, 1 week ago

The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to
Y so task_work_add() can be used to dispatch I/O, improving performance.
However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill
queuing request by task_work_add"). So remove this paragraph from the
config help text.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
 drivers/block/Kconfig | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 2551ebf88dda..e48b24be45ee 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -386,16 +386,10 @@ config BLK_DEV_UBLK
 	  io_uring based userspace block driver. Together with ublk server, ublk
 	  has been working well, but interface with userspace or command data
 	  definition isn't finalized yet, and might change according to future
 	  requirement, so mark is as experimental now.
 
-	  Say Y if you want to get better performance because task_work_add()
-	  can be used in IO path for replacing io_uring cmd, which will become
-	  shared between IO tasks and ubq daemon, meantime task_work_add() can
-	  can handle batch more effectively, but task_work_add() isn't exported
-	  for module, so ublk has to be built to kernel.
-
 config BLKDEV_UBLK_LEGACY_OPCODES
 	bool "Support legacy command opcode"
 	depends on BLK_DEV_UBLK
 	default y
 	help
-- 
2.45.2

Re: [PATCH] ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y

Posted by Ming Lei 8 months, 1 week ago

On Tue, Apr 15, 2025 at 06:41:10PM -0600, Caleb Sander Mateos wrote:
> The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to
> Y so task_work_add() can be used to dispatch I/O, improving performance.
> However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill
> queuing request by task_work_add"). So remove this paragraph from the
> config help text.
> 
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming

Re: [PATCH] ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y

Posted by Jens Axboe 8 months, 1 week ago

On Tue, 15 Apr 2025 18:41:10 -0600, Caleb Sander Mateos wrote:
> The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to
> Y so task_work_add() can be used to dispatch I/O, improving performance.
> However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill
> queuing request by task_work_add"). So remove this paragraph from the
> config help text.
> 
> 
> [...]

Applied, thanks!

[1/1] ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y
      commit: 0b7a4817756c7906d0a8112c953ce88d7cd8d4c6

Best regards,
-- 
Jens Axboe

Re: [PATCH] ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y

Posted by Uday Shankar 8 months, 1 week ago

On Tue, Apr 15, 2025 at 06:41:10PM -0600, Caleb Sander Mateos wrote:
> The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to
> Y so task_work_add() can be used to dispatch I/O, improving performance.
> However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill
> queuing request by task_work_add"). So remove this paragraph from the
> config help text.
> 
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>

Reviewed-by: Uday Shankar <ushankar@purestorage.com>

> ---
>  drivers/block/Kconfig | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 2551ebf88dda..e48b24be45ee 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -386,16 +386,10 @@ config BLK_DEV_UBLK
>  	  io_uring based userspace block driver. Together with ublk server, ublk
>  	  has been working well, but interface with userspace or command data
>  	  definition isn't finalized yet, and might change according to future
>  	  requirement, so mark is as experimental now.
>  
> -	  Say Y if you want to get better performance because task_work_add()
> -	  can be used in IO path for replacing io_uring cmd, which will become
> -	  shared between IO tasks and ubq daemon, meantime task_work_add() can
> -	  can handle batch more effectively, but task_work_add() isn't exported
> -	  for module, so ublk has to be built to kernel.
> -
>  config BLKDEV_UBLK_LEGACY_OPCODES
>  	bool "Support legacy command opcode"
>  	depends on BLK_DEV_UBLK
>  	default y
>  	help
> -- 
> 2.45.2
>