arm64: dts: nuvoton: Add USB Hosts

[PATCH] arm64: dts: nuvoton: Add USB Hosts

Posted by William A. Kennington III 8 months, 1 week ago

The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support
already existing in the kernel.

Signed-off-by: William A. Kennington III <william@wkennington.com>
---
 .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
index ccebcb11c05e..b2595f5c146b 100644
--- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
+++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
@@ -63,6 +63,34 @@ mc: memory-controller@f0824000 {
 			status = "disabled";
 		};
 
+		ehci0: usb@f0828100 {
+			compatible = "nuvoton,npcm750-ehci";
+			reg = <0x0 0xf0828100 0x0 0xf00>;
+			interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
+		ehci1: usb@f082a100 {
+			compatible = "nuvoton,npcm750-ehci";
+			reg = <0x0 0xf082a100 0x0 0xf00>;
+			interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
+		ohci0: usb@f0829000 {
+			compatible = "generic-ohci";
+			reg = <0x0 0xf0829000 0x0 0x1000>;
+			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
+		ohci1: usb@f082b000 {
+			compatible = "generic-ohci";
+			reg = <0x0 0xf082b000 0x0 0x1000>;
+			interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		apb {
 			#address-cells = <1>;
 			#size-cells = <1>;
-- 
2.49.0.604.gff1f9ca942-goog

Re: [PATCH] arm64: dts: nuvoton: Add USB Hosts

Posted by Andrew Jeffery 7 months, 2 weeks ago

On Tue, 2025-04-15 at 17:18 -0700, William A. Kennington III wrote:
> The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support
> already existing in the kernel.
> 
> Signed-off-by: William A. Kennington III <william@wkennington.com>

Please rebase to address fuzz as noted here:

https://lore.kernel.org/all/2ed50b1463f62a829f863b889ab818f492b73946.camel@codeconstruct.com.au/

Andrew

Re: [PATCH] arm64: dts: nuvoton: Add USB Hosts

Posted by Krzysztof Kozlowski 8 months, 1 week ago

On 16/04/2025 02:18, William A. Kennington III wrote:
> The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support
> already existing in the kernel.
> 
> Signed-off-by: William A. Kennington III <william@wkennington.com>
> ---
>  .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++

Please do not send 10 separate patches, but one patchset for given
subsystem.

>  1 file changed, 28 insertions(+)



Best regards,
Krzysztof

Re: [PATCH] arm64: dts: nuvoton: Add USB Hosts

Posted by William Kennington 7 months, 3 weeks ago

On Tue, Apr 15, 2025 at 11:52 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 16/04/2025 02:18, William A. Kennington III wrote:
> > The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support
> > already existing in the kernel.
> >
> > Signed-off-by: William A. Kennington III <william@wkennington.com>
> > ---
> >  .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++
>
> Please do not send 10 separate patches, but one patchset for given
> subsystem.

When I send a patchset should I add the reply-to tags for all of these
previous reviews? Or just resend as a new review?

>
> >  1 file changed, 28 insertions(+)
>
>
>
> Best regards,
> Krzysztof

Re: [PATCH] arm64: dts: nuvoton: Add USB Hosts

Posted by Krzysztof Kozlowski 7 months, 3 weeks ago

On 25/04/2025 23:18, William Kennington wrote:
> On Tue, Apr 15, 2025 at 11:52 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 16/04/2025 02:18, William A. Kennington III wrote:
>>> The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support
>>> already existing in the kernel.
>>>
>>> Signed-off-by: William A. Kennington III <william@wkennington.com>
>>> ---
>>>  .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++
>>
>> Please do not send 10 separate patches, but one patchset for given
>> subsystem.
> 
> When I send a patchset should I add the reply-to tags for all of these
> previous reviews? Or just resend as a new review?

I don't understand what you are asking me. You NEVER add manually
in-reply to. You should use either git send-email or b4 or patman.
Nothing else, no manual edits, no weird headers.

If you ask about review, that's entirely different topic - see
submitting patches. BTW, kernel docs also explain how to actually send
these emails...

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: nuvoton: Add USB Hosts

Posted by Tomer Maimon 8 months, 1 week ago

Hi Krzysztof,

Thanks a lot for your review.

Can we send one patch that includes all nodes that are existing
NPCM8xx drivers in the kernel, or do you prefer a patchset that
contains patches for each NPCM8xx driver?

Thanks,

Tomer

On Wed, 16 Apr 2025 at 09:52, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 16/04/2025 02:18, William A. Kennington III wrote:
> > The npcm 8xx chip has 2 EHCI and 2 OHCI hosts with driver support
> > already existing in the kernel.
> >
> > Signed-off-by: William A. Kennington III <william@wkennington.com>
> > ---
> >  .../dts/nuvoton/nuvoton-common-npcm8xx.dtsi   | 28 +++++++++++++++++++
>
> Please do not send 10 separate patches, but one patchset for given
> subsystem.
>
> >  1 file changed, 28 insertions(+)
>
>
>
> Best regards,
> Krzysztof