[v1] arm64: dts: nuvoton: Add EDAC controller

[PATCH] arm64: dts: nuvoton: Add EDAC controller

Posted by William A. Kennington III 8 months, 1 week ago

We have the driver support but need a common node for all the 8xx
platforms that contain this device.

Signed-off-by: William A. Kennington III <william@wkennington.com>
---
 arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
index 4da62308b274..ccebcb11c05e 100644
--- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
+++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
@@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
 			#clock-cells = <1>;
 		};
 
+		mc: memory-controller@f0824000 {
+			compatible = "nuvoton,npcm845-memory-controller";
+			reg = <0x0 0xf0824000 0x0 0x2000>;
+			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		apb {
 			#address-cells = <1>;
 			#size-cells = <1>;
-- 
2.49.0.604.gff1f9ca942-goog

Re: [PATCH] arm64: dts: nuvoton: Add EDAC controller

Posted by Krzysztof Kozlowski 8 months, 1 week ago

On 16/04/2025 02:13, William A. Kennington III wrote:
> We have the driver support but need a common node for all the 8xx
> platforms that contain this device.
> 
> Signed-off-by: William A. Kennington III <william@wkennington.com>
> ---

You just sent it, so this is v2? If so, then use v2 in subject (see
other patches) and provide changelog under ---.

>  arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 4da62308b274..ccebcb11c05e 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
>  			#clock-cells = <1>;
>  		};
>  
> +		mc: memory-controller@f0824000 {
> +			compatible = "nuvoton,npcm845-memory-controller";
> +			reg = <0x0 0xf0824000 0x0 0x2000>;
> +			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> +			status = "disabled";

Why is this disabled? What resources are missing?


Best regards,
Krzysztof

Re: [PATCH] arm64: dts: nuvoton: Add EDAC controller

Posted by William Kennington 7 months, 3 weeks ago

On Tue, Apr 15, 2025 at 11:53 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 16/04/2025 02:13, William A. Kennington III wrote:
> > We have the driver support but need a common node for all the 8xx
> > platforms that contain this device.
> >
> > Signed-off-by: William A. Kennington III <william@wkennington.com>
> > ---
>
> You just sent it, so this is v2? If so, then use v2 in subject (see
> other patches) and provide changelog under ---.
>
> >  arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > index 4da62308b274..ccebcb11c05e 100644
> > --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > @@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
> >                       #clock-cells = <1>;
> >               };
> >
> > +             mc: memory-controller@f0824000 {
> > +                     compatible = "nuvoton,npcm845-memory-controller";
> > +                     reg = <0x0 0xf0824000 0x0 0x2000>;
> > +                     interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> > +                     status = "disabled";
>
> Why is this disabled? What resources are missing?
>

I was avoiding enabling anything would not be used in the most minimal
kernel configuration (Kdump). Anyone actually using the EDAC data from
the memory controller could enable it. The np]cm7xx common dts also
has this node disabled, so it would be consistent with that SoC.

>
> Best regards,
> Krzysztof

Re: [PATCH] arm64: dts: nuvoton: Add EDAC controller

Posted by Krzysztof Kozlowski 7 months, 3 weeks ago

On 25/04/2025 23:23, William Kennington wrote:
> On Tue, Apr 15, 2025 at 11:53 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 16/04/2025 02:13, William A. Kennington III wrote:
>>> We have the driver support but need a common node for all the 8xx
>>> platforms that contain this device.
>>>
>>> Signed-off-by: William A. Kennington III <william@wkennington.com>
>>> ---
>>
>> You just sent it, so this is v2? If so, then use v2 in subject (see
>> other patches) and provide changelog under ---.
>>
>>>  arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
>>> index 4da62308b274..ccebcb11c05e 100644
>>> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
>>> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
>>> @@ -56,6 +56,13 @@ clk: rstc: reset-controller@f0801000 {
>>>                       #clock-cells = <1>;
>>>               };
>>>
>>> +             mc: memory-controller@f0824000 {
>>> +                     compatible = "nuvoton,npcm845-memory-controller";
>>> +                     reg = <0x0 0xf0824000 0x0 0x2000>;
>>> +                     interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>>> +                     status = "disabled";
>>
>> Why is this disabled? What resources are missing?
>>
> 
> I was avoiding enabling anything would not be used in the most minimal
> kernel configuration (Kdump). Anyone actually using the EDAC data from
> the memory controller could enable it. The np]cm7xx common dts also
> has this node disabled, so it would be consistent with that SoC.
DTS is nowwhere relatd to your kernel configuration, so that's wrong
assumption and wrong goals. DTSI should have disabled only devices which
need board-level resources. It seems not the case here, so drop it.

Best regards,
Krzysztof