trace: tcp: Add const qualifier to skb parameter in tcp_probe event

[PATCH net-next] trace: tcp: Add const qualifier to skb parameter in tcp_probe event

Posted by Breno Leitao 9 months, 3 weeks ago

Change the tcp_probe tracepoint to accept a const struct sk_buff
parameter instead of a non-const one. This improves type safety and
better reflects that the skb is not modified within the tracepoint
implementation.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
Sending this for net-next to avoid bringing this to stable tree, which
would make backport harder for not a big benefit.
---
 include/trace/events/tcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
index 75d3d53a3832c..53e878fa14d14 100644
--- a/include/trace/events/tcp.h
+++ b/include/trace/events/tcp.h
@@ -293,7 +293,7 @@ DECLARE_TRACE(tcp_cwnd_reduction_tp,
 
 TRACE_EVENT(tcp_probe,
 
-	TP_PROTO(struct sock *sk, struct sk_buff *skb),
+	TP_PROTO(struct sock *sk, const struct sk_buff *skb),
 
 	TP_ARGS(sk, skb),
 

---
base-commit: 40ad72f88a65814ffeb1ab362074c6f8c4dc3f61
change-id: 20250416-tcp_probe-004337dc78a5

Best regards,
-- 
Breno Leitao <leitao@debian.org>

Re: [PATCH net-next] trace: tcp: Add const qualifier to skb parameter in tcp_probe event

Posted by Kuniyuki Iwashima 9 months, 3 weeks ago

From: Breno Leitao <leitao@debian.org>
Date: Wed, 16 Apr 2025 10:06:12 -0700
> Change the tcp_probe tracepoint to accept a const struct sk_buff
> parameter instead of a non-const one. This improves type safety and
> better reflects that the skb is not modified within the tracepoint
> implementation.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>