bus: mhi: host: pci_generic: Remove assign resource usage

[PATCH] bus: mhi: host: pci_generic: Remove assign resource usage

Posted by Subramanian Ananthanarayanan 8 months, 1 week ago

Avoid redundant usage of pci_assign_resource for BAR allocation.
This is already taken care by PCIe framework. Invocation of this
API leads to unnecessary relocation of BAR space to a new memory
address.

Signed-off-by: Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
---
 drivers/bus/mhi/host/pci_generic.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 03aa88795209..7501abc835c7 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
 	struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
 	int err;
 
-	err = pci_assign_resource(pdev, bar_num);
-	if (err)
-		return err;
-
 	err = pcim_enable_device(pdev);
 	if (err) {
 		dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);

---
base-commit: 5b37f7bfff3b1582c34be8fb23968b226db71ebd
change-id: 20250416-remove_assin_resource-aa0db88d02eb

Best regards,
-- 
Subramanian Ananthanarayanan <quic_skananth@quicinc.com>

Re: [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage

Posted by Manivannan Sadhasivam 7 months, 4 weeks ago

On Wed, Apr 16, 2025 at 10:49:51AM +0530, Subramanian Ananthanarayanan wrote:
> Avoid redundant usage of pci_assign_resource for BAR allocation.
> This is already taken care by PCIe framework. Invocation of this
> API leads to unnecessary relocation of BAR space to a new memory
> address.
> 
> Signed-off-by: Subramanian Ananthanarayanan <quic_skananth@quicinc.com>

Applied to mhi-next!

- Mani

> ---
>  drivers/bus/mhi/host/pci_generic.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 03aa88795209..7501abc835c7 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
>  	struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
>  	int err;
>  
> -	err = pci_assign_resource(pdev, bar_num);
> -	if (err)
> -		return err;
> -
>  	err = pcim_enable_device(pdev);
>  	if (err) {
>  		dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);
> 
> ---
> base-commit: 5b37f7bfff3b1582c34be8fb23968b226db71ebd
> change-id: 20250416-remove_assin_resource-aa0db88d02eb
> 
> Best regards,
> -- 
> Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage

Posted by Krishna Chaitanya Chundru 8 months, 1 week ago


On 4/16/2025 10:49 AM, Subramanian Ananthanarayanan wrote:
> Avoid redundant usage of pci_assign_resource for BAR allocation.
> This is already taken care by PCIe framework. Invocation of this
> API leads to unnecessary relocation of BAR space to a new memory
> address.
> 
> Signed-off-by: Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
Reviewed-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

> ---
>   drivers/bus/mhi/host/pci_generic.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 03aa88795209..7501abc835c7 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
>   	struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
>   	int err;
>   
> -	err = pci_assign_resource(pdev, bar_num);
> -	if (err)
> -		return err;
> -
>   	err = pcim_enable_device(pdev);
>   	if (err) {
>   		dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);
> 
> ---
> base-commit: 5b37f7bfff3b1582c34be8fb23968b226db71ebd
> change-id: 20250416-remove_assin_resource-aa0db88d02eb
> 
> Best regards,