arm64: dts: qcom: x1e80100-hp-omnibook-x14: Remove invalid bt-en-sleep node

[PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Remove invalid bt-en-sleep node

Posted by Juerg Haefliger via B4 Relay 8 months, 1 week ago

From: Juerg Haefliger <juerg.haefliger@canonical.com>

Remove the invalid bt-en-sleep node. Not sure how it came into existence
but it seems the functionality is covered by the wcn-wlan-bt-en-state node:

	wcn_wlan_bt_en: wcn-wlan-bt-en-state {
		pins = "gpio116", "gpio117";
		function = "gpio";
		drive-strength = <2>;
		bias-disable;
	};

This fixes the following warning:

arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dtb: pinctrl@f100000: Unevaluated properties are not allowed ('bt-en-sleep' was unexpected)
        from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
 arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
index cd860a246c45..2203abef36b5 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
@@ -1425,14 +1425,6 @@ &tlmm {
 			       <72 2>, /* Secure EC I2C connection (?) */
 			       <238 1>; /* UFS Reset */
 
-	bt_en_default: bt-en-sleep {
-		pins = "gpio116";
-		function = "gpio";
-		output-low;
-		bias-disable;
-		drive-strength = <16>;
-	};
-
 	edp_reg_en: edp-reg-en-state {
 		pins = "gpio70";
 		function = "gpio";

---
base-commit: 1a1d569a75f3ab2923cb62daf356d102e4df2b86
change-id: 20250416-fix-omnibook-dts-94c2a9264865

Best regards,
-- 
Juerg Haefliger <juerg.haefliger@canonical.com>

Re: [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Remove invalid bt-en-sleep node

Posted by Bjorn Andersson 8 months ago

On Wed, 16 Apr 2025 11:13:35 +0200, Juerg Haefliger wrote:
> Remove the invalid bt-en-sleep node. Not sure how it came into existence
> but it seems the functionality is covered by the wcn-wlan-bt-en-state node:
> 
> 	wcn_wlan_bt_en: wcn-wlan-bt-en-state {
> 		pins = "gpio116", "gpio117";
> 		function = "gpio";
> 		drive-strength = <2>;
> 		bias-disable;
> 	};
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Remove invalid bt-en-sleep node
      commit: c9e3129720104ce9f8fa556db9d83cb05e527bbb

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Remove invalid bt-en-sleep node

Posted by Konrad Dybcio 8 months, 1 week ago

On 4/16/25 11:13 AM, Juerg Haefliger via B4 Relay wrote:
> From: Juerg Haefliger <juerg.haefliger@canonical.com>
> 
> Remove the invalid bt-en-sleep node. Not sure how it came into existence
> but it seems the functionality is covered by the wcn-wlan-bt-en-state node:
> 
> 	wcn_wlan_bt_en: wcn-wlan-bt-en-state {
> 		pins = "gpio116", "gpio117";
> 		function = "gpio";
> 		drive-strength = <2>;
> 		bias-disable;
> 	};
> 
> This fixes the following warning:
> 
> arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dtb: pinctrl@f100000: Unevaluated properties are not allowed ('bt-en-sleep' was unexpected)
>         from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad