[PATCH net-next v2 1/3] net: pktgen: fix code style (ERROR: else should follow close brace '}')

Peter Seiderer posted 3 patches 8 months, 1 week ago
[PATCH net-next v2 1/3] net: pktgen: fix code style (ERROR: else should follow close brace '}')
Posted by Peter Seiderer 8 months, 1 week ago
Fix checkpatch code style errors:

  ERROR: else should follow close brace '}'
  #1317: FILE: net/core/pktgen.c:1317:
  +               }
  +               else

And checkpatch follow up code style check:

  CHECK: Unbalanced braces around else statement
  #1316: FILE: net/core/pktgen.c:1316:
  +               } else

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
  - Additional add braces around the else statement (as suggested by a follow
    up checkpatch run and by Jakub Kicinski from code review).
---
 net/core/pktgen.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index fa30ff0f2464..21206a567843 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -1313,9 +1313,9 @@ static ssize_t pktgen_if_write(struct file *file,
 				put_page(pkt_dev->page);
 				pkt_dev->page = NULL;
 			}
-		}
-		else
+		} else {
 			sprintf(pg_result, "ERROR: node not possible");
+		}
 		return count;
 	}
 	if (!strcmp(name, "xmit_mode")) {
-- 
2.49.0

Re: [PATCH net-next v2 1/3] net: pktgen: fix code style (ERROR: else should follow close brace '}')
Posted by Simon Horman 8 months ago
On Tue, Apr 15, 2025 at 01:29:14PM +0200, Peter Seiderer wrote:
> Fix checkpatch code style errors:
> 
>   ERROR: else should follow close brace '}'
>   #1317: FILE: net/core/pktgen.c:1317:
>   +               }
>   +               else
> 
> And checkpatch follow up code style check:
> 
>   CHECK: Unbalanced braces around else statement
>   #1316: FILE: net/core/pktgen.c:1316:
>   +               } else
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
>   - Additional add braces around the else statement (as suggested by a follow
>     up checkpatch run and by Jakub Kicinski from code review).

Reviewed-by: Simon Horman <horms@kernel.org>