1. Patchew
  2. linux
  3. View series

[PATCH] irqdomain: cdx: Switch to of_fwnode_handle()

Jiri Slaby (SUSE) posted 1 patch 8 months, 1 week ago 
drivers/cdx/cdx_msi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] irqdomain: cdx: Switch to of_fwnode_handle()
Posted by Jiri Slaby (SUSE) 8 months, 1 week ago 
of_node_to_fwnode() is irqdomain's reimplementation of the "officially"
defined of_fwnode_handle(). The former is in the process of being
removed, so use the latter instead.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Nipun Gupta <nipun.gupta@amd.com>
Cc: Nikhil Agarwal <nikhil.agarwal@amd.com>
---
This is an indepent patch, please apply directly.

The patch was previously a part of a large series [1], but I would like
maintainers to feed the independent parts through their trees.

[1] https://lore.kernel.org/all/20250319092951.37667-1-jirislaby@kernel.org/
---
 drivers/cdx/cdx_msi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cdx/cdx_msi.c b/drivers/cdx/cdx_msi.c
index 06d723978232..3388a5d1462c 100644
--- a/drivers/cdx/cdx_msi.c
+++ b/drivers/cdx/cdx_msi.c
@@ -165,7 +165,7 @@ struct irq_domain *cdx_msi_domain_init(struct device *dev)
 	struct device_node *parent_node;
 	struct irq_domain *parent;
 
-	fwnode_handle = of_node_to_fwnode(np);
+	fwnode_handle = of_fwnode_handle(np);
 
 	parent_node = of_parse_phandle(np, "msi-map", 1);
 	if (!parent_node) {
@@ -173,7 +173,7 @@ struct irq_domain *cdx_msi_domain_init(struct device *dev)
 		return NULL;
 	}
 
-	parent = irq_find_matching_fwnode(of_node_to_fwnode(parent_node), DOMAIN_BUS_NEXUS);
+	parent = irq_find_matching_fwnode(of_fwnode_handle(parent_node), DOMAIN_BUS_NEXUS);
 	if (!parent || !msi_get_domain_info(parent)) {
 		dev_err(dev, "unable to locate ITS domain\n");
 		return NULL;
-- 
2.49.0
Re: [PATCH] irqdomain: cdx: Switch to of_fwnode_handle()
Posted by Gupta, Nipun 8 months, 1 week ago 
This will go via Greg's char-misc tree.

On 15-04-2025 16:17, Jiri Slaby (SUSE) wrote:
> of_node_to_fwnode() is irqdomain's reimplementation of the "officially"
> defined of_fwnode_handle(). The former is in the process of being
> removed, so use the latter instead.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Nipun Gupta <nipun.gupta@amd.com>
> Cc: Nikhil Agarwal <nikhil.agarwal@amd.com>

Acked-by: Nipun Gupta <nipun.gupta@amd.com>
Re: [PATCH] irqdomain: cdx: Switch to of_fwnode_handle()
Posted by Jiri Slaby 8 months, 1 week ago 
On 16. 04. 25, 6:30, Gupta, Nipun wrote:
> This will go via Greg's char-misc tree.

Ah, then I should've sent this to him in the first place :). Uhm, but 
MAINTAINERS says:
AMD CDX BUS DRIVER
M:      Nipun Gupta <nipun.gupta@amd.com>
M:      Nikhil Agarwal <nikhil.agarwal@amd.com>
S:      Maintained
F:      Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml
F:      drivers/cdx/*
F:      include/linux/cdx/*


@Greg: do you want me to resend, or will you dig it out with b4? It's:

20250415104734.106849-1-jirislaby@kernel.org

> On 15-04-2025 16:17, Jiri Slaby (SUSE) wrote:
>> of_node_to_fwnode() is irqdomain's reimplementation of the "officially"
>> defined of_fwnode_handle(). The former is in the process of being
>> removed, so use the latter instead.
>>
>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
>> Cc: Nipun Gupta <nipun.gupta@amd.com>
>> Cc: Nikhil Agarwal <nikhil.agarwal@amd.com>
> 
> Acked-by: Nipun Gupta <nipun.gupta@amd.com>

thanks,
-- 
js
suse labs
Re: [PATCH] irqdomain: cdx: Switch to of_fwnode_handle()
Posted by Greg KH 8 months, 1 week ago 
On Wed, Apr 16, 2025 at 06:58:43AM +0200, Jiri Slaby wrote:
> On 16. 04. 25, 6:30, Gupta, Nipun wrote:
> > This will go via Greg's char-misc tree.
> 
> Ah, then I should've sent this to him in the first place :). Uhm, but
> MAINTAINERS says:
> AMD CDX BUS DRIVER
> M:      Nipun Gupta <nipun.gupta@amd.com>
> M:      Nikhil Agarwal <nikhil.agarwal@amd.com>
> S:      Maintained
> F:      Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml
> F:      drivers/cdx/*
> F:      include/linux/cdx/*
> 
> 
> @Greg: do you want me to resend, or will you dig it out with b4? It's:
> 
> 20250415104734.106849-1-jirislaby@kernel.org

I can dig it out.  but yes, the cdx stuff is a mess at times, it would
be nice if the maintainers there would get a better workflow :(

thanks,

greg k-h
Re: [PATCH] irqdomain: cdx: Switch to of_fwnode_handle()
Posted by Gupta, Nipun 8 months, 1 week ago 

On 16-04-2025 10:28, Jiri Slaby wrote:
> On 16. 04. 25, 6:30, Gupta, Nipun wrote:
>> This will go via Greg's char-misc tree.
> 
> Ah, then I should've sent this to him in the first place :). Uhm, but 
> MAINTAINERS says:
> AMD CDX BUS DRIVER
> M:      Nipun Gupta <nipun.gupta@amd.com>
> M:      Nikhil Agarwal <nikhil.agarwal@amd.com>
> S:      Maintained
> F:      Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml
> F:      drivers/cdx/*
> F:      include/linux/cdx/*

As a MAINTAINER, I/Nikhil need to review. We do not maintain a tree and 
patches go via Greg's tree.

Regards,
Nipun
Re: [PATCH] irqdomain: cdx: Switch to of_fwnode_handle()
Posted by Jiri Slaby 8 months, 1 week ago 
On 16. 04. 25, 7:06, Gupta, Nipun wrote:
> 
> 
> On 16-04-2025 10:28, Jiri Slaby wrote:
>> On 16. 04. 25, 6:30, Gupta, Nipun wrote:
>>> This will go via Greg's char-misc tree.
>>
>> Ah, then I should've sent this to him in the first place :). Uhm, but 
>> MAINTAINERS says:
>> AMD CDX BUS DRIVER
>> M:      Nipun Gupta <nipun.gupta@amd.com>
>> M:      Nikhil Agarwal <nikhil.agarwal@amd.com>
>> S:      Maintained
>> F:      Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml
>> F:      drivers/cdx/*
>> F:      include/linux/cdx/*
> 
> As a MAINTAINER, I/Nikhil need to review. We do not maintain a tree and 
> patches go via Greg's tree.

Yes, I understand, but how are patches supposed to reach him? If he 
maintains this in his tree, perhaps drivers/cdx/* deserves an entry in 
the MISC entry too?

-- 
js
suse labs

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.